Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047941Openbravo ERP00. Application dictionarypublic2021-10-27 11:302022-01-12 16:35
Reporterramprakash 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR22Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047941: Issue in creating a order line
DescriptionWhile creating a record in grid view, the DirtyEditForm is not reseting. Because of that dirtyEditForm.validateForm() is getting called and checking for the field errors.


   
Steps To Reproduce1.open sales order window .
2.create sales order header.
3.now follow the steps to create an orderline.
4.[Click create a new record in form] button , immediately click the [cancel changes and return to last saved state] button , after this simultaneously try to create a new line by clicking [insert row] button .
5.Actually if the lines are with null values , it would call the DirtyForm to indicate error, in our case as we are trying to insert a new a row after clicking the [cancel changes and return to last saved state] button , at this situation only new row has to be inserted without error.
6.Also This occurs Randomly at the situation , if we try to create a line initially in form view then cancel and then using the insertrow .
7. While creating a record in grid view, the DirtyEditForm is not reseting. Because of that dirtyEditForm.validateForm() is getting called and checking for the field errors.
8.As the error occurs at handleFieldErrors: function(errors).

for more reference --> www youtube com/watch?v=Z y x s 0 i L Z 8 g M

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00246923.0MP28 closed shankarb Double request to the datasource is done when a numeric field is in the first position of the grid 
Attached Fileszip 27927.zip (2,797,719) 2021-10-27 11:40
https://issues.openbravo.com/file_download.php?file_id=16307&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-10-27 11:30ramprakashNew Issue
2021-10-27 11:30ramprakashAssigned To => platform
2021-10-27 11:30ramprakashModules => Core
2021-10-27 11:30ramprakashTriggers an Emergency Pack => No
2021-10-27 11:37ramprakashFile Added: Screenshot 2021-10-27 at 3.03.11 PM.png
2021-10-27 11:40ramprakashFile Added: 27927.zip
2021-10-27 11:40ramprakashFile Deleted: Screenshot 2021-10-27 at 3.03.11 PM.png
2021-11-22 12:29AugustoMauchTypedesign defect => defect
2021-12-01 00:22AugustoMauchRelationship addedrelated to 0024692
2021-12-01 00:22AugustoMauchAssigned Toplatform => AugustoMauch
2021-12-01 00:22AugustoMauchStatusnew => scheduled
2021-12-01 09:29hgbotNote Added: 0133421
2021-12-02 07:18hgbotResolutionopen => fixed
2021-12-02 07:18hgbotStatusscheduled => closed
2021-12-02 07:18hgbotNote Added: 0133452
2021-12-02 07:18hgbotFixed in Version => PR22Q1
2021-12-02 07:18hgbotNote Added: 0133453
2022-01-12 16:35plujanNote Added: 0134267
2022-01-12 16:35plujanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=23509#r23509

Notes
(0133421)
hgbot   
2021-12-01 09:29   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/464 [^]
(0133452)
hgbot   
2021-12-02 07:18   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/464 [^]
(0133453)
hgbot   
2021-12-02 07:18   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: c4c1c2e295e904fe0dd25f189547a8c8ea3bda41
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 2021-12-02T06:17:44+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/c4c1c2e295e904fe0dd25f189547a8c8ea3bda41 [^]

Fixes ISSUE-47941: Validating error when creating a line

The problem was that sometimes, when creating a new record in grid mode, the new empty record was validated and
that resulted in an error because some of the mandatory fields were still empty.

The validation should not have been triggered. It was triggered in this line [1], because it detected that the filter
of a numeric filter was not undefined. It should have been undefined but instead it was null, because of this other
line [2] that transformed an undefined value to a null value. This resulted in the filter assuming that the filter value
had changed, and triggering the filter action as a result.

To fix this, the roundJsNumberUsingTypeInstance function now checks if the input value is undefined and returns immediately
in that case.

[1] https://gitlab.com/openbravo/product/openbravo/-/blob/0cce31f23f48583342d7d830e40f8624ae174bcd/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-number.js#L714 [^]
[2] https://gitlab.com/openbravo/product/openbravo/-/blob/0cce31f23f48583342d7d830e40f8624ae174bcd/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-number.js#L484 [^]

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-number.js
---
(0134267)
plujan   
2022-01-12 16:35   
I've removed the link provided as part of the issue as it might be non GDPR complaint