Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047931Retail ModulesWeb POSpublic2021-10-26 00:082021-11-08 11:12
Reporterguilleaer 
Assigned Tojustin_patterson 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR22Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047931: Store address format is not shown correctly in web POS
DescriptionStore information is shown with incorrect format

Address Information obtained by
org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/master/CrossStoreInfoProperties.java

does not provide the expected format

expected: Pau Claris - 138-1-1, 08099 Barcelona (BARCELONA), Spain
current: Pau Claris - 138 1-1 08009 Barcelona (BARCELONA ) Spain

* check that regions includes a space at the end which should be removed using trim
Steps To ReproduceLogin in POS or POS2
execute in dev tools

JSON.parse(
  OB.UTIL.localStorage.getItem('terminalSchedule')
)[0].address;

information stored there is provided by org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/master/CrossStoreInfoProperties.java

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 47931_1.diff (687) 2021-10-26 00:14
https://issues.openbravo.com/file_download.php?file_id=16301&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-10-26 00:08guilleaerNew Issue
2021-10-26 00:08guilleaerAssigned To => Retail
2021-10-26 00:08guilleaerOBNetwork customer => No
2021-10-26 00:08guilleaerTriggers an Emergency Pack => No
2021-10-26 00:14guilleaerFile Added: 47931_1.diff
2021-10-26 09:54marvintmOBNetwork customerNo => OBPS
2021-10-26 11:53marvintmStatusnew => scheduled
2021-10-26 11:53marvintmAssigned ToRetail => justin_patterson
2021-10-28 17:49hgbotMerge Request Status => open
2021-10-28 17:49hgbotNote Added: 0132719
2021-11-05 12:11hgbotNote Added: 0132870
2021-11-08 07:26hgbotMerge Request Statusopen => approved
2021-11-08 11:06hgbotNote Added: 0132883
2021-11-08 11:11hgbotNote Added: 0132884
2021-11-08 11:11hgbotResolutionopen => fixed
2021-11-08 11:11hgbotStatusscheduled => closed
2021-11-08 11:11hgbotNote Added: 0132885
2021-11-08 11:11hgbotNote Added: 0132886
2021-11-08 11:12hgbotFixed in Version => RR22Q1
2021-11-08 11:12hgbotNote Added: 0132887
2021-11-08 11:12hgbotNote Added: 0132888

Notes
(0132719)
hgbot   
2021-10-28 17:49   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/611 [^]
(0132870)
hgbot   
2021-11-05 12:11   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/141 [^]
(0132883)
hgbot   
2021-11-08 11:06   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/611 [^]
(0132884)
hgbot   
2021-11-08 11:11   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/620 [^]
(0132885)
hgbot   
2021-11-08 11:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 83a7df42242b08d41f179cb0194f4f38067f7121
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 2021-11-05T12:08:20+01:00
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/83a7df42242b08d41f179cb0194f4f38067f7121 [^]

Fixed ISSUE-47931: change CrossStoreUISelectStore test to reflect updated store address format
- Changed expected address value in checkStoreInfoPoup() on line 226 to "C. C. Galaria - Calle J # 14, 31191 Cordovilla (NAVARRA), Spain" from "C. C. Galaria - Calle J # 14 31191 Cordovilla (NAVARRA ) Spain"

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/crossstore/CrossStoreUISelectStore.java
---
(0132886)
hgbot   
2021-11-08 11:11   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/141 [^]
(0132887)
hgbot   
2021-11-08 11:12   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: bc7573b30fbcfe1efc258bac3fd83f02e4205436
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 2021-11-08T10:27:40+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/bc7573b30fbcfe1efc258bac3fd83f02e4205436 [^]

Fixed ISSUE-47931:
- Added a comma to end of address line 2 if it exists
- Implemented trim() to truncate whitespace from city name
- Added comma to end of city name, after parenthesis

---
M src/org/openbravo/retail/posterminal/master/CrossStoreInfoProperties.java
---
(0132888)
hgbot   
2021-11-08 11:12   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/620 [^]