Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047922POS2Corepublic2021-10-22 13:182021-11-18 16:24
ReporterjavierRodriguez 
Assigned Tojarmendariz 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047922: BaseKeypad only accept integers and decimal values
DescriptionDue to some changes in BaseKeypad, this component only accept integer and decimal numbers.

Previously, this component had the capacity to print any value (numbers or characters) so, for example, it was possible to create different keypads to allow different kind of values like fractions.
Steps To ReproduceCheck the validation in BaseKeypad component
Proposed SolutionRefactor BaseKeypad to just give us the UI and change ComposedKeymad to have the validation which is currently in BaseKeypad to only allow integers and decimals.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-10-22 13:18javierRodriguezNew Issue
2021-10-22 13:18javierRodriguezAssigned To => platform
2021-10-22 13:18javierRodriguezTriggers an Emergency Pack => No
2021-10-25 11:21guilleaerStatusnew => acknowledged
2021-10-29 17:01hgbotNote Added: 0132767
2021-11-05 00:29guilleaerStatusacknowledged => scheduled
2021-11-05 00:29guilleaerAssigned Toplatform => jarmendariz
2021-11-09 11:40hgbotNote Added: 0132909
2021-11-18 15:45hgbotNote Added: 0133177
2021-11-18 15:45hgbotNote Added: 0133178
2021-11-18 16:24hgbotResolutionopen => fixed
2021-11-18 16:24hgbotStatusscheduled => closed
2021-11-18 16:24hgbotNote Added: 0133193
2021-11-18 16:24hgbotNote Added: 0133194

Notes
(0132767)
hgbot   
2021-10-29 17:01   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/659 [^]
(0132909)
hgbot   
2021-11-09 11:40   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/730 [^]
(0133177)
hgbot   
2021-11-18 15:45   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 9511c8d94f6d633e79d58ee7e264ba4716d753df
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-11-18T15:03:54+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/9511c8d94f6d633e79d58ee7e264ba4716d753df [^]

Related to ISSUE-47922: Adding input validation to inputs that requires it after refactor

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CountingToolDialog/CountingTool/AddRowPopover/AddRowPopover.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/PaymentKeypad.jsx
---
(0133178)
hgbot   
2021-11-18 15:45   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/730 [^]
(0133193)
hgbot   
2021-11-18 16:24   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 49e783307db20b66cc0196485f645d80899ee13c
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-11-18T16:20:07+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/49e783307db20b66cc0196485f645d80899ee13c [^]

Fixed ISSUE-47922: Refactored BaseKeypad to not to process values received on input

---
M web-jspack/org.openbravo.core2/src/components/BaseKeypad/BaseKeypad.jsx
M web-jspack/org.openbravo.core2/src/components/ComposedKeypad/ComposedKeypad.jsx
---
(0133194)
hgbot   
2021-11-18 16:24   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/659 [^]