Openbravo Issue Tracking System - POS2
View Issue Details
0047906POS2Restaurantspublic2021-10-21 16:502021-10-27 11:34
timothee_catteeuw 
AugustoMauch 
normalcriticalalways
closedfixed 
5
 
 
No
0047906: JIRA 2437 - blocking error when switching from a menu to another
After adding 2 menus to the basket, there is a blocking error when switching from one to another --> Cannot read properties of undefined (reading 'keymapProducts')
1) Go to https://livebuilds.openbravo.com/retail_pos2_tap_pgsql/web/pos/?terminal=VBS-2 [^]
2) select restaurant schema
3) Select simple menu and add all the products needed
4) Select Non Fixed Size Menu and add all the products needed
5) Both menus are added to the basket
6) then click left "simple menu" visible at right
7 and click left "Non Fixed Size Menu visible" below
--> error appears
No tags attached.
depends on backport 0047911TAP closed AugustoMauch JIRA 2437 - blocking error when switching from a menu to another 
Issue History
2021-10-21 16:50timothee_catteeuwNew Issue
2021-10-21 16:50timothee_catteeuwAssigned To => Retail
2021-10-21 16:50timothee_catteeuwTriggers an Emergency Pack => No
2021-10-21 16:53timothee_catteeuwSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=23224#r23224
2021-10-21 16:53timothee_catteeuwSummaryJIRA 2437 - blocking error when switching from one to another => JIRA 2437 - blocking error when switching from a menu to another
2021-10-21 18:47AugustoMauchAssigned ToRetail => AugustoMauch
2021-10-21 18:48AugustoMauchStatusnew => scheduled
2021-10-22 10:26hgbotNote Added: 0132560
2021-10-26 10:57guilleaerTarget VersionTAP =>
2021-10-26 16:40hgbotNote Added: 0132653
2021-10-27 11:33hgbotResolutionopen => fixed
2021-10-27 11:33hgbotStatusscheduled => closed
2021-10-27 11:33hgbotNote Added: 0132676
2021-10-27 11:33hgbotNote Added: 0132677
2021-10-27 11:34hgbotNote Added: 0132678
2021-10-27 11:34hgbotNote Added: 0132679

Notes
(0132560)
hgbot   
2021-10-22 10:26   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/88 [^]
(0132653)
hgbot   
2021-10-26 16:40   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/656 [^]
(0132676)
hgbot   
2021-10-27 11:33   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: 8a7e86138f4dffd956bf2f5d6112e0bb50ce72dc
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 2021-10-27T11:33:33+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/8a7e86138f4dffd956bf2f5d6112e0bb50ce72dc [^]

Fixes ISSUE-47906: Prevents error when switching between menus

Some sanity checks have been added to prevent an error when the category keymap information is not set

---
M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardCategoryKeymapLayout/MenuWizardCategoryKeymapLayout.jsx
M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardProductKeymapLayout/MenuWizardProductKeymapLayout.jsx
---
(0132677)
hgbot   
2021-10-27 11:33   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/88 [^]
(0132678)
hgbot   
2021-10-27 11:34   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 4525d5c850190f2b9c3943427c2bd6164de275d7
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 2021-10-27T11:34:18+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/4525d5c850190f2b9c3943427c2bd6164de275d7 [^]

Related to ISSUE-47906: Prevents console error by not storing 0 in boolean property

---
M web-jspack/org.openbravo.core2/src/components/BaseKeymap/hooks/usePagination.js
---
(0132679)
hgbot   
2021-10-27 11:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/656 [^]