Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047904POS2Restaurantspublic2021-10-21 15:572021-12-16 18:11
Reportertimothee_catteeuw 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047904: JIRA 2328 - Sometimes it is necessary to press twice after swiping on menu components
DescriptionReproduce on https://livebuilds.openbravo.com/retail_pos2_tap_pgsql/web/pos/?terminal=VBS-2 [^]

In some cases when swiping on menu components, it is necessary to press twice a button which allows to select a product instead of just one.
Steps To Reproduce1) Connect to TAP livebuild BO with Openbravo user and White valley group admin role
2) Open restaurant menu tab, select "simple menu" and category starter
3) in that component add several products in order to have at least 20 products in it.
4) Go to "keymap product Layout default" tab
5) Add a default layout for product, in my case I tested with 4 rows * 4 columns by default
6) Go to WEP POS --> https://livebuilds.openbravo.com/retail_pos2_tap_pgsql/web/pos/?terminal=VBS-2 [^]
7) Select restaurant schema
8) press "Simple menu" button, starter has to be displayed as 2 pages
9) select all the components and finish the menu
10) press again "simple menu", starter is displayed as 2 pages as previously
9) swipe keymap to right in order to display second page
10) swipe keymap to left in order to display first page
11) Select a product, press on it once is not enough, it is necessary to press twice on it (and no error in console mode)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to backport 0048026TAP closed cberner Right click doesn't work correctly on keymap buttons 
depends on backport 0047928TAP closed Retail JIRA 2328 - Sometimes it is necessary to press twice after swiping on menu components 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-10-21 15:57timothee_catteeuwNew Issue
2021-10-21 15:57timothee_catteeuwAssigned To => Retail
2021-10-21 15:57timothee_catteeuwTriggers an Emergency Pack => No
2021-10-21 16:12timothee_catteeuwSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=23222#r23222
2021-10-25 16:47guilleaerStatusnew => acknowledged
2021-10-25 16:47guilleaerStatusacknowledged => scheduled
2021-10-25 16:47guilleaerAssigned ToRetail => AugustoMauch
2021-10-26 10:59guilleaerTarget VersionTAP =>
2021-11-10 12:41guilleaerRelationship addedrelated to 0048026
2021-11-17 15:13hgbotNote Added: 0133155
2021-11-17 16:05cbernerNote Added: 0133157
2021-12-16 18:11hgbotResolutionopen => fixed
2021-12-16 18:11hgbotStatusscheduled => closed
2021-12-16 18:11hgbotNote Added: 0133783
2021-12-16 18:11hgbotNote Added: 0133784

Notes
(0133155)
hgbot   
2021-11-17 15:13   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/667 [^]
(0133157)
cberner   
2021-11-17 16:05   
This is due to a chrome issue regarding tap after swipe not generating events: https://bugs.chromium.org/p/chromium/issues/detail?id=1141207#c15 [^]

The issue was already reported to them, and we are waiting for their response. We also prepared a reproducer for them to reproduce it more easily.

For now, we're applying a workaround which consists in generating a new click only in the case of touch mode and when this event is lost.
(0133783)
hgbot   
2021-12-16 18:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 7b7207667cfbcde732ad50b8b199d22cc564458b
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 16-12-2021 18:10:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/7b7207667cfbcde732ad50b8b199d22cc564458b [^]

Fixes ISSUE-47904: Missing click after page change on menu wizard keymap

A click goes missing when in touch mode we try to change the category or
product keymap pages by swiping to the left of the right. This only
happens in chrome or chrome based browsers when using a touch device.

Just after swiping if a click is performed it was previously not
captured. To fix this, we generate another click when this happens and
only in that particular situation. This is not a perfect fix, just a
workaround until this is fixed by chrome browser.

For more information, check this issue reported to chromium project:
https://bugs.chromium.org/p/chromium/issues/detail?id=1141207#c15 [^]

---
M web-jspack/org.openbravo.core2/src/components/BaseKeymap/PaginationGesture.config.json
M web-jspack/org.openbravo.core2/src/components/BaseKeymap/hooks/usePagination.js
---
(0133784)
hgbot   
2021-12-16 18:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/667 [^]