0004788: In tomcat filters change HttpServletRequest to HttpServletRequestWrapper

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0004788

Openbravo ERP

A. Platform

public

2008-09-01 18:45

2022-02-01 08:09

Reporter

gorka_gil

Assigned To

Triage Platform Base

Priority

low

Severity

minor

Reproducibility

N/A

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0004788: In tomcat filters change HttpServletRequest to HttpServletRequestWrapper

Description

There is three filters for request:
  - CharsetFilter.java
  - CacheFilter.java
  - SessionExpirationFilter.java

Now this filters edit directly the request/response objects.
The recommended implementation is use a wrapper:
http://java.sun.com/products/servlet/Filters.html [^]

I try to implement it in the way:

  public void doFilter(ServletRequest request, ServletResponse response, FilterChain next) throws IOException, ServletException {
    HttpServletRequestWrapper reqWrapper = new HttpServletRequestWrapper((HttpServletRequest) request);
    next.doFilter(reqWrapper, response);
    reqWrapper.setCharacterEncoding(encoding);
  }

But the problem is that the setCharacterEncoding must be done before receive the request, because after has no effect.

The actual and working solution is:

  public void doFilter(ServletRequest request, ServletResponse response, FilterChain next) throws IOException, ServletException {
    request.setCharacterEncoding(encoding);
    next.doFilter(request, response);
  }

and in the Web.xml set the CharsetFilter the first filter.

Thanks to Ville for his collaboration.

Steps To Reproduce

Now (trunk 6707), works fine,

but for test if a new implementation works:

1. Go to any window, for example, Sales order
2. In some field, for example, description
3. Introduce no standard characters, for example "€@#$%&"
4. Save

Proposed Solution

Additional Information