Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047874POS2POSpublic2021-10-18 18:022021-10-29 13:30
Reportercberner 
Assigned Tosntgreale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tocberner
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047874: Unselected items when changing from discounts window to cash up and pressing abort
DescriptionIf from item discount window we try to go to cash up and in the prompt we select Abort discounts, it will fail with the expected notification error "There are pending receipts, cashup cannot be started" but will leave the discount window open and will unselect all elements to apply discounts to, without allowing to reselect them easily.

A gif has been attached showing the error. An error notification appears(which is correct) but then all products get deselected and the discount window is still open. On Abort it should have switched to Add Product main window, when failing to enter Cashup.
Steps To Reproduce1. Open WebPOS and login
2. Add a product to the ticket
3. Click on product and then on Discount (notice the product is selected)
4. Click on the left menu, in Till -> Close Till entry
5. Click on abort in the popover regarding Applying discounts

An error notification appears(which is correct) but then all products get deselected and the discount window is still open. On Abort it should have switched to Add Product main window, when failing to enter Cashup.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesgif error still on discounts window.gif (1,042,688) 2021-10-18 18:02
https://issues.openbravo.com/file_download.php?file_id=16272&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-10-18 18:02cbernerNew Issue
2021-10-18 18:02cbernerAssigned To => Retail
2021-10-18 18:02cbernerFile Added: error still on discounts window.gif
2021-10-18 18:02cbernerTriggers an Emergency Pack => No
2021-10-18 18:13guilleaerStatusnew => acknowledged
2021-10-20 15:26sntgrealeAssigned ToRetail => sntgreale
2021-10-20 15:26sntgrealeStatusacknowledged => scheduled
2021-10-25 21:23hgbotNote Added: 0132624
2021-10-29 13:28hgbotNote Added: 0132760
2021-10-29 13:28hgbotNote Added: 0132761
2021-10-29 13:29cbernerStatusscheduled => resolved
2021-10-29 13:29cbernerResolutionopen => fixed
2021-10-29 13:30cbernerReview Assigned To => cberner
2021-10-29 13:30cbernerNote Added: 0132762
2021-10-29 13:30cbernerStatusresolved => closed

Notes
(0132624)
hgbot   
2021-10-25 21:23   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/718 [^]
(0132760)
hgbot   
2021-10-29 13:28   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 85655c82c402fd6efc44162ac8c52a83b528c94f
Author: Santiago Reale <santiago.reale@smfconsulting.es>
Date: 2021-10-29T11:22:16+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/85655c82c402fd6efc44162ac8c52a83b528c94f [^]

Fix ISSUE-47874 - Redirect page switch to Add Product when clicking abort on Discounts dialog

---
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/discounts/AddManualDiscountIntoLines.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/discounts/SelectManualDiscountsToApply.js
---
(0132761)
hgbot   
2021-10-29 13:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/718 [^]
(0132762)
cberner   
2021-10-29 13:30   
Commit to close the issue was Fix... instead of Fixes or Fixed, that's why it was not automatically closed by gitlab integration.