Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047860POS2Restaurantspublic2021-10-15 11:162021-10-26 15:28
Reportertimothee_catteeuw 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047860: JIRA 2409 - errors after copying a menu
DescriptionErrors are displayed in developer mode when you want to copy a selected menu and after selecting this option for the rest of the sales process.

After using this feature, sales process is blocked in case of our client because in their version they cannot finalize sales.

This error appears in that case :

Converting circular structure to JSON --> starting at object with constructor 'HTMLDivElement' | property '__reactFiber$fryr4xmncv' -> object with constructor 'Fl' --- property 'stateNode' closes the circle

On livebuilds, errors only appears in developer mode and you can finalyze your transactions
Steps To ReproduceGo to https://livebuilds.openbravo.com/retail_pos2_tap_pgsql/web/pos/?terminal=VBS-2 [^]
Login as vallblanca
go to Restaurant schema
select menu category
select grouped menu
select 4 products in that menu
Click left twice on menu appeared on ticket at left
A popup is displayed
Click '+' button once
An error is displayed in developer console :
createPersistoid.js:73 redux-persist/createPersistoid: error serializing state TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'HTMLDivElement'
    | property '__reactFiber$dw6c00nmux' -> object with constructor 'Wl'
    --- property 'stateNode' closes the circle
    at JSON.stringify (<anonymous>)
    at p (createPersistoid.js:126)
    at y (createPersistoid.js:71)
But a second menu is correctly added to the basket
Go back to the ticket by clicking back button
Click pay
Another error is displayed in developer console
createPersistoid.js:73 redux-persist/createPersistoid: error serializing state TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'HTMLDivElement'
    | property '__reactFiber$6nfz9pt5fft' -> object with constructor 'Wl'
    --- property 'stateNode' closes the circle
    at JSON.stringify (<anonymous>)
    at p (createPersistoid.js:126)
    at y (createPersistoid.js:71)
Select cash, many errors errors are displayed in developper console
CLick, once again many errors errors are displayed in developper console
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0047863TAP closed jorge-garcia JIRA 2409 - errors after copying a menu 
Attached Filesdiff I47860_proposedsolution.diff (3,236) 2021-10-21 16:11
https://issues.openbravo.com/file_download.php?file_id=16295&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-10-15 11:16timothee_catteeuwNew Issue
2021-10-15 11:16timothee_catteeuwAssigned To => Retail
2021-10-15 11:16timothee_catteeuwTriggers an Emergency Pack => No
2021-10-15 11:21timothee_catteeuwDescription Updatedbug_revision_view_page.php?rev_id=23186#r23186
2021-10-15 11:21timothee_catteeuwSummaryJIRA 2409 - errors when copying a menu => JIRA 2409 - errors after copying a menu
2021-10-15 14:21guilleaerStatusnew => scheduled
2021-10-15 14:21guilleaerStatusscheduled => acknowledged
2021-10-15 14:39sntgrealeAssigned ToRetail => sntgreale
2021-10-15 14:39sntgrealeStatusacknowledged => scheduled
2021-10-20 15:02hgbotNote Added: 0132490
2021-10-21 16:11jorge-garciaFile Added: I47860_proposedsolution.diff
2021-10-22 09:06hgbotNote Added: 0132553
2021-10-22 10:56hgbotNote Added: 0132568
2021-10-22 13:03jorge-garciaAssigned Tosntgreale => jorge-garcia
2021-10-22 13:03jorge-garciaReview Assigned To => AugustoMauch
2021-10-26 10:58guilleaerTarget VersionTAP =>
2021-10-26 15:28hgbotResolutionopen => fixed
2021-10-26 15:28hgbotStatusscheduled => closed
2021-10-26 15:28hgbotNote Added: 0132649
2021-10-26 15:28hgbotNote Added: 0132650

Notes
(0132490)
hgbot   
2021-10-20 15:02   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/711 [^]
(0132553)
hgbot   
2021-10-22 09:06   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/87 [^]
(0132568)
hgbot   
2021-10-22 10:56   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/711 [^]
(0132649)
hgbot   
2021-10-26 15:28   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: 76eb355c430779dfeca314318ee79ef8f4e47d4b
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 2021-10-26T13:26:43+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/76eb355c430779dfeca314318ee79ef8f4e47d4b [^]

Fixed ISSUE-47860: Removed HTMLDivElement in menus when increasing or decreasing the qty

Solve additional problem when increasing/decreasing the qty of the menu where the new
qty is added in a new line always

---
M web-jspack/org.openbravo.pos2.restaurant/src/model/food-menu/TicketLineMenuHeaderInfo.config.json
M web-jspack/org.openbravo.pos2.restaurant/src/model/user-interface/__test__/AddProductHooks.test.js
M web-jspack/org.openbravo.pos2.restaurant/src/model/user-interface/user-actions/AddProductHooks.js
---
(0132650)
hgbot   
2021-10-26 15:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/87 [^]