Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047852POS2Corepublic2021-10-14 17:432021-10-18 14:04
Reportercberner 
Assigned Tocberner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047852: JIRA-2368: Permissions are wrong for drawer menu subentries if changing user
DescriptionWhen pressing login, user actions permissions are not updated for the entries of groups of the drawer menu, resulting in this appearing as disabled when they should be enabled, and enabled when should be disabled, because the previous state is the one being mantained.

For example, a Manager with permission to all subentries logs in, he has all options available. If he doesn't refresh, logs out, and an employee with no permissions logs in, he'll have the same access to the drawer menu subentries as the manager.

Note: This doesn't affect the group button, for example Customers window works fine, and permissions are updated correctly.
Steps To Reproduce1. Login in Backoffice as Openbravo and WhiteValleyGroup admin role
2. Go to Role window and select VallBlancaManual role
2.1. In UserActionAccess remove "SwitchToOrgVariablesWindow" entry
2.2. You may logout from backoffice
3. Login in WebPOS as Vallblanca, check that Organization Variables subentry is available
4. Click on user Vallblanca to the top right, and change Profile to VallBlancaManual and check that Organization Variables subentry is disabled
5. Click Logout and login again as Vallblanca user

Option Organization Variables appears as disabled, although you're connected with a role that has permission to that user action.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0047853TAP closed cberner JIRA-2368: Permissions are wrong for drawer menu subentries if changing user 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-10-14 17:43cbernerNew Issue
2021-10-14 17:43cbernerAssigned To => cberner
2021-10-14 17:43cbernerTriggers an Emergency Pack => No
2021-10-14 17:43guilleaerStatusnew => scheduled
2021-10-14 17:43guilleaerStatusscheduled => acknowledged
2021-10-14 17:58cbernerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=23184#r23184
2021-10-15 09:51hgbotNote Added: 0132357
2021-10-18 09:26cbernerStatusacknowledged => scheduled
2021-10-18 14:04hgbotResolutionopen => fixed
2021-10-18 14:04hgbotStatusscheduled => closed
2021-10-18 14:04hgbotNote Added: 0132412
2021-10-18 14:04hgbotNote Added: 0132413

Notes
(0132357)
hgbot   
2021-10-15 09:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/649 [^]
(0132412)
hgbot   
2021-10-18 14:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 6bebef4a7f0477a3cd011c3afe7e7a4ccf31f539
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2021-10-18T13:28:46+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/6bebef4a7f0477a3cd011c3afe7e7a4ccf31f539 [^]

Fixes ISSUE-47852: Permissions are wrong for drawer menu subentries if changing user

UserAction executability was not being recalculated on login, resulting
in using the previous session/user executability for the newly logged
user. If the previous user had different permissions for a certain user
action, this was not being updated(except for the ones that are updated
due to them listening to a state model).

As such, it is required to recalculate the executability of user actions
on login. To do that, initializeAll from UserAction.js was moved to
initializeAllUserActions in Registry.js, which checks all registered
user actions, and if initialized, it only recalculates executability
with the current state.

Other options would have been to do a refresh on login or logout
process, but that is unacceptable just for this simple fix.

---
M web-jspack/org.openbravo.core2/src/core/Registry.js
M web-jspack/org.openbravo.core2/src/core/authentication/OnLoginActions.js
M web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js
M web-jspack/org.openbravo.core2/src/core/user-action/__test__/UserAction.test.js
---
(0132413)
hgbot   
2021-10-18 14:04   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/649 [^]