0047771: Remove usages of menuItemPosition - Openbravo Issue Tracking System

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0047771

POS2

Restaurants

public

2021-09-28 17:20

2024-01-04 07:17

Reporter

jarmendariz

Assigned To

Retail

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

acknowledged

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0047771: Remove usages of menuItemPosition

Description

As part of 0047516 and 0047506, a positionInMenu variable were added to be able to identify more reliably a product within a menu, but there are places where the old menuItemPosition is still used and it'd be nice to refactor this code to use only one position variable.

Steps To Reproduce

See changeset of 0047516 and 0047506 and look for places where we still use menuItemPosition and try removing it.

Proposed Solution

Try to use the output of getSelectedProductsByCategory(menuItems) instead of Ticket.line.menuItems directly because in this structure we have a positionInMenu property associated to each product and we will take into consideration the 'gaps' when no product is selected for a menu slot.

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0047516		closed	jarmendariz	Editing a product configuration on a duplicated menu item, will apply it always to the last one
depends on	defect	0047506		closed	jarmendariz	Duplicated menu items in a menu sometimes don't allow opening the popover of the item