Openbravo Issue Tracking System - Openbravo Localizations
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047766Openbravo LocalizationsLocalization Portugalpublic2021-09-28 10:342021-11-04 18:33
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0047766: Ability to include external invoice references into verified returns
Description    It would be nice to have the ability of automatically including into the verified returns the invoice information when it is maintained in a external system.

This way, when extracting the eFatura / SAFT file for a Verified Return created in the POS but whose original order is originated through an external system, the information of the original invoice will be included automatically:

...
<References>
  <Reference>External Invoice Reference</Reference>
</References>
...
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 0047749 closed caristu Openbravo Localizations Ability to include external invoice references into verified returns 
depends on feature request 0046075RR21Q3 closed Retail Retail Modules Include missing patches for RTServer integration 
Attached Filesdiff 46075-returns.diff (708) 2021-10-19 11:16
https://issues.openbravo.com/file_download.php?file_id=16278&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-09-28 10:34caristuNew Issue
2021-09-28 10:34caristuAssigned To => caristu
2021-09-28 10:34caristuOBNetwork customer => No
2021-09-28 10:34caristuIssue generated from0047749
2021-09-28 10:34caristuRelationship addeddepends on 0047749
2021-09-28 10:37hgbotMerge Request Status => open
2021-09-28 10:37hgbotNote Added: 0132035
2021-09-30 11:29hgbotMerge Request Statusopen => approved
2021-09-30 12:37hgbotResolutionopen => fixed
2021-09-30 12:37hgbotStatusnew => closed
2021-09-30 12:37hgbotNote Added: 0132083
2021-09-30 12:37hgbotNote Added: 0132084
2021-10-19 11:07hgbotNote Added: 0132440
2021-10-19 11:11caristuRelationship addeddepends on 0046076
2021-10-19 11:13caristuNote Added: 0132441
2021-10-19 11:13caristuFile Added: 47766-returns.diff
2021-10-19 11:15caristuRelationship deleteddepends on 0046076
2021-10-19 11:15caristuRelationship addeddepends on 0046075
2021-10-19 11:16caristuRelationship deleteddepends on 0046075
2021-10-19 11:16caristuFile Added: 46075-returns.diff
2021-10-19 11:16caristuFile Deleted: 47766-returns.diff
2021-10-19 11:17caristuNote Edited: 0132441bug_revision_view_page.php?bugnote_id=0132441#r23200
2021-10-19 11:19caristuRelationship addeddepends on 0046075
2021-10-19 11:19caristuNote Edited: 0132441bug_revision_view_page.php?bugnote_id=0132441#r23201
2021-10-19 11:20caristuNote Edited: 0132441bug_revision_view_page.php?bugnote_id=0132441#r23202
2021-10-20 09:59hgbotNote Added: 0132478
2021-10-20 09:59hgbotNote Added: 0132479
2021-10-20 09:59caristuNote Added: 0132480
2021-10-20 09:59caristuNote Deleted: 0132441
2021-11-04 17:07hgbotNote Added: 0132857
2021-11-04 18:33hgbotNote Added: 0132862
2021-11-04 18:33hgbotNote Added: 0132863

Notes
(0132035)
hgbot   
2021-09-28 10:37   
Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/21 [^]
(0132083)
hgbot   
2021-09-30 12:37   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail [^]
Changeset: b15026c832206e478717b1d709a3ac5426eca734
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2021-09-28T10:38:28+02:00
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/commit/b15026c832206e478717b1d709a3ac5426eca734 [^]

fixes ISSUE-47766: Ability to include external invoice refs in verified returns

---
A web/com.practicsbs.saftpt.retail/js/hooks/postAddVerifiedReturnLines.js
M src-db/database/model/modifiedTables/C_ORDER.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/com/practicsbs/saftpt/retail/SaftrComponentProvider.java
M src/com/practicsbs/saftpt/retail/master/PaidReceiptProperties.java
---
(0132084)
hgbot   
2021-09-30 12:37   
Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/21 [^]
(0132440)
hgbot   
2021-10-19 11:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/25 [^]
(0132478)
hgbot   
2021-10-20 09:59   
Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail [^]
Changeset: 1c51ce9dc6d95013eaafd7ff14eeaa43b945a417
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2021-10-19T11:04:37+02:00
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/commit/1c51ce9dc6d95013eaafd7ff14eeaa43b945a417 [^]

Related to ISSUE-47766: Don't fail if there is no originalReceipt

---
M web/com.practicsbs.saftpt.retail/js/hooks/postAddVerifiedReturnLines.js
---
(0132479)
hgbot   
2021-10-20 09:59   
Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/25 [^]
(0132480)
caristu   
2021-10-20 09:59   
This feature depends on this changeset[1] which is not present in an standard 20Q3 environment.

Attached a patch containing that changeset which should be applied in org.openbravo.retail.returns module to make this feature work properly in 20Q3.

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/15/diffs [^] [^]
(0132857)
hgbot   
2021-11-04 17:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/31 [^]
(0132862)
hgbot   
2021-11-04 18:33   
Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail [^]
Changeset: 7a99d627464c0209e4ac3799d7d0429ec760c887
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2021-11-04T17:06:29+01:00
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/commit/7a99d627464c0209e4ac3799d7d0429ec760c887 [^]

Related to ISSUE-47766: compute doc prefix only if it is signed

---
M src-test/com/practicsbs/saftpt/retail/hook/SaftrOrderLoaderHookTest.java
M src/com/practicsbs/saftpt/retail/hook/SaftrOrderLoaderHook.java
---
(0132863)
hgbot   
2021-11-04 18:33   
Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/31 [^]