Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047753POS2Corepublic2021-09-24 10:292021-09-27 13:51
Reportervmromanos 
Assigned Toalostale 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047753: POS2 only: component providers declared within a JAR are not detected
DescriptionWhen a component provider is declared into src/ (normal escenario), the POS 2 compilation process properly detects it.

However, if the same component provider is distributed under a compiled JAR file in lib/runtime/, it's not detected by the compilation process and the js resources are not considered.


In old POS the component providers in a JAR file were properly detected (because we used CDI in tomcat).
Steps To ReproduceIn a POS 2 environment:

Clone the https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france [^] in release/20Q4 branch, which is ready to work with POS 2

Clone also its dependency https://gitlab.com/openbravo/product/mods/org.openbravo.utility.opencsv [^]

Run ant smartbuild -Dlocal=no
In core2 folder run "ant"
Restart tomcat

Try to login into the new POS (either using tomcat or the development server). An error is raised because some of the JS in the french fiscal module are not found.

Proposed SolutionInstead of looking at the src/ folder, try to find the Component Providers available in the classpath.

https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/src/org/openbravo/core2/build/ModuleInfoGenerator.java#L358 [^]
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0047752 closed Retail ComponentProviders in jars are ignored 
related to defect 0047763 closed alostale remove use of guava in core2 build 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-09-24 10:29vmromanosNew Issue
2021-09-24 10:29vmromanosAssigned To => alostale
2021-09-24 10:29vmromanosTriggers an Emergency Pack => No
2021-09-27 11:33hgbotNote Added: 0132013
2021-09-27 13:51hgbotNote Added: 0132028
2021-09-27 13:51hgbotResolutionopen => fixed
2021-09-27 13:51hgbotStatusnew => closed
2021-09-27 13:51hgbotNote Added: 0132029
2021-09-27 15:11alostaleRelationship addedhas duplicate 0047752
2021-09-28 08:14alostaleRelationship addedrelated to 0047763

Notes
(0132013)
hgbot   
2021-09-27 11:33   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/637 [^]
(0132028)
hgbot   
2021-09-27 13:51   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/637 [^]
(0132029)
hgbot   
2021-09-27 13:51   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 731fcd0c4f9112c6c43a7d46b81fa20b5d876639
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-09-27T11:51:11+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/731fcd0c4f9112c6c43a7d46b81fa20b5d876639 [^]

fixed ISSUE-47753: ComponentProviders within jars are not included

ComponentProviders that were deployed in jars were not included in
generated JavaScript. In POS1, ComponentProviders are injected by CDI at
runtime, POS2 requieres them at build time when there is no CDI. It was
checking java files within src directory which does not handle jars.

This has been replaced by looking at the classpath including both
compiled classes in build/classes and any jar from
modules/**/lib/runtime.

---
M src/org/openbravo/core2/build/ModuleInfoGenerator.java
---