Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047748Retail ModulesGift cards and gift voucherspublic2021-09-23 11:492021-10-04 06:59
Reporterjetxarri 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionpiFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047748: Preference GCNV_ShowGiftCardOwnedOrBoughtByCurrentCustomer is not getting properly
DescriptionPreference GCNV_ShowGiftCardOwnedOrBoughtByCurrentCustomer is not getting properly in JAVA code.

The code is not specifying the client, org and role. Due to that, if the user configures this preference at client level is not going to work
Steps To Reproduce-Create a pref at client level with property "Web POS Show gift cards owned or bought by current customer"
-Login into Web POS
-Select a BP
-Go to details view
-Press Gift Cards/Voucher

Verify that the value of above pref is false and bp gift cards are not loaded.
Proposed SolutionAttached a diff
Additional Information
TagsNOR
Relationships
related to defect 0046586RR20Q3.1 closed rqueralta 0045829: Display and usage of gift cards / gift certificates and credit notes 
Attached Filesdiff pref.diff (983) 2021-09-23 11:49
https://issues.openbravo.com/file_download.php?file_id=16220&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-09-23 11:49jetxarriNew Issue
2021-09-23 11:49jetxarriAssigned To => Retail
2021-09-23 11:49jetxarriFile Added: pref.diff
2021-09-23 11:49jetxarriOBNetwork customer => OBPS
2021-09-23 11:49jetxarriTriggers an Emergency Pack => No
2021-09-23 14:55rafarodaTag Attached: NOR
2021-09-23 14:56rafarodaRelationship addedrelated to 0046586
2021-09-29 14:13ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-09-30 07:07hgbotMerge Request Status => open
2021-09-30 07:07hgbotNote Added: 0132072
2021-10-04 06:59hgbotMerge Request Statusopen => approved
2021-10-04 06:59hgbotResolutionopen => fixed
2021-10-04 06:59hgbotNote Added: 0132111
2021-10-04 06:59hgbotStatusnew => closed
2021-10-04 06:59hgbotNote Added: 0132112

Notes
(0132072)
hgbot   
2021-09-30 07:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/93 [^]
(0132111)
hgbot   
2021-10-04 06:59   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/93 [^]
(0132112)
hgbot   
2021-10-04 06:59   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: e92fcce6b477f8c467332f2e6bba7e0ece4d1418
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-10-04T04:59:32+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/e92fcce6b477f8c467332f2e6bba7e0ece4d1418 [^]

Fixed ISSUE-47748: Added Preference visibility when finding giftcards
* Added visibility (client, org, role) for Pref. GCNV_ShowGiftCardOwnedOrBoughtByCurrentCustomer

---
M src/org/openbravo/retail/giftcards/FindGiftCards.java
---