Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047744POS2POSpublic2021-09-23 09:102021-10-07 18:11
Reporterjmelin 
Assigned Tocaristu 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047744: JIRA 2312 - Quantity on article go under 0 when u press "-" to fast on the board
DescriptionThe issue was only reproduced a physical till (not a pc or example)

When clicking on the "-" button to decrease the quantity of a product, it can create product in the sales order with negative quantity.


Sometime u can get a pop up with the error

"Cannot destructure property 'qty' of 'o.a.App.State.getState(...).Ticket.lines.find(...)' as it is undefined"
Steps To Reproduce- Add a product several times to the ticket so that its quantity is > 1
- Click on the name of the product on the ticket area so that the product popover is open. Now click as fast as possible the minus "-" sign to decrease the quantity of the product
- If you click fast enough, the number of article will drop under 0 and create product in the sales order with a negative quantity. This is easier to reproduce if you set the Performance -> CPU property to 6xSlowdown in the Chrome Debugger

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0047747TAP closed caristu JIRA 2312 - Quantity on article go under 0 when u press "-" to fast on the board 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-09-23 09:10jmelinNew Issue
2021-09-23 09:10jmelinAssigned To => Retail
2021-09-23 09:10jmelinTriggers an Emergency Pack => No
2021-09-23 10:39guilleaerStatusnew => scheduled
2021-09-23 10:39guilleaerStatusscheduled => acknowledged
2021-09-29 08:59prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2021-09-29 09:00prakashmurugesan88Statusacknowledged => scheduled
2021-10-01 08:19prakashmurugesan88Assigned Toprakashmurugesan88 => Retail
2021-10-01 08:19prakashmurugesan88Statusscheduled => acknowledged
2021-10-01 08:19prakashmurugesan88Note Added: 0132090
2021-10-01 08:19prakashmurugesan88Note Edited: 0132090bug_revision_view_page.php?bugnote_id=0132090#r23123
2021-10-04 09:55caristuAssigned ToRetail => caristu
2021-10-05 14:00hgbotNote Added: 0132168
2021-10-05 17:48guilleaerStatusacknowledged => scheduled
2021-10-05 17:48guilleaerAssigned Tocaristu => AugustoMauch
2021-10-05 18:16AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=23151#r23151
2021-10-05 18:38AugustoMauchAssigned ToAugustoMauch => ablasco
2021-10-05 18:49caristuAssigned Toablasco => caristu
2021-10-07 18:10hgbotResolutionopen => fixed
2021-10-07 18:10hgbotStatusscheduled => closed
2021-10-07 18:10hgbotNote Added: 0132259
2021-10-07 18:10hgbotNote Added: 0132260
2021-10-07 18:11AugustoMauchStatusclosed => resolved
2021-10-07 18:11AugustoMauchStatusresolved => closed

Notes
(0132090)
prakashmurugesan88   
2021-10-01 08:19   
Decided to move this issue to the Platform team to be fixed in general for all user-actions in pos2
(0132168)
hgbot   
2021-10-05 14:00   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/642 [^]
(0132259)
hgbot   
2021-10-07 18:10   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 39f0e631b74fc62ee452b1a081bfc3ae14964767
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2021-10-07T18:09:49+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/39f0e631b74fc62ee452b1a081bfc3ae14964767 [^]

fixes ISSUE-47744: display BasePopovers behind the user action scrim

  The UserActionScrim is a scrim that is rendered meanwhile a user
action is being executed in order to avoid accidental clicks which may
accidentaly launch other user actions while having a user action in
progress.

  This scrim "protects" from this accidental clicks by being placing in
front of the whole application.

  The problem was that default z-index of the BasePopover components
makes them to be rendered ahead of the scrim. With this fix, we are
making the BasePopover components to be rendered behind the scrim by
setting a z-index value small enough to achieve that.

---
A web-jspack/org.openbravo.core2/src/components/BasePopover/stories/MockBasePopover.jsx
M web-jspack/org.openbravo.core2/src/components/BasePopover/BasePopover.jsx
M web-jspack/org.openbravo.core2/src/components/BasePopover/BasePopover.scss
M web-jspack/org.openbravo.core2/src/components/BasePopover/__test__/BasePopover.test.jsx
M web-jspack/org.openbravo.core2/src/components/BasePopover/stories/BasePopover.stories.jsx
---
(0132260)
hgbot   
2021-10-07 18:10   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/642 [^]