Openbravo Issue Tracking System - POS2 | |||||
| View Issue Details | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0047727 | POS2 | Restaurants | public | 2021-09-21 10:45 | 2021-10-18 09:34 |
| Reporter | AugustoMauch | ||||
| Assigned To | jorge-garcia | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Platform | OS | 5 | OS Version | ||
| Product Version | |||||
| Target Version | Fixed in Version | ||||
| Merge Request Status | |||||
| Review Assigned To | AugustoMauch | ||||
| OBNetwork customer | |||||
| Support ticket | |||||
| Regression level | |||||
| Regression date | |||||
| Regression introduced in release | |||||
| Regression introduced by commit | |||||
| Triggers an Emergency Pack | No | ||||
| Summary | 0047727: Improvements on GetTicketMenuLineWithSameInformation | ||||
| Description | The web-jspack/org.openbravo.pos2.restaurant/src/model/food-menu/GetTicketLineMenuWithSameInformation.js is in charge of, given a ticket and a menu (with menu items), determining if they are equivalent. This is used for instance to decide whether to add a menu in a new ticket line, or to merge into an existing one. The way this check is done makes it difficult to maintain. Each time a new relevant property is added to the menu items (i.e. product configuration), someone has to remember to update GetTicketLineMenuWithSameInformation to take into account the new info. There are already two relevant properties that are not being taken into account: - schema (at menu level) - product configuration (at menu and menu item level) In this issue, we should either: - Update getTicketMenuLineWithSameInformation to take into account the missing relevant properties, or - Change the way the comparison is done to make maintenance easier (i.e. to check by default the equality of all the properties (doing a deep object comparison), excluding only the irrelevant properties (i.e. order line ID). | ||||
| Steps To Reproduce | - See implementation of https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/blob/master/web-jspack/org.openbravo.pos2.restaurant/src/model/food-menu/GetTicketLineMenuWithSameInformation.js [^] | ||||
| Proposed Solution | |||||
| Additional Information | |||||
| Tags | No tags attached. | ||||
| Relationships | |||||
| Attached Files | |||||
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
| 2021-09-21 10:45 | AugustoMauch | New Issue | |||
| 2021-09-21 10:45 | AugustoMauch | Assigned To | => Retail | ||
| 2021-09-21 10:45 | AugustoMauch | Triggers an Emergency Pack | => No | ||
| 2021-09-21 12:54 | jorge-garcia | Status | new => scheduled | ||
| 2021-09-21 12:54 | jorge-garcia | Assigned To | Retail => jorge-garcia | ||
| 2021-09-22 16:07 | hgbot | Note Added: 0131977 | |||
| 2021-09-23 08:43 | jorge-garcia | Review Assigned To | => AugustoMauch | ||
| 2021-10-18 09:34 | hgbot | Resolution | open => fixed | ||
| 2021-10-18 09:34 | hgbot | Status | scheduled => closed | ||
| 2021-10-18 09:34 | hgbot | Note Added: 0132382 | |||
| 2021-10-18 09:34 | hgbot | Note Added: 0132383 | |||
| Notes | |||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||