Openbravo Issue Tracking System - Openbravo Localizations
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047721Openbravo LocalizationsLocalization Portugalpublic2021-09-20 15:382022-02-28 12:44
Reporterpsanjuan 
Assigned Tocaristu 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Support ticket
OBNetwork customerGold
Regression introduced in release
Summary0047721: SAFT file does not include Reference information, in case of a Blind Return that becomes Verified.
DescriptionSAFT file does not include Reference information, in case of a Blind Return that becomes Verified.
Steps To ReproduceIn an enviroment with PT certification code installed and configured, navigate to a POS terminal.
Select any product. Click on Return Line button.
Click on Check-out. Verify that a message is shown saying:
"Please, provide original document number in description field of the receipt properties". See image attached. This is correct.
Introduce that information. See image attached.

Launch the e-fatura file for that given date.

Verify there is no Reference node for that return (Nota de crédito).

current SAFT information
<Invoice>
<InvoiceNo>NC A019NCS/00004</InvoiceNo>
<ATCUD>0</ATCUD>
<DocumentStatus>
<InvoiceStatus>N</InvoiceStatus>
<InvoiceStatusDate>2021-09-20T15:19:48</InvoiceStatusDate>
<SourceID>vallblanca</SourceID>
<SourceBilling>P</SourceBilling>
</DocumentStatus>
<Hash>W4UDzwtto0sH2iYZtqWMbqdijIPrL3qMucbzMkkfxfxBV29rsJeHZEdatNOlLsTNh+PJJFqrcaXxJVaKo6TplLwvEefqaqjah37PS5+8Gy4trwxGH76rmrJa7PDAu3VLG5VDlplC57pERt78MBGGzAk+sZU+IW4ZlzEVRGmhdts=</Hash>
<HashControl>2</HashControl>
<InvoiceDate>2021-09-20</InvoiceDate>
<InvoiceType>NC</InvoiceType>
<SpecialRegimes>
<SelfBillingIndicator>0</SelfBillingIndicator>
<CashVATSchemeIndicator>0</CashVATSchemeIndicator>
<ThirdPartiesBillingIndicator>0</ThirdPartiesBillingIndicator>
</SpecialRegimes>
<SourceID>vallblanca</SourceID>
<SystemEntryDate>2021-09-20T15:19:48</SystemEntryDate>
<CustomerID>T019/C001</CustomerID>
<Line>
<LineNumber>1</LineNumber>
<ProductCode>T01</ProductCode>
<ProductDescription>T01 - Test Produto Normal</ProductDescription>
<Quantity>1</Quantity>
<UnitOfMeasure>Unit</UnitOfMeasure>
<UnitPrice>81.3</UnitPrice>
<TaxPointDate>2021-09-20</TaxPointDate>
<Description>T01 - Test Produto Normal</Description>
<DebitAmount>81.30</DebitAmount>
<Tax>
<TaxType>IVA</TaxType>
<TaxCountryRegion>PT</TaxCountryRegion>
<TaxCode>NOR</TaxCode>
<TaxPercentage>23</TaxPercentage>
</Tax>
</Line>
<DocumentTotals>
<TaxPayable>18.70</TaxPayable>
<NetTotal>81.30</NetTotal>
<GrossTotal>100.00</GrossTotal>
</DocumentTotals>
</Invoice>
Proposed Solutioncorrect one

<Invoice>
<InvoiceNo>NC A019NCS/00002</InvoiceNo>
<ATCUD>0</ATCUD>
<DocumentStatus>
<InvoiceStatus>N</InvoiceStatus>
<InvoiceStatusDate>2021-09-20T15:11:00</InvoiceStatusDate>
<SourceID>vallblanca</SourceID>
<SourceBilling>P</SourceBilling>
</DocumentStatus>
<Hash>rVEnbPbGCwQEUG/SkpsUq/W1isW8busmIhpO4diw8N8XJTKTltjOipLwOpB6Ja5BBpTaS+frX0QG0AS7nR9/VxsoOzNQ5U8+vBqvvA02LzXfp0OnRJmY3skXPgfBIsLha+1tCFSw4iHKqYalRiGjuAZ1hTilTDylgKNDSI8tVp4=</Hash>
<HashControl>2</HashControl>
<InvoiceDate>2021-09-20</InvoiceDate>
<InvoiceType>NC</InvoiceType>
<SpecialRegimes>
<SelfBillingIndicator>0</SelfBillingIndicator>
<CashVATSchemeIndicator>0</CashVATSchemeIndicator>
<ThirdPartiesBillingIndicator>0</ThirdPartiesBillingIndicator>
</SpecialRegimes>
<SourceID>vallblanca</SourceID>
<SystemEntryDate>2021-09-20T15:11:00</SystemEntryDate>
<CustomerID>T019/C001</CustomerID>
<Line>
<LineNumber>1</LineNumber>
<ProductCode>T01</ProductCode>
<ProductDescription>T01 - Test Produto Normal</ProductDescription>
<Quantity>1</Quantity>
<UnitOfMeasure>Unit</UnitOfMeasure>
<UnitPrice>81.3</UnitPrice>
<TaxPointDate>2021-09-20</TaxPointDate>
<References>
<Reference>FS A019FS/00002</Reference>
</References>
<Description>T01 - Test Produto Normal</Description>
<DebitAmount>81.30</DebitAmount>
<Tax>
<TaxType>IVA</TaxType>
<TaxCountryRegion>PT</TaxCountryRegion>
<TaxCode>NOR</TaxCode>
<TaxPercentage>23</TaxPercentage>
</Tax>
</Line>
<DocumentTotals>
<TaxPayable>18.70</TaxPayable>
<NetTotal>81.30</NetTotal>
<GrossTotal>100.00</GrossTotal>
</DocumentTotals>
</Invoice>
Additional Information
TagsNOR
Relationships
related to feature request 0047749 closed caristu Ability to include external invoice references into verified returns 
related to defect 0048713 closed jorge-garcia Original document number must be included in ticket description also when using Return Line 
Attached Filespng Campo_Description.png (731,545) 2021-09-20 15:40
https://issues.openbravo.com/file_download.php?file_id=16204&type=bug
png Receipt_Properties.png (604,711) 2021-09-20 16:49
https://issues.openbravo.com/file_download.php?file_id=16206&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-09-20 15:38psanjuanNew Issue
2021-09-20 15:38psanjuanAssigned To => forge_aes
2021-09-20 15:38psanjuanOBNetwork customer => No
2021-09-20 15:40psanjuanFile Added: Campo_Description.png
2021-09-20 15:40psanjuanFile Added: Receipt_Properties.png
2021-09-20 15:46rafarodaTag Attached: NOR
2021-09-20 15:59psanjuanFile Deleted: Receipt_Properties.png
2021-09-20 16:07psanjuanAssigned Toforge_aes => aferraz
2021-09-20 16:07psanjuanCategoryLocalization Peru => Localization Portugal
2021-09-20 16:49psanjuanFile Added: Receipt_Properties.png
2021-09-21 11:31caristuIssue cloned0047729
2021-09-21 13:02rafarodaOBNetwork customerNo => Gold
2021-09-21 14:43psanjuanNote Added: 0131953
2021-09-21 14:43psanjuanNote Added: 0131954
2021-09-21 14:45psanjuanSummarySAFT file do not include Reference information, in case of a Blind Return that becomes Verified. => SAFT file does not include Reference information, in case of a Blind Return that becomes Verified.
2021-09-21 14:45psanjuanDescription Updatedbug_revision_view_page.php?rev_id=23102#r23102
2021-09-28 10:59vmromanosStatusnew => acknowledged
2021-09-29 17:33caristuRelationship addedrelated to 0047749
2021-09-29 17:34caristuNote Added: 0132071
2021-09-29 17:34caristuNote Edited: 0132071bug_revision_view_page.php?bugnote_id=0132071#r23120
2021-09-29 17:35caristuNote View State: public: 132071
2021-09-29 17:38aferrazAssigned Toaferraz => psanjuan
2021-09-30 12:34caristuNote Edited: 0132071bug_revision_view_page.php?bugnote_id=0132071#r23121
2021-10-06 11:32caristuAssigned Topsanjuan => caristu
2021-10-06 11:32hgbotMerge Request Status => open
2021-10-06 11:32hgbotNote Added: 0132192
2021-10-11 13:47hgbotMerge Request Statusopen => approved
2021-10-13 17:50hgbotResolutionopen => fixed
2021-10-13 17:50hgbotStatusacknowledged => closed
2021-10-13 17:50hgbotNote Added: 0132327
2021-10-13 17:50hgbotNote Added: 0132328
2022-02-28 12:44hgbotNote Added: 0135338
2022-03-03 14:23aferrazRelationship addedrelated to 0048713

Notes
(0131953)
psanjuan   
2021-09-21 14:43   
El popup que valida que la descripción se rellene en caso de blind returns es un desarrollo contribuido a la versión de SAFT de 20Q3:

https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail/-/merge_requests/10 [^]
(0131954)
psanjuan   
2021-09-21 14:43   
Reportado


http://practicsbs.zendesk.com/hc/requests/11471 [^]
(0132071)
caristu   
2021-09-29 17:34   
(edited on: 2021-09-30 12:34)
When fixing this issue please take into account that with the fix for issue 0047749 the verified returns can also include the information of the original invoice on their description.

Ensure that the following works fine after the fix:

- Original invoice reference is printed in case of Blind Return.
- Original invoice reference is printed in case of normal Verified Return.
- Original invoice reference is printed in case of Verified Return that contains the invoice reference on its description.
- Original invoice reference is included in SAFT in case of Blind Return.
- Original invoice reference is included in SAFT in case of normal Verified Return.
- Original invoice reference is included in SAFT in case of Verified Return that contains the invoice reference on its description.
(0132192)
hgbot   
2021-10-06 11:32   
Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/22 [^]
(0132327)
hgbot   
2021-10-13 17:50   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt [^]
Changeset: a9323e14fa1bb867ef168580b6e4e4a7970063d6
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2021-10-06T11:30:49+02:00
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/commit/a9323e14fa1bb867ef168580b6e4e4a7970063d6 [^]

fixes ISSUE-47721: Add reference info for blind returns becoming verified

  Take reference information from the return description in those cases
where is not possible to find the referenced invoice because is not
present in the database.

---
M src/com/practicsbs/saftpt/data/ExportSourceDocs.java
M src/com/practicsbs/saftpt/data/Invoices_data.xsql
---
(0132328)
hgbot   
2021-10-13 17:50   
Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/22 [^]
(0135338)
hgbot   
2022-02-28 12:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt [^]
Changeset: d6f52bf9ed26a5e051dd71ccf10fc6e8e45f3ded
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 28-02-2022 11:44:20
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/commit/d6f52bf9ed26a5e051dd71ccf10fc6e8e45f3ded [^]

fixes ISSUE-47721: Add reference info for blind returns becoming verified

  Take reference information from the return description in those cases
where is not possible to find the referenced invoice because is not
present in the database.


(cherry picked from commit a9323e14fa1bb867ef168580b6e4e4a7970063d6)
---
M src/com/practicsbs/saftpt/data/ExportSourceDocs.java
M src/com/practicsbs/saftpt/data/Invoices_data.xsql
---