Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047653Retail ModulesWeb POSpublic2021-09-08 12:552021-09-09 15:18
Reporterjorge-garcia 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047653: Counting safe boxes caused import entry to status error with pos2 module installed
DescriptionThis issue is reproducible if the following module is installed:
org.openbravo.pos2

When the import entry of a "Count Safe Box" record is processed, the Import Entry ends in an Error status
Steps To ReproducePrerequisite: Have installed org.openbravo.pos2 module

1) Login using vallblanca credentials in the old POS application for the terminal VBSSB1
2) When asked, insert Safe Box search key VBSB01
3) Open the menu and select count safe box
4) Complete the count safe box process
5) Go to the ERP to Data Import Entries window
6) Verify there is a record in status Error
7) Verify also Errors while Importing POS Data does not have any record
Proposed Solution1) Make necessary changes to not to set Data Import Entries in status error, and, in case Count Safe Box entry has an error, to be set into Errors While Importing POS Data (as other informating comming from POS application)

2) Fix the backwards compatibility problem with the org.openbravo.pos2 module
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-09-08 12:55jorge-garciaNew Issue
2021-09-08 12:55jorge-garciaAssigned To => Retail
2021-09-08 12:55jorge-garciaTriggers an Emergency Pack => No
2021-09-08 12:55jorge-garciaAssigned ToRetail => jorge-garcia
2021-09-08 12:55jorge-garciaStatusnew => scheduled
2021-09-08 13:20hgbotNote Added: 0131652
2021-09-08 13:34hgbotNote Added: 0131653
2021-09-09 08:24jorge-garciaReview Assigned To => marvintm
2021-09-09 15:18hgbotResolutionopen => fixed
2021-09-09 15:18hgbotStatusscheduled => closed
2021-09-09 15:18hgbotFixed in Version => RR21Q4
2021-09-09 15:18hgbotNote Added: 0131673
2021-09-09 15:18hgbotNote Added: 0131674
2021-09-09 15:18hgbotNote Added: 0131675
2021-09-09 15:18hgbotNote Added: 0131676
2021-09-09 15:18hgbotNote Added: 0131677

Notes
(0131652)
hgbot   
2021-09-08 13:20   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/567 [^]
(0131653)
hgbot   
2021-09-08 13:34   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/671 [^]
(0131673)
hgbot   
2021-09-09 15:18   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 883e0c77a7dfc5fee6e9346c221ee63cb15277e6
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 2021-09-09T08:19:02+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/883e0c77a7dfc5fee6e9346c221ee63cb15277e6 [^]

Fixed ISSUE-47653: Pass posterminal id into countSafeBox synchronized information

This way, the import entry record will generate a Error While Importing POS Data
instead of set the import entry in Error status in case an error is reaised during
the process

---
M src/org/openbravo/retail/posterminal/ProcessCountSafeBox.java
M web/org.openbravo.retail.posterminal/js/closecash/model/countsafebox/countsafebox-model.js
---
(0131674)
hgbot   
2021-09-09 15:18   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 54e025e7987fe3d08dcafbf11081f3c6b1cc4579
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 2021-09-09T07:59:43+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/54e025e7987fe3d08dcafbf11081f3c6b1cc4579 [^]

Related to ISSUE-47653: Mantain backwards compatibility with CountSafeBox
done in the old POS application

---
M src/org/openbravo/pos2/UpdateSafeboxCountPerAmountHook.java
---
(0131675)
hgbot   
2021-09-09 15:18   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 319b9557ab0d402e9c818921da526c89fe680a82
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 2021-09-09T13:43:58+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/319b9557ab0d402e9c818921da526c89fe680a82 [^]

Related to ISSUE-47653: Avoid Initial Count Safe Box to set
Import Entry on Error state

In case of error, Initial Count Safe Box will create a record
in Errors While Importing POS Data and set Processed state

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/PreparePayloadForFinishInitialCount.js
---
(0131676)
hgbot   
2021-09-09 15:18   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/671 [^]
(0131677)
hgbot   
2021-09-09 15:18   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/567 [^]