Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047617Openbravo ERPB. User interfacepublic2021-09-01 17:492022-04-29 13:50
Reportersalvador_campanella 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR22Q3 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047617: Some language filters do not work properly
DescriptionSome language filters do not work properly. It is possible to use those filters by entering data in the filter input, but selecting an option from the filter dropdown does not work.

A language selectors works properly in a tab (i.e. header tab of Module window), but not in others (for instance header tab of User window)
Steps To Reproduce- Go to user windows
- Try to filter by any language option
Result: No results

Try to filter with the 3 first characters of the language
Result the records appear

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0047760 new Triage Platform Base Customer cannot find record using search in SO/SI 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-09-01 17:49salvador_campanellaNew Issue
2021-09-01 17:49salvador_campanellaAssigned To => platform
2021-09-01 17:49salvador_campanellaModules => Core
2021-09-01 17:49salvador_campanellaTriggers an Emergency Pack => No
2021-10-06 07:07alostaleRelationship addedrelated to 0047760
2021-12-01 13:58AugustoMauchNote Added: 0133429
2022-01-05 14:01AugustoMauchStatusnew => scheduled
2022-01-05 14:01AugustoMauchAssigned Toplatform => AugustoMauch
2022-01-05 14:10AugustoMauchSummaryThe filter for default language cannot filter when the value have parenthesis => Some language filters do not work properly
2022-01-05 14:10AugustoMauchDescription Updatedbug_revision_view_page.php?rev_id=23486#r23486
2022-01-05 14:11AugustoMauchDescription Updatedbug_revision_view_page.php?rev_id=23487#r23487
2022-01-05 14:20hgbotNote Added: 0134136
2022-04-29 13:50hgbotResolutionopen => fixed
2022-04-29 13:50hgbotStatusscheduled => closed
2022-04-29 13:50hgbotFixed in Version => PR22Q3
2022-04-29 13:50hgbotNote Added: 0136870
2022-04-29 13:50hgbotNote Added: 0136871

Notes
(0133429)
AugustoMauch   
2021-12-01 13:58   
Working language selector: https://livebuilds.openbravo.com/erp_pi_pgsql/?tabId=102&recordId=106 [^]
Non-working language selector: https://livebuilds.openbravo.com/erp_pi_pgsql/?tabId=102&recordId=800106 [^]
(0134136)
hgbot   
2022-01-05 14:20   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/493 [^]
(0136870)
hgbot   
2022-04-29 13:50   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: bf7054d12ed753105c5315b05e049f224bb417be
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 29-04-2022 11:49:59
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/bf7054d12ed753105c5315b05e049f224bb417be [^]

Fixes ISSUE-47617: Some language filters do not work properly

The problem was that in the datasource request to obtain the unique entries to populate the filter dropdown, the key property of that selector
was not being included in the _selectedProperties parameter.

In that request, _selectedProperties contained the properties of the grid the selector
belong to, but not the relevant properties of the referenced entity. For instance, in the request to populate the combo of the language selector
of User, the grid properties of User were included in _selectedProperties, but not "language" which is the key property of the referenced entity.

This is why in some windows worked, for instance the language combo in the Module window was properly populated because that window also contained
a "language" property, so by luck it had the same name as the key property of Language.

To fix this, we now ensure that they key property of the referenced entity is included in the _selectedProperties parameter. I prefer not to remove
the unrelated properties from _selectedProperties to be conservative and lower the regression risk.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
---
(0136871)
hgbot   
2022-04-29 13:50   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/493 [^]