Openbravo Issue Tracking System - POS2
View Issue Details
0047591POS2Corepublic2021-08-25 11:582022-03-14 10:44
aferraz 
cberner 
normalmajorhave not tried
closedfixed 
5
 
 
No
0047591: Terminal model not updated in incremental refresh
Terminal model not updated in incremental refresh
- Login in VBS-2 terminal and check current schema name is "Store".
- Login in backoffice, navigate to "POS Schema" window and rename Store schema as "Test".
- Refresh VBS-2 terminal and check current schema name is still "Store". Clean cache, login again and check current schema name is now "Test".
We currently have a chance of data inconsistency due to the fact that the terminal information refresh happens in a different process than the masterdata, and information entities depend on each other.

The plan is to include the terminal information refresh as part of the main masterdata refresh, so that they always happen together.

This will include a functional change, as currently the terminal information is always refreshed during the login:
- After this change, the terminal information will be refreshed during the login when incremental or full refresh takes place, and not if they don't
- It will also be refreshed when the user clicks on "Refresh data" (as this will also cause an incremental masterdata refresh).
- Finally, it will also be done when masterdata is refreshed incrementally as part of the interval
No tags attached.
related to design defect 0047717 closed cberner JIRA 2327 - POS - no incremental refresh of "Hardware manager" 
causes defect 0048782 closed cberner Terminal Authentication field doesn't appear when configured 
Issue History
2021-08-25 11:58aferrazNew Issue
2021-08-25 11:58aferrazAssigned To => platform
2021-08-25 11:58aferrazTriggers an Emergency Pack => No
2021-09-03 15:22dmiguelezRegression date => 2021-10-01
2021-09-03 15:22dmiguelezStatusnew => acknowledged
2021-09-03 15:23dmiguelezRegression date2021-10-01 =>
2021-10-18 10:18guilleaerNote Added: 0132393
2021-10-18 10:18guilleaerTypedefect => design defect
2021-10-18 10:21guilleaerRelationship addedrelated to 0047717
2021-10-18 12:25marvintmProposed Solution updated
2022-02-01 08:07alostaleAssigned Toplatform => Triage Platform Base
2022-02-03 13:53hgbotNote Added: 0134760
2022-02-03 13:54hgbotNote Added: 0134761
2022-02-03 14:01cbernerNote Added: 0134762
2022-02-03 16:22guilleaerStatusacknowledged => scheduled
2022-02-03 16:23guilleaerAssigned ToTriage Platform Base => cberner
2022-02-22 13:47hgbotNote Added: 0135216
2022-02-23 13:55hgbotNote Added: 0135247
2022-03-10 23:39hgbotResolutionopen => fixed
2022-03-10 23:39hgbotStatusscheduled => closed
2022-03-10 23:39hgbotFixed in Version => RR22Q2
2022-03-10 23:39hgbotNote Added: 0135637
2022-03-10 23:39hgbotNote Added: 0135638
2022-03-10 23:40hgbotNote Added: 0135639
2022-03-10 23:40hgbotNote Added: 0135640
2022-03-10 23:41hgbotNote Added: 0135641
2022-03-10 23:41hgbotNote Added: 0135642
2022-03-10 23:42hgbotNote Added: 0135643
2022-03-10 23:42hgbotNote Added: 0135644
2022-03-14 09:45hgbotNote Added: 0135671
2022-03-14 10:44hgbotNote Added: 0135672
2022-03-14 10:44hgbotNote Added: 0135673
2022-03-14 14:53cbernerRelationship addedcauses 0048782

Notes
(0132393)
guilleaer   
2021-10-18 10:18   
Currently terminal model is working as was designed.
After talk about that a new project will be launched to unify the way to update terminal model togeteher with master data refresh
(0134760)
hgbot   
2022-02-03 13:53   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/695 [^]
(0134761)
hgbot   
2022-02-03 13:54   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/325 [^]
(0134762)
cberner   
2022-02-03 14:01   
Technical design of this project: https://docs.google.com/document/d/1Gst3Uo_pqcizVD4dRDF3OZiEHnnwwDl6ZEvRilfiSIY/edit# [^]
(0135216)
hgbot   
2022-02-22 13:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/117 [^]
(0135247)
hgbot   
2022-02-23 13:55   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/828 [^]
(0135637)
hgbot   
2022-03-10 23:39   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: b3d09896ae72fcdf1f327166d2885eab2b91a447
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 10-03-2022 23:38:31
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/b3d09896ae72fcdf1f327166d2885eab2b91a447 [^]

Fixes ISSUE-47591: Merge branch 'fix/47591-terminal-info-load'

---
M web-test/model/masterdata/MasterdataHooks.test.js
M web/org.openbravo.mobile.core/app/model/masterdata/MasterdataController.js
---
(0135638)
hgbot   
2022-03-10 23:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/325 [^]
(0135639)
hgbot   
2022-03-10 23:40   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 83e64e8ff333fa5b684d6a0e8d6516ec6d8ab9c9
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 10-03-2022 23:39:55
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/83e64e8ff333fa5b684d6a0e8d6516ec6d8ab9c9 [^]

Fixes ISSUE-47591: Merge branch 'fix/47591-terminal-info-load'

---
A web-jspack/org.openbravo.core2/src/core/terminal/OnTerminalDataUpdateActions.js
A web-jspack/org.openbravo.core2/src/core/terminal/TerminalDataMasterdataHooks.js
A web-jspack/org.openbravo.core2/src/core/terminal/__test__/TerminalDataMasterdataHooks.test.js
A web-jspack/org.openbravo.core2/src/model/user-interface/actions/SetShouldRefreshApplication.js
A web-jspack/org.openbravo.core2/src/model/user-interface/actions/SetTerminalDataChanged.js
M web-jspack/org.openbravo.core2/src/core/authentication/InitializeAppData.js
M web-jspack/org.openbravo.core2/src/core/authentication/LoginProcess.js
M web-jspack/org.openbravo.core2/src/core/terminal/Security.js
M web-jspack/org.openbravo.core2/src/core/terminal/Terminal.js
M web-jspack/org.openbravo.core2/src/model/user-interface/UI.js
M web-jspack/org.openbravo.core2/src/model/user-interface/user-actions/RefreshMasterdata.js
M web-jspack/org.openbravo.core2/src/ob-init.js
---
(0135640)
hgbot   
2022-03-10 23:40   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/695 [^]
(0135641)
hgbot   
2022-03-10 23:41   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: bf3f115ed68f4d26d0ad3943f1eefd27bfb416d2
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 10-03-2022 23:41:11
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/bf3f115ed68f4d26d0ad3943f1eefd27bfb416d2 [^]

Fixes ISSUE-47591: Merge branch 'fix/47591-terminal-info-load'

---
M src/org/openbravo/pos2/login/POS2LoginUtilsServlet.java
M web-jspack/org.openbravo.pos2/src/authentication/loginInitActions.js
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerFormHandler.js
M web-jspack/org.openbravo.pos2/src/model/quotation/user-actions/allowsQuotationsForAnonymousCustomerOrIsNotAnonymous.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProduct.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/CancelTicket.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/CompleteTicket.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReplaceTicket.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnVerifiedTicket.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/AbortInitialCount.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0135642)
hgbot   
2022-03-10 23:41   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/828 [^]
(0135643)
hgbot   
2022-03-10 23:42   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: 8b573b6a2616f966553c974918d5a569b802f56a
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 10-03-2022 23:42:08
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/8b573b6a2616f966553c974918d5a569b802f56a [^]

Fixes ISSUE-47591: Merge branch 'fix/47591-terminal-info-load'

---
M web-jspack/org.openbravo.pos2.restaurant/src/ob-init.js
R web-jspack/org.openbravo.pos2.restaurant/src/authentication/loginInitActions.js
---
(0135644)
hgbot   
2022-03-10 23:42   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/117 [^]
(0135671)
hgbot   
2022-03-14 09:45   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/717 [^]
(0135672)
hgbot   
2022-03-14 10:44   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: dfc1279b18265dd2511194414b863094fc87068c
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 14-03-2022 09:44:43
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/dfc1279b18265dd2511194414b863094fc87068c [^]

Related to ISSUE-47591: Add missing test for Terminal.mergeWithTerminalInfo function

---
M web-jspack/org.openbravo.core2/src/core/terminal/__test__/Terminal.test.js
---
(0135673)
hgbot   
2022-03-14 10:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/717 [^]