0047575: Incremental Masterdata refresh only loads the first batch of each model, ignoring those in the 2nd+ batch

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0047575

Retail Modules

Web POS

public

2021-08-09 12:49

2021-08-23 06:11

Reporter

cberner

Assigned To

ranjith_qualiantech_com

Priority

high

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR21Q2.2

Fixed in Version

RR21Q2.2

Merge Request Status

approved

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Production - Confirmed Stable

Regression date

2020-02-28

Regression introduced in release

main

Regression introduced by commit

https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/87c3e6d251f0c8db080607ba3c4739a551bde0b9 [^]

Triggers an Emergency Pack

Summary

0047575: Incremental Masterdata refresh only loads the first batch of each model, ignoring those in the 2nd+ batch

Description

If an incremental masterdata refresh is done and there is a model, for example Product with new entries higher than masterdata refresh batch size(this is by default 10000, but it can be modified with OBMOBC_MasterdataBatchSize preference) it will only load the first batch of products, ignoring all the rest.

Same applies to all masterdata models.

Steps To Reproduce

Previously log at least once into WebPOS so it completely refreshes masterdata.

1. Login in Backoffice as White Valley Group admin
2. Go to preferences and create a new one:
  - Property: Masterdata models batch size
  - Value: 2
  - Make sure visibility at User is none (seems Openbravo by default)
3. Go to Color window and create at least 3 new colors on the default color palette, or on a new one.
4. Login in WebPOS and click on top-right gear, Refresh Masterdata
5. Using dev-tools, go to Application -> IndexedDB -> Color, check that not all elements have been loaded. Checking console you should be able to see this:

[incrementalMasterdataRefresh] Starting incremental RefreshMasterdata in IndexedDB; line: MasterdataController.incrementalMasterdataRefresh (http://localhost:3000/static/js/6.chunk.js:10004:10 [^]) (*)
POS2.js:3243 [RefreshMasterdata] The model Color has finished loading a total of 2 records in 16 ms. Loaded in page 1; line: MasterdataController.refreshMasterdata (http://localhost:3000/static/js/6.chunk.js:9853:18 [^]) (*)
POS2.js:3243 Loading page 2 of Color model...; line: MasterdataController.refreshMasterdata (http://localhost:3000/static/js/6.chunk.js:9812:18 [^]) (*)
[incrementalMasterdataRefresh] Finished incremental RefreshMasterdata in IndexedDB; line: MasterdataController.incrementalMasterdataRefresh (http://localhost:3000/static/js/6.chunk.js:10008:10 [^]) (*)

You can see here, that there was a try to load a second page, but it didn't work, no new entries from the second page have been added.

Proposed Solution

Additional Information