Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0047552 | Openbravo ERP | 07. Sales management | public | 2021-08-14 02:09 | 2021-08-30 11:44 |
|
| Reporter | lbressan | |
| Assigned To | vmromanos | |
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | PR21Q4 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0047552: Error while issue sales order with positive tolerance |
| Description | When we activate the tolerance in the products and in the Advance Warehouse, when the tolerance is higher than the ordered quantity of the Sales Order, the difference is NOT being invoiced:
Example: Sales Order, with a line of a product of quantity 10, issues the sales order for 11, generates a sales invoice of 10, when it should generate a sales invoice with a line with 11 |
| Steps To Reproduce | 1) Access Sales Order and Create a header for any Business Partner and a warehouse that has positive tolerance enabled.
2) Create a line with any product that has Stock, and put operational quantity in 10. Then Book the Sales Order
3) Positioned in the header of the Sales Order, Press the Pick button, and in the task in question, change the Confirmed Quantity to 12, then confirm the Picking
4) Press the Issue button, without changing anything.
5) Access Sales Invoice and you will see that the amount invoiced will be 10, when it should be 12. |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2021-08-14 02:09 | lbressan | New Issue | |
| 2021-08-14 02:09 | lbressan | Assigned To | => Triage Finance |
| 2021-08-14 02:09 | lbressan | Resolution time | => 1630620000 |
| 2021-08-23 11:08 | dmiguelez | Assigned To | Triage Finance => vmromanos |
| 2021-08-25 14:37 | vmromanos | Project | Modules => Openbravo ERP |
| 2021-08-25 14:38 | vmromanos | Modules | => Core |
| 2021-08-25 14:38 | vmromanos | Triggers an Emergency Pack | => No |
| 2021-08-25 14:38 | vmromanos | Note Added: 0131361 | |
| 2021-08-25 14:38 | vmromanos | Category | Advance Warehouse Operations => 07. Sales management |
| 2021-08-25 14:44 | vmromanos | Status | new => scheduled |
| 2021-08-25 14:44 | vmromanos | Note Added: 0131362 | |
| 2021-08-25 14:49 | vmromanos | Note Added: 0131364 | |
| 2021-08-25 14:49 | vmromanos | Note Edited: 0131364 | bug_revision_view_page.php?bugnote_id=0131364#r23039 |
| 2021-08-26 14:20 | hgbot | Note Added: 0131376 | |
| 2021-08-30 11:44 | hgbot | Note Added: 0131431 | |
| 2021-08-30 11:44 | hgbot | Note Added: 0131432 | |
| 2021-08-30 11:44 | hgbot | Resolution | open => fixed |
| 2021-08-30 11:44 | hgbot | Status | scheduled => closed |
| 2021-08-30 11:44 | hgbot | Note Added: 0131433 | |
| 2021-08-30 11:44 | hgbot | Fixed in Version | => PR21Q4 |
| 2021-08-30 11:44 | hgbot | Note Added: 0131434 | |
| 2021-08-30 11:44 | hgbot | Note Added: 0131435 | |
|
Notes |
|
|
|
|
Originally reported for the WMS, but actually it's a bug in Core |
|
|
|
|
Steps to reproduce in Core:
Login as F&B admin
Go to Product window and search for Vino Tinto 0,75L product.
Set Is Quantity Variable flag to Yes
Create a Sales Order:
- F&B España - Región Norte
- Hoteles Buenas Noches, S.A.
- After Delivery
Enter 10 units of Vino Tinto 0,75L
Book it.
Go to Goods Shipment and create a new record:
- F&B España - Región Norte
- Hoteles Buenas Noches, S.A.
Press Create Lines From:
- Rn-0-0-0
- Order: the one just created
- Select the line for 10 units
Go to Lines tab and change the qty to 11 units
Complete the goods shipment:
- Set "Invoice if possible"
Browse to the new invoice created (doc. no shown in the success message)
Go the invoice lines.
The invoice quantity is 10 but it should be 11 units |
|
|
|
|
Test plan I (Immediate/After Delivery):
Login as F&B admin
Go to Product window and search for Vino Tinto 0,75L product.
Set Is Quantity Variable flag to Yes
Create a Sales Order:
- F&B España - Región Norte
- Hoteles Buenas Noches, S.A.
- Immediate
Enter 10 units of Vino Tinto 0,75L
Book it.
Go to Goods Shipment and create a new record:
- F&B España - Región Norte
- Hoteles Buenas Noches, S.A.
Press Create Lines From:
- Rn-0-0-0
- Order: the one just created
- Select the line for 10 units
Go to Lines tab and change the qty to 11 units
Complete the goods shipment:
- Set "Invoice if possible"
Browse to the new invoice created (doc. no shown in the success message)
Go the invoice lines.
The invoice quantity is 11 [before the fix was 10 units]
Test plan II (After Delivery):
Repeat test plan I, but setting sales order invoice terms to "After Delivery".
The results should be the same.
Test plan III (After Order Delivered):
Repeat test plan I, but setting sales order invoice terms to "After Order Delivery".
The results should be the same [before the fix the invoice was not generated]
|
|
|
|
(0131376)
|
|
hgbot
|
|
2021-08-26 14:20
|
|
|
|
|
(0131431)
|
|
hgbot
|
|
2021-08-30 11:44
|
|
|
|
|
(0131432)
|
|
hgbot
|
|
2021-08-30 11:44
|
|
|
|
|
(0131433)
|
|
hgbot
|
|
2021-08-30 11:44
|
|
|
|
|
(0131434)
|
|
hgbot
|
|
2021-08-30 11:44
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 89871c14fe9491f1d87e27ec2d1bbb28711736f0
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2021-08-26T14:35:17+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/89871c14fe9491f1d87e27ec2d1bbb28711736f0 [^]
Fixed ISSUE-47552: Invoice generator from goods shipment with positive tolerance
The fix makes sure we invoice any quantity shipped that wasn't been invoiced yet.
The code has been fixed in two concrete places, both associated with the scenario of
a goods shipment linked to a sales order:
1. When the invoice terms is After Order delivery: in this case que make sure we invoice
even in the case the order's delivery status is greater than 100 (that might happen with
quantity variable products or tolerances in WMS).
2. When the invoice terms allows to invoice before the shipment: in this case the formula
to calculate the qty to invoice has changed. Before it was:
min(qtyOrdered - qtyInvoiced, qtyInThisShipment).
which was trying to support the corner case where the sales order was previously invoiced
before the shipment.
After the fix the formula is:
qtyTotallyShipped - qtyPreviouslyInvoiced
and supports the corner case where the sales order has been previously invoiced but in a
different way. Instead of looking at the qty being shipped right now, it considers all the
shipped qty (including this shipment). This allows to easily know the qty actually pending
to invoice.
---
M src/org/openbravo/materialmgmt/InvoiceGeneratorFromGoodsShipment.java
---
|
|
|
|
(0131435)
|
|
hgbot
|
|
2021-08-30 11:44
|
|
|