Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0004754Openbravo ERPA. Platformpublic2008-08-29 10:492019-02-05 08:28
jordimas 
alostale 
lowminoralways
closedfixed 
5
pi 
3.0PR19Q2 
Core
No
0004754: Remove avalon-framework-4.1.5.jar dependency
Hello,

The Apache Avalon project has been closed[1]

We are only using the Log4JLogger class from this library and it is only used at src-core/src/org/openbravo/base/ConfigParameters.java and src-core/src/org/openbravo/base/HttpBaseServlet.java.

Can we rewrite the code and remove this dependency?

Regards,

Jordi,

[1] http://avalon.apache.org/closed.html [^]
Clean-up, ReleaseCandidate
depends on backport 0004923 closed alostale Remove avalon-framework-4.1.5.jar dependency 
depends on feature request 0037874 closed alostale Remove support for fop rendering from core product as very nearly not used 
Issue History
2008-08-29 10:49jordimasNew Issue
2008-08-29 10:49jordimasAssigned To => cromero
2008-08-29 10:49jordimassf_bug_id0 => 2082062
2008-08-29 10:49jordimasRegression testing => No
2008-08-30 21:25shuehnerNote Added: 0008790
2008-09-01 11:33psarobeStatusnew => scheduled
2008-09-01 11:33psarobeAssigned Tocromero => alostale
2008-09-01 11:33psarobefix_in_branch => trunk
2008-11-17 11:01pjuvaraSeverityminor => major
2008-11-17 11:01pjuvarafix_in_branchtrunk =>
2008-11-17 18:36shuehnerNote Added: 0010350
2008-12-03 19:03pjuvaraPrioritynormal => high
2008-12-10 09:46alostaleAssigned Toalostale => shuehner
2008-12-12 18:25shuehnerNote Added: 0011272
2008-12-12 18:25shuehnerAssigned Toshuehner => pjuvara
2008-12-12 18:25shuehnerStatusscheduled => feedback
2008-12-12 20:03pjuvaraNote Added: 0011278
2008-12-12 20:03pjuvaraAssigned Topjuvara => shuehner
2008-12-12 20:03pjuvaraStatusfeedback => new
2008-12-12 20:05pjuvaraNote Added: 0011279
2008-12-12 20:05pjuvaraPriorityhigh => low
2008-12-12 20:05pjuvaraSeveritymajor => minor
2008-12-18 11:16rafarodaStatusnew => acknowledged
2009-01-19 13:37psarobeStatusacknowledged => scheduled
2009-01-19 13:37psarobeversion => trunk
2009-01-29 16:56shuehnerNote Added: 0012835
2009-01-29 16:56shuehnerTypedefect => feature request
2009-01-29 16:56shuehnerRelationship addedblocks 0007236
2009-01-29 16:56shuehnerStatusscheduled => acknowledged
2009-01-29 23:01pjuvaraTag Attached: Clean-up
2009-01-29 23:01pjuvaraTag Attached: ReleaseCandidate
2011-05-05 22:51shuehnerNote Added: 0036465
2011-05-18 12:15shuehnerRelationship addedblocks 0017233
2011-05-18 12:16shuehnerRelationship deletedblocks 0007236
2018-04-15 15:09shuehnerRelationship addeddepends on 0037874
2018-04-15 15:09shuehnerRelationship deletedblocks 0017233
2019-02-05 08:27alostaleAssigned Toshuehner => alostale
2019-02-05 08:27alostaleStatusacknowledged => scheduled
2019-02-05 08:28alostaleNote Added: 0109561
2019-02-05 08:28alostaleStatusscheduled => closed
2019-02-05 08:28alostaleResolutionopen => fixed
2019-02-05 08:28alostaleFixed in Version => 3.0PR19Q2

Notes
(0008790)
shuehner   
2008-08-30 21:25   
Its only a single user really: ConfigParameters. Its needlessly imported in HttBaseServlet. This unused import is already removed in 2.50
(0010350)
shuehner   
2008-11-17 18:36   
The only piece of code using this library is the fop rendering, which is used to render xmlengine-reports to pdf (not jasper). The fop was not yet updated in the library cleanup and stays at an very old version.
Still have to check if the old fop version can be used without this special logger or decide of to updated/deprecate the fop code.
(0011272)
shuehner   
2008-12-12 18:25   
After some analysis:
- Only used in one place: the fop-renderer (used to generate pdf-files from XmlEngine report, for reports which do not use jasper reports)
- The fop code was not updated in the last library update and remains at an old version 0.20.5
- This old fop-version does not support log4j (directly)
- Is can use avalon-logger, directly log to a file or standard-output (which is captured into another logfile by tomcat).

Possible ways to solve this issue for 2.50:
- Keep the avalon dependency for 2.50 (do nothing now), and update fop-library for the next release which drops the avalon dependency
- Modify/Maintain/Ship a modifed copy of the old fop-library to directly support log4j
- Change fop-configuration to standard-out or another (extra) logfile. Problem seperates the log-output from fop from the rest of the openbravo log-output
- update the fop-library now. Problem: Have to update XmlEngine code to work with the new fop-version and re-test all reports based on this.

@pjuvara: Please comment and decide on an option
(0011278)
pjuvara   
2008-12-12 20:03   
I would like to:
Keep the avalon dependency for 2.50 (do nothing now), and update fop-library for the next release which drops the avalon dependency.

Please do not address this defect until we have a 2.50 maintenance branch. When you address it, please do it in the trunk only.
(0011279)
pjuvara   
2008-12-12 20:05   
Downgrading severity to minor since this does not have any significant end user impact.
(0012835)
shuehner   
2009-01-29 16:56   
Moving to feature request as the is no current functional defect. Relating to the cleanup planned at start of next development cycle.
(0036465)
shuehner   
2011-05-05 22:51   
Note that the currently used fop version still depends on this jar. As the fop version was decided to not be changed for 3.0 this file will probably remains it is for the 3.0 cycle until fop - support will be eventually phased out (guess, not decided yet).
(0109561)
alostale   
2019-02-05 08:28   
Removed in the scope of remove FOP support project (0037874).