Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047539POS2POSpublic2021-08-12 13:472021-10-26 00:20
Reportercberner 
Assigned ToGremiger 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047539: Extra and additional price selector shows duplicated products
DescriptionAdditional Cost Product in Restaurant "Menu -> Category -> Product" has duplicates, this is because the underlying selector reference contains an entry for each product and price list, however the result is a m_product_id, so the fact that there are multiple entries is not very helpful here and a bit confusing.

For more context, check the 2 screenshots(one is from a new product-modifier project, and the other is from the additional price in Restaurant Menu window)
Steps To Reproduce1. Open backoffice(environment with restaurant) and login with White Valley role
2. Open Restaurant Menu window -> Select a category and open a product in Product subtab
3. Check Has Additional Price and open the Additional Cost Product selector, there are several duplicated entries
3.a. Simply browse for example dry, and there'll be several, as in the screenshot
Proposed SolutionTwo options:
1. Show only once each product.
2. Show product duplicated as of now, but include the information of the price-list in the selector dropdown entries.
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng additional_price2.png (19,816) 2021-08-12 13:47
https://issues.openbravo.com/file_download.php?file_id=16105&type=bug
png

png selector_additionalprice.png (23,674) 2021-08-12 13:47
https://issues.openbravo.com/file_download.php?file_id=16106&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2021-08-12 13:47cbernerNew Issue
2021-08-12 13:47cbernerAssigned To => Retail
2021-08-12 13:47cbernerFile Added: additional_price2.png
2021-08-12 13:47cbernerTriggers an Emergency Pack => No
2021-08-12 13:47cbernerFile Added: selector_additionalprice.png
2021-08-23 09:53dmiguelezResolution time => 1633039200
2021-08-23 09:53dmiguelezAssigned ToRetail => ealvarez
2021-08-23 09:53dmiguelezStatusnew => acknowledged
2021-09-03 04:45elaraAssigned Toealvarez => elara
2021-09-03 15:25dmiguelezAssigned Toelara => ealvarez
2021-09-20 08:44guilleaerAssigned Toealvarez => guilleaer
2021-09-20 08:44guilleaerStatusacknowledged => scheduled
2021-09-20 08:47guilleaerAssigned Toguilleaer => Gremiger
2021-09-21 14:46hgbotNote Added: 0131955
2021-09-21 14:47hgbotNote Added: 0131956
2021-09-23 14:36jorge-garciaReview Assigned To => jorge-garcia
2021-10-26 00:20hgbotResolutionopen => fixed
2021-10-26 00:20hgbotStatusscheduled => closed
2021-10-26 00:20hgbotNote Added: 0132625
2021-10-26 00:20hgbotNote Added: 0132626
2021-10-26 00:20hgbotNote Added: 0132627
2021-10-26 00:20hgbotNote Added: 0132628

Notes
(0131955)
hgbot   
2021-09-21 14:46   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/77 [^]
(0131956)
hgbot   
2021-09-21 14:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/684 [^]
(0132625)
hgbot   
2021-10-26 00:20   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: 453ed345d31add9b435152486e2fa57eb5a60dce
Author: Santiago Gremiger <santiago.gremiger@smfconsulting.es>
Date: 2021-10-25T22:20:01+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/453ed345d31add9b435152486e2fa57eb5a60dce [^]

Fixed ISSUE-47539: Changed restaurant menu product table reference, now is selector reference.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_TABLE.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
---
(0132626)
hgbot   
2021-10-26 00:20   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/77 [^]
(0132627)
hgbot   
2021-10-26 00:20   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 604da9e98a633d3b320b083caef33cb033e390fe
Author: Santiago Gremiger <santiago.gremiger@smfconsulting.es>
Date: 2021-10-25T22:20:03+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/604da9e98a633d3b320b083caef33cb033e390fe [^]

Fixed ISSUE-47539: Created new selector with "characteristic" field to difference between products.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
---
(0132628)
hgbot   
2021-10-26 00:20   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/684 [^]