Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047519Retail ModulesWeb POSpublic2021-08-09 12:492021-11-29 19:13
Reportercberner 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2020-02-28
Regression introduced in releaseRR20Q3
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/87c3e6d251f0c8db080607ba3c4739a551bde0b9 [^]
Triggers an Emergency PackNo
Summary0047519: Incremental Masterdata refresh only loads the first batch of each model, ignoring those in the 2nd+ batch
DescriptionIf an incremental masterdata refresh is done and there is a model, for example Product with new entries higher than masterdata refresh batch size(this is by default 10000, but it can be modified with OBMOBC_MasterdataBatchSize preference) it will only load the first batch of products, ignoring all the rest.

Same applies to all masterdata models.
Steps To ReproducePreviously log at least once into WebPOS so it completely refreshes masterdata.

1. Login in Backoffice as White Valley Group admin
2. Go to preferences and create a new one:
  - Property: Masterdata models batch size
  - Value: 2
  - Make sure visibility at User is none (seems Openbravo by default)
3. Go to Color window and create at least 3 new colors on the default color palette, or on a new one.
4. Login in WebPOS and click on top-right gear, Refresh Masterdata
5. Using dev-tools, go to Application -> IndexedDB -> Color, check that not all elements have been loaded. Checking console you should be able to see this:

[incrementalMasterdataRefresh] Starting incremental RefreshMasterdata in IndexedDB; line: MasterdataController.incrementalMasterdataRefresh (http://localhost:3000/static/js/6.chunk.js:10004:10 [^]) (*)
POS2.js:3243 [RefreshMasterdata] The model Color has finished loading a total of 2 records in 16 ms. Loaded in page 1; line: MasterdataController.refreshMasterdata (http://localhost:3000/static/js/6.chunk.js:9853:18 [^]) (*)
POS2.js:3243 Loading page 2 of Color model...; line: MasterdataController.refreshMasterdata (http://localhost:3000/static/js/6.chunk.js:9812:18 [^]) (*)
[incrementalMasterdataRefresh] Finished incremental RefreshMasterdata in IndexedDB; line: MasterdataController.incrementalMasterdataRefresh (http://localhost:3000/static/js/6.chunk.js:10008:10 [^]) (*)

You can see here, that there was a try to load a second page, but it didn't work, no new entries from the second page have been added.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0047574RR21Q3.1 closed ranjith_qualiantech_com Incremental Masterdata refresh only loads the first batch of each model, ignoring those in the 2nd+ batch 
depends on backport 0047575RR21Q2.2 closed ranjith_qualiantech_com Incremental Masterdata refresh only loads the first batch of each model, ignoring those in the 2nd+ batch 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-08-09 12:49cbernerNew Issue
2021-08-09 12:49cbernerAssigned To => Retail
2021-08-09 12:49cbernerTriggers an Emergency Pack => No
2021-08-09 13:03dmiguelezResolution time => 1629669600
2021-08-09 13:03dmiguelezStatusnew => acknowledged
2021-08-11 14:06ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-08-12 10:13ranjith_qualiantech_comRegression level => Production - Confirmed Stable
2021-08-12 10:13ranjith_qualiantech_comRegression date => 2020-02-28
2021-08-12 10:13ranjith_qualiantech_comRegression introduced in release => main
2021-08-12 10:13ranjith_qualiantech_comRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/87c3e6d251f0c8db080607ba3c4739a551bde0b9 [^]
2021-08-12 12:55hgbotNote Added: 0131099
2021-08-19 07:19hgbotNote Added: 0131196
2021-08-19 07:48ranjith_qualiantech_comNote Deleted: 0131196
2021-08-19 11:21ranjith_qualiantech_comStatusacknowledged => scheduled
2021-08-20 12:48hgbotResolutionopen => fixed
2021-08-20 12:48hgbotStatusscheduled => closed
2021-08-20 12:48hgbotNote Added: 0131231
2021-08-20 12:48hgbotFixed in Version => RR21Q4
2021-08-20 12:48hgbotNote Added: 0131232
2021-08-20 12:49marvintmStatusclosed => new
2021-08-20 12:49marvintmResolutionfixed => open
2021-08-20 12:49marvintmFixed in VersionRR21Q4 =>
2021-08-20 12:49marvintmProjectPOS2 => Retail Modules
2021-08-20 12:49marvintmCategoryPOS => Web POS
2021-08-20 12:49marvintmStatusnew => scheduled
2021-08-20 12:50marvintmStatusscheduled => resolved
2021-08-20 12:50marvintmFixed in Version => RR21Q4
2021-08-20 12:50marvintmResolutionopen => fixed
2021-08-20 12:50marvintmReview Assigned To => marvintm
2021-08-20 12:50marvintmStatusresolved => closed
2021-11-29 19:13dmitry_mezentsevRegression introduced in releasemain => RR20Q3

Notes
(0131099)
hgbot   
2021-08-12 12:55   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/270 [^]
(0131231)
hgbot   
2021-08-20 12:48   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/270 [^]
(0131232)
hgbot   
2021-08-20 12:48   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: bf5a8b7c87b8fc9c1e02abee5fb0db6beaa42af0
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-08-20T13:05:48+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/bf5a8b7c87b8fc9c1e02abee5fb0db6beaa42af0 [^]

Fixed ISSUE-47519: Lastupdated should be updated for each model during incremental refresh
* When incremental refresh, Lastupdated should not updated for each request of a model instead it should be updated for each model

---
M web/org.openbravo.mobile.core/app/model/masterdata/MasterdataController.js
M web/org.openbravo.mobile.core/source/data/ob-datasource.js
---