Openbravo Issue Tracking System - Openbravo ERP
These allocations come from String concatenation to generate an error message in case the requested property does not exist.
Note even the method is not expensive itself, it is invoked many times resulting in the top object allocator.
2. Ie. in POS create 4 time a ticket with 4 product and pay it
3. Check Flight Recorder results.
-> It warns about byte[] allocation in Allocated Classes section
-> In Memory details (see attached no-fix.png) check a total of ~250MB byte[] where allocated, checking the stack traces, it can be seen the main contributor for this allocation is Entity.getProperty.
[1] https://www.oracle.com/java/technologies/jdk-mission-control.html [^]
1. Overload Check.isNotNull to support a message Supplier:
Check.isNotNull(prop, () -> "Property " + propertyName + " does not exist for entity " + this));
2. Do the check null directly in Entity.getProperty
Even alternative 1 reduces a lot the byte[] allocation, lambdas are allocated. Being a method that is invoked all the time, 2nd alternative is more optimal (although a bit dirtier from the code point of view).
Attached image (fix2.png) of the 2nd alternative executing the same steps as described above.
no-fix.png (110,330) 2021-08-06 08:54https://issues.openbravo.com/file_download.php?file_id=16075&type=bug
fix2.png (84,359) 2021-08-06 08:58https://issues.openbravo.com/file_download.php?file_id=16076&type=bug