Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047503Retail ModulesWeb POSpublic2021-08-04 14:532021-10-18 07:28
Reporterlmonreal 
Assigned Torqueralta 
PriorityimmediateSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q4 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047503: Rounding for a second currency generating a wrong behaviour in WEBPOS
DescriptionWhen there are two currencies that have rounding, the second one is generating wrong values in WEBPOS.

https://drive.google.com/file/d/1QpOrNNwJlK6sryAqIJfRviFQo4XKKgtg/view [^]

Please make sure the backport to 19Q3 works as we need it for this version.
Also please check that the fix applies to all currencies as we need for LBP and KWD.
Steps To ReproducePre requ:

1.Configure Rounding EUR and Rounding USD.

2. Associate the Roundings with Cash EUR and Cash USD. Both: Sales round up to 1

3. Load WEBPOS and do this test: EUR

-Add product that is 18.90 euros and pay--> With rounding price is 19 with a rounding - 0.10 and says exact amount pay-->OK

4. And now this test: USD

-Add product that is 18.90 euros and select Cash USD to pay. Conversion is 24.84 dollars, pay.

Expected behaviour is rounding to 25 usd and a rounding of - 0.16. Ticket paid.

Actual behaviour: 0.11 remaining to pay (???) with a payment of 24.84 and rounding 0.10(???) -->KO



Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch 0001-Fixed-BUG-47503-Take-into-account-mulrate-value-to-c.patch (1,240) 2021-08-18 15:37
https://issues.openbravo.com/file_download.php?file_id=16134&type=bug
patch New Fix 47503.patch (2,603) 2021-08-27 16:59
https://issues.openbravo.com/file_download.php?file_id=16158&type=bug
patch 47503-NewPatchII.patch (747) 2021-08-30 18:19
https://issues.openbravo.com/file_download.php?file_id=16159&type=bug
patch 47503-NewPatchIII.patch (2,180) 2021-08-31 20:18
https://issues.openbravo.com/file_download.php?file_id=16161&type=bug
patch 47503-Check-if-paymetrounding-added-was-UP-or-Do.patch (950) 2021-09-01 22:00
https://issues.openbravo.com/file_download.php?file_id=16167&type=bug
patch 47503-Check-paymetrounding II.patch (917) 2021-09-02 15:37
https://issues.openbravo.com/file_download.php?file_id=16171&type=bug
patch 47503-Getting the absolute value of originAmount.patch (936) 2021-09-03 19:14
https://issues.openbravo.com/file_download.php?file_id=16176&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-08-04 14:53lmonrealNew Issue
2021-08-04 14:53lmonrealAssigned To => Retail
2021-08-04 14:53lmonrealOBNetwork customer => No
2021-08-04 14:53lmonrealResolution time => 1628546400
2021-08-04 14:53lmonrealTriggers an Emergency Pack => No
2021-08-04 14:55lmonrealDescription Updatedbug_revision_view_page.php?rev_id=22974#r22974
2021-08-04 14:55lmonrealSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=22976#r22976
2021-08-04 17:46adrianromeroStatusnew => acknowledged
2021-08-05 13:12adrianromeroStatusacknowledged => scheduled
2021-08-05 13:12adrianromeroAssigned ToRetail => rqueralta
2021-08-06 11:17lmonrealOBNetwork customerNo => Gold
2021-08-08 16:53hgbotMerge Request Status => open
2021-08-08 16:53hgbotNote Added: 0131033
2021-08-16 06:49hgbotMerge Request Statusopen => approved
2021-08-16 06:49hgbotResolutionopen => fixed
2021-08-16 06:49hgbotStatusscheduled => closed
2021-08-16 06:49hgbotNote Added: 0131123
2021-08-16 06:49hgbotFixed in Version => RR21Q4
2021-08-16 06:49hgbotNote Added: 0131124
2021-08-17 17:42rqueraltaFile Added: 0001-Fixed-BUG-47503-Take-into-account-mulrate-value-to-c.patch
2021-08-18 15:33rqueraltaFile Deleted: 0001-Fixed-BUG-47503-Take-into-account-mulrate-value-to-c.patch
2021-08-18 15:37rqueraltaFile Added: 0001-Fixed-BUG-47503-Take-into-account-mulrate-value-to-c.patch
2021-08-27 16:59rqueraltaFile Added: New Fix 47503.patch
2021-08-30 18:19rqueraltaFile Added: 47503-NewPatchII.patch
2021-08-31 20:18rqueraltaFile Added: 47503-NewPatchIII.patch
2021-09-01 22:00rqueraltaFile Added: 47503-Check-if-paymetrounding-added-was-UP-or-Do.patch
2021-09-02 15:37rqueraltaFile Added: 47503-Check-paymetrounding II.patch
2021-09-03 19:14rqueraltaFile Added: 47503-Getting the absolute value of originAmount.patch
2021-10-03 13:16hgbotNote Added: 0132104
2021-10-18 07:28hgbotNote Added: 0132370
2021-10-18 07:35marvintmNote Deleted: 0132370
2021-10-18 07:35marvintmNote Deleted: 0132104

Notes
(0131033)
hgbot   
2021-08-08 16:53   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/538 [^]
(0131123)
hgbot   
2021-08-16 06:49   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/538 [^]
(0131124)
hgbot   
2021-08-16 06:49   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a56a12800440ea9851283e26b5f9d5dc5dd01334
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-08-16T04:49:23+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a56a12800440ea9851283e26b5f9d5dc5dd01334 [^]

Fixed BUG-47503: Take into account mulrate value to calculate the pendingAma

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/AddPaymentUtils.js
---