Openbravo Issue Tracking System - POS2 |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0047474 | POS2 | POS | public | 2021-07-29 19:11 | 2021-08-13 07:03 |
|
| Reporter | cberner | |
| Assigned To | Retail | |
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0047474: Completing a quotation is not persisted in backoffice and not available in Orders window |
| Description | When a quotation is completed, it should be persisted in backoffice, so when you close it, it is available in Orders window and in the backoffice to open again. This is probably a regression.
An error appears in backoffice in Errors while importing POS Data, as part of this:
"org.openbravo.base.exception.OBException: Error in OrderLoader: null
at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:486)" |
| Steps To Reproduce | 1. Open and login in WebPOS
2. Click on ... button and "New Quotation"
3. Add a product to the ticket
4. Click on "Complete" and then on "Close Quotation"
Check Orders window, and see that the created quotation is not there.
Check backoffice and go to "Errors while importing POS Data", an error will be there, related to this quotation. |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | caused by | defect | 0047350 | | closed | mtaal | Quotation ticket label is shown as "Draft" instead of "Completed" or "Under Evaluation" and it is inconsitent |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2021-07-29 19:11 | cberner | New Issue | |
| 2021-07-29 19:11 | cberner | Assigned To | => Retail |
| 2021-07-29 19:11 | cberner | Triggers an Emergency Pack | => No |
| 2021-07-30 09:04 | dmiguelez | Resolution time | => 1628805600 |
| 2021-07-30 09:04 | dmiguelez | Status | new => acknowledged |
| 2021-07-30 12:00 | jorge-garcia | Relationship added | caused by 0047350 |
| 2021-07-30 12:05 | jorge-garcia | Note Added: 0130894 | |
| 2021-07-30 12:09 | jorge-garcia | Note Edited: 0130894 | bug_revision_view_page.php?bugnote_id=0130894#r22951 |
| 2021-07-30 12:13 | jorge-garcia | Note Edited: 0130894 | bug_revision_view_page.php?bugnote_id=0130894#r22952 |
| 2021-08-06 11:33 | dmiguelez | Resolution time | 1628805600 => 1629410400 |
| 2021-08-12 03:36 | hgbot | Note Added: 0131079 | |
| 2021-08-12 13:42 | hgbot | Resolution | open => fixed |
| 2021-08-12 13:42 | hgbot | Status | acknowledged => closed |
| 2021-08-12 13:42 | hgbot | Note Added: 0131103 | |
| 2021-08-12 13:42 | hgbot | Note Added: 0131104 | |
| 2021-08-13 07:03 | hgbot | Note Added: 0131105 | |
|
Notes |
|
|
(0130894)
|
|
jorge-garcia
|
2021-07-30 12:05
(edited on: 2021-07-30 12:13) |
|
This issue is a regression introduced by the solution of issue 47350.
The problem is located in TicketExtesion.js file from org.openbravo.pos2 module at line 51:
OB.App.StateAPI.Global.completeQuotation.addPreHook(setIsPaid);
Once a quotation is complete, we CANNOT set the quotation as "isPaid: true". If so, the OrderLoader thinks this document exists already in the database and tries to modify it (causing finally the error reported).
The OrderLoader error is raised at line 371-372:
order = OBDal.getInstance().get(Order.class, jsonorder.getString("id"));
order.setDelivered(deliver);
In the old POS, the decision to indicate in the UI if a quotation was in status draft or under evaluation was made checking the attribute "hasbeenpaid" instead of the "isPaid" arrtibute.
|
|
|
|
(0131079)
|
|
hgbot
|
|
2021-08-12 03:36
|
|
|
|
|
(0131103)
|
|
hgbot
|
|
2021-08-12 13:42
|
|
|
|
|
(0131104)
|
|
hgbot
|
|
2021-08-12 13:42
|
|
|
|
|
(0131105)
|
|
hgbot
|
|
2021-08-13 07:03
|
|
|