Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047453Retail ModulesWeb POSpublic2021-07-23 17:262021-07-30 08:38
Reportersebastien_liron 
Assigned TojavierRodriguez 
PriorityurgentSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionpiFixed in VersionRR21Q4 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047453: issue with chrome 92 in addPromotion manual
DescriptionWith chrome 92 this piece of code won't work :

   linesToApply = lines.at ? [...lines.models] : [...lines],

in web/org.openbravo.retail.posterminal/discount.js l.371 ( ~ )
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/js/model/discounts.js#L371 [^]
Steps To Reproduceuse manual promotion on live build with chrome 92
Proposed Solution   linesToApply = (lines instanceof Backbone.Collection) ? [...lines.models] : [...lines],
Additional Information
TagsNOR
Relationships
related to defect 0045655 closed ranjith_qualiantech_com WebPOS fails with Chrome v89, because of new .at() function in Strings 
caused by feature request 0043769 closed jorge-garcia Discretionary Promotions in New Discount Engine for WebPOS state 
related to defect 0047463 closed ranjith_qualiantech_com Multiupc scan problem 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-07-23 17:26sebastien_lironNew Issue
2021-07-23 17:26sebastien_lironAssigned To => Retail
2021-07-23 17:26sebastien_lironOBNetwork customer => OBPS
2021-07-23 17:26sebastien_lironResolution time => 1628114400
2021-07-23 17:26sebastien_lironTriggers an Emergency Pack => No
2021-07-26 15:59rafarodaTag Attached: NOR
2021-07-26 17:06adrianromeroRelationship addeddepends on 0045655
2021-07-26 17:06adrianromeroRelationship deleteddepends on 0045655
2021-07-26 17:06adrianromeroRelationship addedrelated to 0045655
2021-07-26 17:14rafarodaIssue Monitored: rafaroda
2021-07-26 17:48adrianromeroDescription Updatedbug_revision_view_page.php?rev_id=22935#r22935
2021-07-26 17:58adrianromeroRelationship addedcaused by 0043769
2021-07-26 22:36rqueraltaAssigned ToRetail => rqueralta
2021-07-26 22:36rqueraltaStatusnew => scheduled
2021-07-27 08:45adrianromeroAssigned Torqueralta => javierRodriguez
2021-07-27 14:06dmitry_mezentsevIssue Monitored: dmitry_mezentsev
2021-07-28 08:53hgbotMerge Request Status => open
2021-07-28 08:53hgbotNote Added: 0130824
2021-07-28 10:36adrianromeroRelationship addedrelated to 0047463
2021-07-30 08:38hgbotMerge Request Statusopen => approved
2021-07-30 08:38hgbotNote Added: 0130884
2021-07-30 08:38hgbotResolutionopen => fixed
2021-07-30 08:38hgbotStatusscheduled => closed
2021-07-30 08:38hgbotFixed in Version => RR21Q4
2021-07-30 08:38hgbotNote Added: 0130885

Notes
(0130824)
hgbot   
2021-07-28 08:53   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/528 [^]
(0130884)
hgbot   
2021-07-30 08:38   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/528 [^]
(0130885)
hgbot   
2021-07-30 08:38   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: f2593ec9d7f0311105a376692c9ac77b9fa493e7
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-07-28T08:43:17+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/f2593ec9d7f0311105a376692c9ac77b9fa493e7 [^]

Fixed ISSUE-47453: Replace at condition to check if lines is a Backbone collection

---
M web/org.openbravo.retail.posterminal/js/model/discounts.js
---