Openbravo Issue Tracking System - Retail Modules
View Issue Details
0047435Retail ModulesWeb POSpublic2021-07-22 09:172021-07-26 09:27
migueldejuana 
migueldejuana 
normalmajoralways
closedfixed 
5
 
RR21Q4 
adrianromero
No
0047435: Avoid asking to Login again if we are in a middle of a process
If we do a request and the response es 401 because the session is not valid, we show Login Again popup and we can logout. If we are in the middle of a process and we do logout, we can have bugs.

Example:
We are processing an order and before pressing Done, the server is restarted. In preOrderSave hook a module does a request to backend and we get 401 response, so the Login Again popup is shown and we can press Login Again. We will do logout and the complete ticket has not finished yet. It should not be errors but we should avoid doing this because is risky and could cause bugs if we take into account the differente implementation in clients.
n/a
Launch login again popup just if there are no processes in execution
NOR
Issue History
2021-07-22 09:17migueldejuanaNew Issue
2021-07-22 09:17migueldejuanaAssigned To => migueldejuana
2021-07-22 09:17migueldejuanaTriggers an Emergency Pack => No
2021-07-22 09:17migueldejuanaStatusnew => scheduled
2021-07-22 09:18migueldejuanaReview Assigned To => adrianromero
2021-07-22 09:23hgbotNote Added: 0130685
2021-07-22 23:18rafarodaTag Attached: NOR
2021-07-26 09:27hgbotResolutionopen => fixed
2021-07-26 09:27hgbotStatusscheduled => closed
2021-07-26 09:27hgbotFixed in Version => RR21Q4
2021-07-26 09:27hgbotNote Added: 0130745
2021-07-26 09:27hgbotNote Added: 0130746

Notes
(0130685)
hgbot   
2021-07-22 09:23   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/263 [^]
(0130745)
hgbot   
2021-07-26 09:27   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 3714c37876029f853c481ac5749e5e8e580b79e8
Author: Miguel de Juana <miguel.dejuana@openbravo.com>
Date: 2021-07-22T15:17:27+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/3714c37876029f853c481ac5749e5e8e580b79e8 [^]

Fixed ISSUE-47435: Avoid asking to Login again if we are in a middle of a process

- We remove if else when response is 401, we will have an if for 401
case and else will be execute always (unless we do return)

- Login Again popup won't be launch if there are processes in execution
to avoid breaking flows and causing bugs

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
---
(0130746)
hgbot   
2021-07-26 09:27   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/263 [^]