Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047413POS2Corepublic2021-07-19 13:252022-10-24 11:26
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047413: Printing templates as masterdata
DescriptionPrinting templates should be definable as masterdata.

Project: https://docs.google.com/document/d/1T32FI9272nBDS5dfcS86bpz5mrzNEFa3QPCo9aeR-88/edit#heading=h.qkc7prkk4nv6 [^]
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0047735 closed alostale Retail Modules API changes for masterdata print templates (47413) 
related to defect 0047955 closed alostale POS2 ORA: can't save print template without module 
related to feature request 0050615 new Triage Platform Base POS2 Support defining printing templates as masterdata in all mobile applications 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-07-19 13:25alostaleNew Issue
2021-07-19 13:25alostaleAssigned To => Retail
2021-07-19 13:25alostaleTriggers an Emergency Pack => No
2021-07-28 07:44hgbotNote Added: 0130818
2021-07-28 07:49hgbotNote Added: 0130819
2021-07-28 07:59hgbotNote Added: 0130820
2021-09-13 13:30hgbotNote Added: 0131738
2021-09-22 07:41alostaleRelationship addeddepends on 0047735
2021-10-11 12:47guilleaerStatusnew => scheduled
2021-10-11 12:47guilleaerAssigned ToRetail => alostale
2021-10-28 07:50hgbotNote Added: 0132695
2021-10-29 09:59hgbotNote Added: 0132736
2021-10-29 09:59hgbotNote Added: 0132737
2021-10-29 10:02hgbotResolutionopen => fixed
2021-10-29 10:02hgbotStatusscheduled => closed
2021-10-29 10:02hgbotFixed in Version => RR22Q1
2021-10-29 10:02hgbotNote Added: 0132739
2021-10-29 10:02hgbotNote Added: 0132740
2021-10-29 10:03hgbotNote Added: 0132741
2021-10-29 10:04hgbotNote Added: 0132744
2021-10-29 10:05hgbotNote Added: 0132745
2021-10-29 10:05hgbotNote Added: 0132746
2021-10-29 10:05hgbotNote Added: 0132747
2021-10-29 10:06hgbotNote Added: 0132748
2021-10-29 10:06hgbotNote Added: 0132749
2021-11-02 08:12alostaleRelationship addedrelated to 0047955
2021-11-02 10:18hgbotNote Added: 0132779
2022-10-24 11:26caristuIssue cloned0050615
2022-10-24 11:26caristuRelationship addedrelated to 0050615

Notes
(0130818)
hgbot   
2021-07-28 07:44   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/643 [^]
(0130819)
hgbot   
2021-07-28 07:49   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/527 [^]
(0130820)
hgbot   
2021-07-28 07:59   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/266 [^]
(0131738)
hgbot   
2021-09-13 13:30   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources/-/merge_requests/42 [^]
(0132695)
hgbot   
2021-10-28 07:50   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager/-/merge_requests/39 [^]
(0132736)
hgbot   
2021-10-29 09:59   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/266 [^]
(0132737)
hgbot   
2021-10-29 09:59   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 7d1685482a7772bae7328bcac30f1dfddcfd6e7c
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-10-29T09:58:30+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/7d1685482a7772bae7328bcac30f1dfddcfd6e7c [^]

FR-47413: printing templates as masterdata

Basic infrastructure changes to support this feature.

---
M src/org/openbravo/mobile/core/master/MasterDataProcessHQLQuery.java
M src/org/openbravo/mobile/core/model/HQLProperty.java
M src/org/openbravo/mobile/core/process/ProcessHQLQuery.java
---
(0132740)
hgbot   
2021-10-29 10:02   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/527 [^]
(0132739)
hgbot   
2021-10-29 10:02   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: c8db586ffb70c68d3e7155f60b3bde6a94611115
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-10-29T10:00:55+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c8db586ffb70c68d3e7155f60b3bde6a94611115 [^]

fixed FR-47413: printing templates as masterdata

POS2 priting templates can be optionally defined as masterdata instead
of as code.

---
A src/org/openbravo/retail/posterminal/event/TemplateEventHandler.java
M src-db/database/model/tables/OBPOS_PRINT_TEMPLATE.xml
M src-db/database/model/tables/OBPOS_PRINT_TEMPLATE_SUBREP.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/term/TerminalProperties.java
M web-test/external-device/printing/PrintTemplate.test.js
M web-test/external-device/printing/PrintTemplateGeneration.test.js
M web-test/external-device/printing/TicketPrinter.test.js
M web/org.openbravo.retail.posterminal/app/external-device/printing/PrintTemplate.js
M web/org.openbravo.retail.posterminal/app/external-device/printing/PrintTemplateStore.js
M web/org.openbravo.retail.posterminal/app/external-device/printing/TicketPrinter.js
---
(0132741)
hgbot   
2021-10-29 10:03   
Repository: https://gitlab.com/openbravo/ci/mobile-api [^]
Changeset: 9bc125f3345839915724d3538b66d3405611cfed
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-10-29T07:38:26+02:00
URL: https://gitlab.com/openbravo/ci/mobile-api/-/commit/9bc125f3345839915724d3538b66d3405611cfed [^]

fixed ISSUE-47735: API changes for FR-47413 (masterdata print templates)

---
M model/modules/org.openbravo.retail.posterminal/src-db/database/model/tables/OBPOS_PRINT_TEMPLATE.xml
M model/modules/org.openbravo.retail.posterminal/src-db/database/model/tables/OBPOS_PRINT_TEMPLATE_SUBREP.xml
---
(0132744)
hgbot   
2021-10-29 10:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: a8922e701e3a638d8dbdb83523ef0581058d56e1
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-10-29T10:04:10+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/a8922e701e3a638d8dbdb83523ef0581058d56e1 [^]

fixed FR-47413: printing templates as masterdata

POS2 priting templates can be optionally defined as masterdata instead
of as code.

---
A src-db/database/model/modifiedTables/OBPOS_PRINT_TEMPLATE.xml
A src-db/database/model/modifiedTables/OBPOS_PRINT_TEMPLATE_SUBREP.xml
A src-test/org/openbravo/pos2/PosTestConstants.java
A src-test/org/openbravo/pos2/StandaloneTestSuite.java
A src-test/org/openbravo/pos2/master/print/TemplateValidator.java
A src-test/org/openbravo/pos2/master/print/TerminalTemplateTest.java
A src/org/openbravo/pos2/POS2Initializer.java
A src/org/openbravo/pos2/login/POS1InitialValidations.java
A src/org/openbravo/pos2/master/print/PrintSubreportTemplate.java
A src/org/openbravo/pos2/master/print/PrintTemplate.java
A src/org/openbravo/pos2/master/print/TerminalTemplate.java
A web-jspack/org.openbravo.pos2/src/model/masterdata/print/PrintSubreportTemplateModel.js
A web-jspack/org.openbravo.pos2/src/model/masterdata/print/PrintTemplateModel.js
A web-jspack/org.openbravo.pos2/src/model/masterdata/print/TerminalTemplateModel.js
A web-jspack/org.openbravo.pos2/src/services/printing/__test__/printTemplateInitializer.test.js
A web-jspack/org.openbravo.pos2/src/services/printing/configurePrintTemplate.js
A web-jspack/org.openbravo.pos2/src/services/printing/printTemplateInitializer.js
A web-jspack/org.openbravo.pos2/src/services/printing/printTemplateModelListener.js
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/pos2/login/POS2InitialValidations.java
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0132745)
hgbot   
2021-10-29 10:05   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/643 [^]
(0132746)
hgbot   
2021-10-29 10:05   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager [^]
Changeset: 4927aeaff38b279df78dce87326d573cb81d15b7
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-10-28T07:43:42+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager/-/commit/4927aeaff38b279df78dce87326d573cb81d15b7 [^]

related to FR-47413: printing templates as masterdata

Now templates can be defined as sourcedata or as a url path to a file as
it was before. In the first case, the resource parameter is the name of
the template whereas in the second it is the path.

Consider both cases to determine the compile jasper file name.

---
M bin/poshw.jar
M bin/rev.id
---
(0132747)
hgbot   
2021-10-29 10:05   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager/-/merge_requests/39 [^]
(0132748)
hgbot   
2021-10-29 10:06   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources/-/merge_requests/42 [^]
(0132749)
hgbot   
2021-10-29 10:06   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources [^]
Changeset: 6e0d1a9e1b7593afca39e7d9f4514a9b581cd08f
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-10-28T07:45:45+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources/-/commit/6e0d1a9e1b7593afca39e7d9f4514a9b581cd08f [^]

related to FR-47413: printing templates as masterdata

Now templates can be defined as sourcedata or as a url path to a file as
it was before. In the first case, the resource parameter is the name of
the template whereas in the second it is the path.

Consider both cases to determine the compile jasper file name.

---
M project/src/com/openbravo/pos/printer/printer/DevicePrinterPrinter.java
---
(0132779)
hgbot   
2021-11-02 10:18   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: ae587bf962e23c48aba5677b17a60b6422018608
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-11-02T10:16:03+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/ae587bf962e23c48aba5677b17a60b6422018608 [^]

related to FR-47413: prefer setAdminMode(boolean)

Changed setAdminMode() to the preferred setAdminMode(boolean) form. In
this case, as admin mode is set to query AD objects which are always in
system, performing client/org check is fine.

---
M src/org/openbravo/retail/posterminal/event/TemplateEventHandler.java
---