Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047350POS2POSpublic2021-07-07 10:562021-07-13 08:22
Reporterlorenzofidalgo 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression levelAutomated tests
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047350: Quotation ticket label is shown as "Draft" instead of "Completed" or "Under Evaluation" and it is inconsitent
DescriptionAfter clicking Complete button in a Draft Quotation, the label is not shown properly, since Draft label is still there. Apart from that, the ticket label is not consistent, since Draft is shown in a different place than the next status (Under Evaluation or Complete) and the testIds do not match.
(Image attached)
Steps To Reproduce0-Login POS2 as vallblanca.
1-Click the 3 dots button and click New Quotation.
2-Add 1x "Avalanche Transceiver" (Check ticket label is properly placed "Quotation Draft"). And also check its testid using chrome developer tools.
3-Click "Complete" button. DEFECT: Check "Quotation Draft" is still present, the label is missplaced and the testID of that element is not consistent with the previous one.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
causes defect 0047474 closed Retail Completing a quotation is not persisted in backoffice and not available in Orders window 
Attached Filespng CompletedOrderButDrafIsShown.png (170,496) 2021-07-07 10:56
https://issues.openbravo.com/file_download.php?file_id=15994&type=bug
png

png BeforeComplete.png (156,955) 2021-07-07 11:13
https://issues.openbravo.com/file_download.php?file_id=15995&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2021-07-07 10:56lorenzofidalgoNew Issue
2021-07-07 10:56lorenzofidalgoAssigned To => Retail
2021-07-07 10:56lorenzofidalgoFile Added: CompletedOrderButDrafIsShown.png
2021-07-07 10:56lorenzofidalgoRegression level => Automated tests
2021-07-07 10:56lorenzofidalgoTriggers an Emergency Pack => No
2021-07-07 11:13lorenzofidalgoFile Added: BeforeComplete.png
2021-07-13 02:05hgbotNote Added: 0130391
2021-07-13 08:20guilleaerAssigned ToRetail => mtaal
2021-07-13 08:20guilleaerStatusnew => scheduled
2021-07-13 08:22hgbotResolutionopen => fixed
2021-07-13 08:22hgbotStatusscheduled => closed
2021-07-13 08:22hgbotNote Added: 0130395
2021-07-13 08:22hgbotNote Added: 0130396
2021-07-30 12:00jorge-garciaRelationship addedcauses 0047474

Notes
(0130391)
hgbot   
2021-07-13 02:05   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/604 [^]
(0130395)
hgbot   
2021-07-13 08:22   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 56a749fd5dfaff6ecb36688263988c6bbd66008d
Author: Martin Taal <martin.taal@openbravo.com>
Date: 2021-07-13T06:22:17+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/56a749fd5dfaff6ecb36688263988c6bbd66008d [^]

fixes ISSUE-47350: Quotation ticket label is shown as "Draft" instead of "Completed" or "Under Evaluation" and it is inconsitent

---
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/ButtonBar1-DraftDisabledAll.config.json
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/ButtonBar1-DraftLayaway.config.json
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/ButtonBar1-DraftQuotation.config.json
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/ButtonBar1-DraftReturn.config.json
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/ButtonBar1-DraftTicket.config.json
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/__test__/ButtonBar1.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderBPWithDocType/TicketHeaderBPWithDocType.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderBPWithDocType/__test__/TicketHeaderBPWithDocType.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketTypeStatusHandling.js
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/CompleteTicketHooks.js
---
(0130396)
hgbot   
2021-07-13 08:22   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/604 [^]