Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047346Retail Modules[POS2] Corepublic2021-07-06 14:432021-07-27 11:22
Reporterknoet 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047346: should not be possible to define a combo familiy with qty=0
DescriptionWhile having a quantity to 0 in the subtab family for a disocunt type Combo / Combo fixed price. I've a JS error when applying the promotion. See the screenshot
Steps To Reproduce1- Log into the backend
2- Go to the window 'Discounts & Promotions'
3- Find a promotion combo / Combo fixed priced
4- Go in the Family subtab
5- Changes the quantity to 0
6- It shouldn't be possible
Proposed SolutionCheck if the quantity > 0
Additional Information
TagsNOR
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-07-06 14:43knoetNew Issue
2021-07-06 14:43knoetAssigned To => Retail
2021-07-06 14:43knoetResolution time => 1626732000
2021-07-06 14:43knoetTriggers an Emergency Pack => No
2021-07-06 14:43knoetTag Attached: NOR
2021-07-13 18:09dmiguelezProjectPOS2 => Retail Modules
2021-07-16 09:30ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-07-16 09:32guilleaerStatusnew => acknowledged
2021-07-17 12:11ranjith_qualiantech_comStatusacknowledged => scheduled
2021-07-19 03:56hgbotNote Added: 0130550
2021-07-19 11:23hgbotResolutionopen => fixed
2021-07-19 11:23hgbotStatusscheduled => closed
2021-07-19 11:23hgbotNote Added: 0130559
2021-07-19 11:23hgbotNote Added: 0130560
2021-07-23 09:13knoetNote Added: 0130713
2021-07-23 10:07ranjith_qualiantech_comNote Added: 0130714
2021-07-23 10:07ranjith_qualiantech_comStatusclosed => new
2021-07-23 10:07ranjith_qualiantech_comResolutionfixed => open
2021-07-26 13:31hgbotNote Added: 0130760
2021-07-27 11:22hgbotResolutionopen => fixed
2021-07-27 11:22hgbotStatusnew => closed
2021-07-27 11:22hgbotNote Added: 0130779
2021-07-27 11:22hgbotNote Added: 0130780

Notes
(0130550)
hgbot   
2021-07-19 03:56   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/13 [^]
(0130559)
hgbot   
2021-07-19 11:23   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 924146838bd12756595241124b8e67248d86b782
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-07-17T15:19:52+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/924146838bd12756595241124b8e67248d86b782 [^]

Fixed ISSUE-47346: Discount should be applied for ComboFamily if quantity greater than zero

---
M web/org.openbravo.retail.discounts.combo/app/model/business-logic/discounts-engine/engine/rules/combo-discount.js
---
(0130560)
hgbot   
2021-07-19 11:23   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/13 [^]
(0130713)
knoet   
2021-07-23 09:13   
Hi @ranjith_qualiantech_com,

We checked your fix about this mantis and it worked fine, but we think the user should not be able to defined a quantity = 0 in the Family subtab , so we discussed with our TL, and we think we should add an EventHandler to avoid people to define 0.
(0130714)
ranjith_qualiantech_com   
2021-07-23 10:07   
Need to add Event Handler to validate the quantity column in family tab
(0130760)
hgbot   
2021-07-26 13:31   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/14 [^]
(0130779)
hgbot   
2021-07-27 11:22   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: a334bdb5aa6eb7a66aff1aba6605db55810a21b2
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-07-26T13:09:27+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/a334bdb5aa6eb7a66aff1aba6605db55810a21b2 [^]

Fixed ISSUE-47346: Added Min value for quantity column in Family tab

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0130780)
hgbot   
2021-07-27 11:22   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/14 [^]