Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047262Retail ModulesWeb POSpublic2021-06-28 14:562021-10-18 11:53
Reportersanti_lozano 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047262: Incremental refresh not updating business partner product price
DescriptionGo to webpos, check a price for a product (ie: Battery Charger) having a concrete customer (ie: Arturo Montoro), change its price list (of the customer) to be other with other price for this product, refresh the page, it is not considered
Steps To Reproduce* Go to livebuilds with modules, role The White Valley Group
* On Preference window, set preferences for those properties and values (also selected = yes, and user vall blanca store user)
"No Auto Incremental Load at Login" = N
"Web POS Enable Multi Price List" = Y
"Web POS Show Standard Price on Search and Browse" = Y
* go to webpos and check price of product Battery Charger, having selected customer Arturo Montoro
* on backoffice window Price List, select CTS - Price List and modify the price for Battery Charger
* on backoffice, change the price list of that customer on Business Partner window and on its Customer tab (change it to be CTS - Price List)
* go to webpos, do a simple refresh, the price is not updated
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0047423 closed ranjith_qualiantech_com Slow incremental refresh of products 
related to defect 0047671 closed prakashmurugesan88 Multipricelist tests are failing in high volume 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-06-28 14:56santi_lozanoNew Issue
2021-06-28 14:56santi_lozanoAssigned To => Retail
2021-06-28 14:56santi_lozanoResolution time => 1626645600
2021-06-28 14:56santi_lozanoTriggers an Emergency Pack => No
2021-07-08 08:30ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-07-14 06:07hgbotNote Added: 0130443
2021-07-14 06:07hgbotNote Added: 0130444
2021-07-14 19:19hgbotResolutionopen => fixed
2021-07-14 19:19hgbotStatusnew => closed
2021-07-14 19:19hgbotFixed in Version => RR21Q4
2021-07-14 19:19hgbotNote Added: 0130484
2021-07-14 19:19hgbotNote Added: 0130485
2021-07-14 19:19hgbotNote Added: 0130486
2021-07-14 19:19hgbotNote Added: 0130487
2021-07-21 07:34ranjith_qualiantech_comNote Added: 0130620
2021-07-21 07:34ranjith_qualiantech_comStatusclosed => new
2021-07-21 07:34ranjith_qualiantech_comResolutionfixed => open
2021-07-21 07:34ranjith_qualiantech_comFixed in VersionRR21Q4 =>
2021-07-21 07:34ranjith_qualiantech_comStatusnew => scheduled
2021-07-21 07:35hgbotNote Added: 0130621
2021-07-21 09:54hgbotResolutionopen => fixed
2021-07-21 09:54hgbotStatusscheduled => closed
2021-07-21 09:54hgbotNote Added: 0130629
2021-07-21 09:54hgbotFixed in Version => RR21Q4
2021-07-21 09:54hgbotNote Added: 0130630
2021-07-27 08:56PracticsNote Added: 0130771
2021-07-27 08:56PracticsIssue Monitored: Practics
2021-07-27 08:57PracticsNote Added: 0130772
2021-08-10 11:53ranjith_qualiantech_comNote Added: 0131049
2021-08-10 11:53ranjith_qualiantech_comStatusclosed => new
2021-08-10 11:53ranjith_qualiantech_comResolutionfixed => open
2021-08-10 11:53ranjith_qualiantech_comFixed in VersionRR21Q4 =>
2021-08-11 09:21adrianromeroStatusnew => acknowledged
2021-08-11 09:21adrianromeroStatusacknowledged => scheduled
2021-08-11 09:22adrianromeroRelationship addedrelated to 0047423
2021-08-16 06:24hgbotNote Added: 0131121
2021-08-16 06:24hgbotNote Added: 0131122
2021-08-16 11:45hgbotNote Added: 0131135
2021-08-16 11:45hgbotNote Added: 0131136
2021-08-16 11:45hgbotResolutionopen => fixed
2021-08-16 11:45hgbotStatusscheduled => closed
2021-08-16 11:45hgbotFixed in Version => RR21Q4
2021-08-16 11:45hgbotNote Added: 0131137
2021-08-16 11:59hgbotNote Added: 0131138
2021-08-16 11:59hgbotNote Added: 0131139
2021-10-15 20:09lbressanNote Added: 0132366
2021-10-15 20:09lbressanStatusclosed => new
2021-10-15 20:09lbressanResolutionfixed => open
2021-10-18 07:36marvintmStatusnew => scheduled
2021-10-18 07:37marvintmNote Added: 0132372
2021-10-18 07:37marvintmStatusscheduled => resolved
2021-10-18 07:37marvintmResolutionopen => fixed
2021-10-18 07:37marvintmReview Assigned To => marvintm
2021-10-18 07:37marvintmStatusresolved => closed
2021-10-18 11:52gonzalo_fernandezIssue Monitored: gonzalo_fernandez
2021-10-18 11:53ranjith_qualiantech_comRelationship addedrelated to 0047671

Notes
(0130443)
hgbot   
2021-07-14 06:07   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/108 [^]
(0130444)
hgbot   
2021-07-14 06:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/516 [^]
(0130484)
hgbot   
2021-07-14 19:19   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: d53170ccde8d3c1e321580476b671ddde94aa5ea
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-07-14T09:35:53+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d53170ccde8d3c1e321580476b671ddde94aa5ea [^]

Fixed ISSUE-47262: Updated MultiPricelist query to load masterdata in incremental refresh
* Updated PriceList, ProductPrice query to load master data in incremntal refresh when bp pricelist is changed

---
M src/org/openbravo/retail/posterminal/master/PriceList.java
M src/org/openbravo/retail/posterminal/master/ProductPrice.java
---
(0130485)
hgbot   
2021-07-14 19:19   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/516 [^]
(0130486)
hgbot   
2021-07-14 19:19   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 3f78bee3fd9e7d278006d7c0950a53312226afd4
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-07-14T09:36:09+05:30
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/3f78bee3fd9e7d278006d7c0950a53312226afd4 [^]

Verifies ISSUE-47262: Added test I47262_VerifyPriceListOnReload

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multipricelists/I47262_VerifyPriceListOnReload.java
---
(0130487)
hgbot   
2021-07-14 19:19   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/108 [^]
(0130620)
ranjith_qualiantech_com   
2021-07-21 07:34   
Duplicate pricelist was returned after modified the query
(0130621)
hgbot   
2021-07-21 07:35   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/520 [^]
(0130629)
hgbot   
2021-07-21 09:54   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/520 [^]
(0130630)
hgbot   
2021-07-21 09:54   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 9d36bc2a1fd2096468cff07546eca3f9c5794604
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-07-21T07:52:26+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/9d36bc2a1fd2096468cff07546eca3f9c5794604 [^]

Fixed ISSUE-47262: Added groupby to PriceList and ProductPrice query
* TO get distinct values, added groupby clause to PriceList and ProductPrice queries

---
M src/org/openbravo/retail/posterminal/master/PriceList.java
M src/org/openbravo/retail/posterminal/master/ProductPrice.java
---
(0130771)
Practics   
2021-07-27 08:56   
Despues de aplicar este parche en entornos con muchos datos la ProductPrice no consigue cargar

Adjunto imagen
(0130772)
Practics   
2021-07-27 08:57   
Proceso de carga de Datos Maestros ha encontrado un error. El siguiente modelo(s) no pudo cargarse: ProductPrice. Por favor comprueba su conexión a Internet y recargue la página. Si el problema persiste, por favor contacte con el administrador del sistema
(0131049)
ranjith_qualiantech_com   
2021-08-10 11:53   
ProductPrice Query takes too much time to execute. Need to improve the performance
(0131121)
hgbot   
2021-08-16 06:24   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/543 [^]
(0131122)
hgbot   
2021-08-16 06:24   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/116 [^]
(0131135)
hgbot   
2021-08-16 11:45   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 7b5dbc0fa07e285f265f49580a1826c852bffa9f
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-08-16T09:44:54+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/7b5dbc0fa07e285f265f49580a1826c852bffa9f [^]

Related to ISSUE-47262: Reverting the changes

This reverts commit 9d36bc2a1fd2096468cff07546eca3f9c5794604.
This reverts commit d53170ccde8d3c1e321580476b671ddde94aa5ea.

---
M src/org/openbravo/retail/posterminal/master/PriceList.java
M src/org/openbravo/retail/posterminal/master/ProductPrice.java
---
(0131136)
hgbot   
2021-08-16 11:45   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/543 [^]
(0131137)
hgbot   
2021-08-16 11:45   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 6cf75dd592aba8967cc00ad0c1adadcc3ee848ef
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-08-16T09:44:54+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/6cf75dd592aba8967cc00ad0c1adadcc3ee848ef [^]

Fixed ISSUE-47262: Added Event Handler when updating pricelist for customer
* Updated ProductPrice query to use pricelist incremental criteria
* Added Client and Org criteria for Customer in PriceList and ProductPrice query

---
A src/org/openbravo/retail/posterminal/event/BusinessPartnerEventHandler.java
M src/org/openbravo/retail/posterminal/master/PriceList.java
M src/org/openbravo/retail/posterminal/master/ProductPrice.java
---
(0131138)
hgbot   
2021-08-16 11:59   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: fdae7a53b84b2a4d2d5a4741cb57cb263bccac3d
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-08-13T12:03:07+05:30
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/fdae7a53b84b2a4d2d5a4741cb57cb263bccac3d [^]

Related to ISSUE-47262: Updated Test I47262_VerifyPriceListOnReload

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multipricelists/I47262_VerifyPriceListOnReload.java
---
(0131139)
hgbot   
2021-08-16 11:59   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/116 [^]
(0132366)
lbressan   
2021-10-15 20:09   
We reopen the issue because the patch they gave us does not solve the problem
(0132372)
marvintm   
2021-10-18 07:37   
We don't see anything with the fix in master, it works correctly as far as we can see. Could you please contact us directly and explain us what you tried, what is not working, and which customer/release are you testing it in?