Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0047259Openbravo ERPE. Translationpublic2021-06-28 13:382021-08-13 09:44
avicente 
caristu 
highmajoralways
closedfixed 
5
 
 
Core
No
0047259: Translation done with the 'Translator Helper' are now shown in the POS doing a 'Refresh data' or even Full Refresh
When a translation in change in backoffice, for instance a message translation, the new translation is shown in the POS doing a 'Refresh data'.

See video https://drive.google.com/file/d/12KYwHtW09QP198TxPNFRRuyhP0HqtB7m/view [^]


However, when it is done using the 'Translator Helper', it is not shown doing 'Refresh data' or even 'Full refresh'. In the customer environment these changes are shown after two or three days.

See video
https://drive.google.com/file/d/1Ys8iinFFNnmoy3xLmcTrSNXGpG-7-1cS/view [^]
See videos https://drive.google.com/file/d/12KYwHtW09QP198TxPNFRRuyhP0HqtB7m/view [^]

https://drive.google.com/file/d/1Ys8iinFFNnmoy3xLmcTrSNXGpG-7-1cS/view [^]
As user, I expect the same behaviour if the translation is done directly in the backoffice or through the 'Translator Helper'.
NOR
causes defect 0047546 closed caristu Install a translation module from the command line fails 
Issue History
2021-06-28 13:38avicenteNew Issue
2021-06-28 13:38avicenteAssigned To => platform
2021-06-28 13:38avicenteModules => Core
2021-06-28 13:38avicenteResolution time => 1626300000
2021-06-28 13:38avicenteTriggers an Emergency Pack => No
2021-06-28 13:39avicenteTag Attached: NOR
2021-06-28 13:48vmromanosAssigned Toplatform => Retail
2021-06-28 13:49vmromanosNote Added: 0129854
2021-07-20 16:09adrianromeroNote Added: 0130611
2021-07-20 16:09adrianromeroAssigned ToRetail => vmromanos
2021-07-21 09:37dmiguelezResolution time1626300000 => 1628632800
2021-08-11 12:04hgbotNote Added: 0131061
2021-08-11 12:04hgbotNote Added: 0131062
2021-08-11 12:07caristuAssigned Tovmromanos => caristu
2021-08-12 10:02hgbotNote Added: 0131090
2021-08-12 10:02hgbotNote Added: 0131091
2021-08-12 10:03hgbotResolutionopen => fixed
2021-08-12 10:03hgbotStatusnew => closed
2021-08-12 10:03hgbotNote Added: 0131092
2021-08-12 10:03hgbotFixed in Version => RR21Q4
2021-08-12 10:03hgbotNote Added: 0131093
2021-08-13 09:44caristuIssue cloned0047546
2021-08-13 09:44caristuRelationship addedcauses 0047546

Notes
(0129854)
vmromanos   
2021-06-28 13:49   
Hi Retail,

The Translator Helper is properly updating the translation. However, it seems the POS doesn't realize about the change even after a full refresh.

You should investigate why the POS doesn't take the last translation available
(0130611)
adrianromero   
2021-07-20 16:09   
The only difference in the behavior of the full refresh functionality is the use of the "Translation Helper" application. I guess the "Translation Helper" does not stores data the same way the ERP does, or does not execute the event handlers or any other code the ERP executes.

So I suggest first to review the difference of the data when inserted using the ERP and the "Translation Helper" and if there is any difference check what is the approach to fix this topic..
(0131061)
hgbot   
2021-08-11 12:04   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/422 [^]
(0131062)
hgbot   
2021-08-11 12:04   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/269 [^]
(0131090)
hgbot   
2021-08-12 10:02   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 0b38658966b3b6f7c03b9baca0945d491e796bcf
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2021-08-11T11:31:36+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/0b38658966b3b6f7c03b9baca0945d491e796bcf [^]

related to ISSUE-47259: support on trl file import hooks

  Provide the ability of executing custom code after a translation file
is imported through the TranslationManager

---
A src/org/openbravo/erpCommon/ad_forms/TranslationManagerHook.java
M src/org/openbravo/erpCommon/ad_forms/TranslationManager.java
---
(0131091)
hgbot   
2021-08-12 10:02   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/422 [^]
(0131092)
hgbot   
2021-08-12 10:03   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/269 [^]
(0131093)
hgbot   
2021-08-12 10:03   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 86858b0a8fbde592283ded71364b125fc96f8cc7
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2021-08-11T12:06:10+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/86858b0a8fbde592283ded71364b125fc96f8cc7 [^]

fixes ISSUE-47259: label refresh after updating with TranslationManager

  If a label translation was updated through the TranslationManager, the
incremental/full refresh was not updating the translation in the WebPOS.
This problem was not happening when the translation was directly
(manually) updated in the ERP.

  The reason is that the label translations are kept in an in-memory
cache that is cleaned up with a business entity event handler when a
change is done in a translation through DAL.

  As the TranslationManager does not use DAL, that event handler is not
invoked when it updates the translations. Thus, the cache was never
cleaned up.

  To fix the problem we are implementing a TranslationManagerHook which
cleans up the cache whenever the TranslationManager executes the import
of an AD_Message_TRL file containing the label translations.

---
A src/org/openbravo/mobile/core/translation/MobileCoreTranslationManagerHook.java
---