Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047238Openbravo ERPA. Platformpublic2021-06-24 09:532021-06-24 16:37
Reporteralostale 
Assigned Toplatform 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionPR21Q2.1Fixed in VersionPR21Q2.1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2020-10-15
Regression introduced in releasePR21Q1
Regression introduced by commithttps://gitlab.com/openbravo/product/openbravo/-/commit/91d54a5c0457fe6ea58c688a01b11473963ac0c6 [^]
Triggers an Emergency PackNo
Summary0047238: "changes pending" displayed after MMC module install + rebuild
DescriptionAfter installing a module from Module Management window (MMC) and rebuilding the system to apply the changes as described in the documentation [1]. When MMC is opened again "Changes pending, rebuild required" still appears for that module.
Steps To ReproduceIn a clean instance:
1. Log in as System Administrator
2. Open MMC
3. Install Hello World module (or any other)
4. See "Changes pending, rebuild required" appears in main tab for this module
  -> OK
5. Stop tomcat, run ant update.database compile.complete.deploy, restart tomcat
6. Open MMC
7. See "Changes pending, rebuild required" appears in main tab for the installed module
  -> ERROR: changes should have been applied and message shouldn't appear
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0047236 closed platform "changes pending" displayed after MMC module install + rebuild 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-06-24 09:55alostaleTypedefect => backport
2021-06-24 09:55alostaleTarget Version => PR21Q1.4
2021-06-24 09:56alostaleSummary"changes peding" displayed after MMC module install + rebuild => "changes pending" displayed after MMC module install + rebuild
2021-06-24 14:03alostaleTarget VersionPR21Q1.4 => PR21Q2.1
2021-06-24 14:06hgbotMerge Request Status => open
2021-06-24 14:06hgbotNote Added: 0129771
2021-06-24 16:32hgbotMerge Request Statusopen => approved
2021-06-24 16:37hgbotResolutionopen => fixed
2021-06-24 16:37hgbotStatusscheduled => closed
2021-06-24 16:37hgbotFixed in Version => PR21Q2.1
2021-06-24 16:37hgbotNote Added: 0129783
2021-06-24 16:37hgbotNote Added: 0129784

Notes
(0129771)
hgbot   
2021-06-24 14:06   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/407 [^]
(0129783)
hgbot   
2021-06-24 16:37   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: bbd48e9c353a02b82b2a706a62e3845964532722
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-06-24T14:04:36+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/bbd48e9c353a02b82b2a706a62e3845964532722 [^]

fixes BUG-47238: "changes pending" displayed after MMC module install + rebuild

After following the steps described in the doc to install a module:
 - Install module from MMC
 - ant update.database
 - ant compile.complete.deploy

the module remains in status Pending (P).

Status is updated to Applied (A) on install.source and smartbuild.

This fix moves the status update from smartbuild to update.database
after applying modules (importing their reference data) where this flag is
used. In fact, this is more correct than what was done before as
smartbuild without datbase update could lead modules in an incorrect
status.

---
M build.xml
---
(0129784)
hgbot   
2021-06-24 16:37   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/407 [^]