Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047235Retail ModulesWeb POSpublic2021-06-23 20:562021-08-18 12:24
Reporterlbressan 
Assigned Toprakashmurugesan88 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q4 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket25651
Regression levelProduction - Confirmed Stable
Regression date2020-04-06
Regression introduced in releaseRR20Q3
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/5b38c630a4ac0542bd375c1dfe78c87af39f8724#fd80634de0163786437910f28d20eb0175cf3c4d_0_32 [^]
Triggers an Emergency PackNo
Summary0047235: 25651 - Incorrect tax id getting set when tax have multi level taxes
DescriptionIncorrect tax id getting set when tax have multi level taxes after OB upgrade 20Q3. In SO lines instead of setting summary level tax id, it sets the child tax id. This was not the case in 18Q3.

Expected behavior: Incase of multi-tax summary level tax id should be set in POS order lines.
Steps To Reproduce1. A compound tax corresponding to the Third Party is created.
2. An order is created from the pos, for the third party with the tax category for which the tax was created.
3. When checking from the backoffice it is detected that the tax line was incorrectly reflected in the order line (appears with **)

A video is attached with the step by step and the test carried out in livebuild
https://drive.google.com/file/d/1UqkHF4a7cGT_JNIwB0Ttc5mph-tOtt8g/view?usp=sharing [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0047563RR21Q3.1 closed prakashmurugesan88 25651 - Incorrect tax id getting set when tax have multi level taxes 
depends on backport 0047564RR21Q2.2 closed prakashmurugesan88 25651 - Incorrect tax id getting set when tax have multi level taxes 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-06-23 20:56lbressanNew Issue
2021-06-23 20:56lbressanAssigned To => Triage Finance
2021-06-23 20:56lbressanOBNetwork customer => OBPS
2021-06-23 20:56lbressanModules => Core
2021-06-23 20:56lbressanSupport ticket => 25651
2021-06-23 20:56lbressanResolution time => 1627336800
2021-06-23 20:56lbressanTriggers an Emergency Pack => No
2021-06-23 21:03lbressanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=22762#r22762
2021-06-24 12:18vmromanosAssigned ToTriage Finance => Retail
2021-08-11 09:19adrianromeroProjectOpenbravo ERP => Retail Modules
2021-08-11 09:24adrianromeroCategory09. Financial management => Web POS
2021-08-16 07:38prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2021-08-16 07:38prakashmurugesan88Statusnew => scheduled
2021-08-16 16:06hgbotMerge Request Status => open
2021-08-16 16:06hgbotNote Added: 0131147
2021-08-16 16:07hgbotNote Added: 0131148
2021-08-18 07:38marvintmStatusscheduled => acknowledged
2021-08-18 07:38marvintmStatusacknowledged => scheduled
2021-08-18 07:39marvintmRegression level => Production - Confirmed Stable
2021-08-18 07:39marvintmRegression date => 2020-04-06
2021-08-18 07:39marvintmRegression introduced in release => RR20Q3
2021-08-18 07:39marvintmRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/5b38c630a4ac0542bd375c1dfe78c87af39f8724#fd80634de0163786437910f28d20eb0175cf3c4d_0_32 [^]
2021-08-18 07:47hgbotMerge Request Statusopen => approved
2021-08-18 07:47hgbotNote Added: 0131161
2021-08-18 07:47hgbotResolutionopen => fixed
2021-08-18 07:47hgbotStatusscheduled => closed
2021-08-18 07:47hgbotFixed in Version => RR21Q4
2021-08-18 07:47hgbotNote Added: 0131162
2021-08-18 07:47hgbotNote Added: 0131163
2021-08-18 07:47hgbotNote Added: 0131164
2021-08-18 12:16hgbotNote Added: 0131178
2021-08-18 12:24hgbotNote Added: 0131179
2021-08-18 12:24hgbotNote Added: 0131180

Notes
(0131147)
hgbot   
2021-08-16 16:06   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/544 [^]
(0131148)
hgbot   
2021-08-16 16:07   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/117 [^]
(0131161)
hgbot   
2021-08-18 07:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/544 [^]
(0131162)
hgbot   
2021-08-18 07:47   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: de5003c5356cf35057848f0378ec4af344726ac2
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-08-18T05:47:33+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/de5003c5356cf35057848f0378ec4af344726ac2 [^]

Fixed BUG-47235: Fixes issue where summary level tax id is not set to line when tax have multi level taxes

---
M web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/tax-rules.js
---
(0131163)
hgbot   
2021-08-18 07:47   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/117 [^]
(0131164)
hgbot   
2021-08-18 07:47   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: b456d70c45f7de804b1217a1e0e05120122da38c
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-08-16T19:09:37+05:30
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/b456d70c45f7de804b1217a1e0e05120122da38c [^]

Related to BUG-47235 : Added test to Verify Summary Level Tax is Set to Line in case of multi level taxes

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/taxes/I47235_VerifySummaryLevelTaxSetLine.java
---
(0131178)
hgbot   
2021-08-18 12:16   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.taxes/-/merge_requests/8 [^]
(0131179)
hgbot   
2021-08-18 12:24   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.taxes [^]
Changeset: 8c9ef2b217a396fec9306dadcbf71831d759769f
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-08-18T15:42:12+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.taxes/-/commit/8c9ef2b217a396fec9306dadcbf71831d759769f [^]

Related to BUG-47235 : Fixes wrong parentTaxRate property used in junit tests

---
M src-test/org/openbravo/taxes/test/base/model/TaxesRule.java
---
(0131180)
hgbot   
2021-08-18 12:24   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.taxes/-/merge_requests/8 [^]