Openbravo Issue Tracking System - POS2
View Issue Details
0047232POS2POSpublic2021-06-23 17:542021-08-03 15:00
javietxe 
jarmendariz 
normalmajorhave not tried
closedfixed 
5
 
 
No
0047232: JIRA 2057: CRM connector focus changing and validations
When changing the focus, seems that if the validation takes more time than the focus changing actions, some asynchrony can happen letting the CRM connector in a strange state.

In Agapes it happens with the email field (it has a validation) together with the "is dematerialised?" checkbox, that depending on the selection some fields are hidden or not.
When creating a customer,

When we check/uncheck several times “Demat card” checkbox

When leave checkbox unchecked

When start to enter an email

When clicking on “Demat card”, the fields “Card number” and crypto remains instead of being hidden (See the video provided in the JIRA)
When changing focus from an imput, wait some
No tags attached.
related to defect 0046889 closed ebecerra Extra buttons are displayed in the customer form while on change operation is in progress 
depends on backport 0047234TAP closed jarmendariz JIRA 2057: CRM connector focus changing and validations 
related to defect 0048287 closed caristu Need to click clear button twice to clear validated form fields 
wmv error_validation_crm.wmv (979,603) 2021-06-29 11:38
https://issues.openbravo.com/file_download.php?file_id=15971&type=bug
? 2021-08-03_10-59-14.mp4 (557,746) 2021-08-03 13:43
https://issues.openbravo.com/file_download.php?file_id=16067&type=bug
Issue History
2021-06-23 17:54javietxeNew Issue
2021-06-23 17:54javietxeAssigned To => Retail
2021-06-23 17:54javietxeResolution time => 1625608800
2021-06-23 17:54javietxeTriggers an Emergency Pack => No
2021-06-23 17:58guilleaerStatusnew => scheduled
2021-06-23 17:58guilleaerAssigned ToRetail => platform
2021-06-23 17:58guilleaerStatusscheduled => acknowledged
2021-06-29 11:38cbernerFile Added: error_validation_crm.wmv
2021-07-08 17:46jarmendarizNote Added: 0130331
2021-07-13 12:14dmiguelezResolution time1625608800 => 1627423200
2021-07-22 17:51jarmendarizAssigned Toplatform => jarmendariz
2021-07-22 17:54hgbotNote Added: 0130703
2021-07-23 09:25jarmendarizRelationship addedrelated to 0046889
2021-07-30 18:54hgbotResolutionopen => fixed
2021-07-30 18:54hgbotStatusacknowledged => closed
2021-07-30 18:54hgbotNote Added: 0130908
2021-07-30 18:54hgbotNote Added: 0130909
2021-08-03 13:43jmelinNote Added: 0130950
2021-08-03 13:43jmelinStatusclosed => new
2021-08-03 13:43jmelinResolutionfixed => open
2021-08-03 13:43jmelinFile Added: 2021-08-03_10-59-14.mp4
2021-08-03 14:59dmiguelezResolution time1627423200 =>
2021-08-03 14:59dmiguelezNote Added: 0130956
2021-08-03 14:59dmiguelezSeveritymajor => trivial
2021-08-03 14:59dmiguelezTypedefect => design defect
2021-08-03 14:59dmiguelezStatusnew => acknowledged
2021-08-03 14:59dmiguelezNote Edited: 0130956bug_revision_view_page.php?bugnote_id=0130956#r22960
2021-08-03 14:59dmiguelezStatusacknowledged => scheduled
2021-08-03 15:00dmiguelezSeveritytrivial => major
2021-08-03 15:00dmiguelezTypedesign defect => defect
2021-08-03 15:00dmiguelezStatusscheduled => resolved
2021-08-03 15:00dmiguelezResolutionopen => fixed
2021-08-03 15:00dmiguelezStatusresolved => closed
2021-08-03 15:00dmiguelezNote Edited: 0130956bug_revision_view_page.php?bugnote_id=0130956#r22961
2021-08-03 15:00dmiguelezNote Edited: 0130956bug_revision_view_page.php?bugnote_id=0130956#r22962
2021-12-20 16:50caristuRelationship addedrelated to 0048287

Notes
(0130331)
jarmendariz   
2021-07-08 17:46   
After discussing this topic with Guillermo, Cristian, David Baz and myself, we all agreed that we should be able to keep a flag in the Form's state to indicate that the form is being validated at this moment so, when a checkbox processes a check/uncheck event, we can delay the execution of this event until the validation is finished and then we know whether this checkbox event could be processed or not.
(0130703)
hgbot   
2021-07-22 17:54   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/606 [^]
(0130908)
hgbot   
2021-07-30 18:54   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 735145b7022ea8d21a058ce60ba171abf2d09c73
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-07-30T16:53:51+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/735145b7022ea8d21a058ce60ba171abf2d09c73 [^]

Fixed ISSUE-47232: Blocking UI before validation when a field changes to avoid overlapping states when form item changes at the same time as the validation

---
M web-jspack/org.openbravo.core2/src/components/BaseFormDatePicker/BaseFormDatePicker.jsx
M web-jspack/org.openbravo.core2/src/components/BaseFormInput/BaseFormInput.jsx
M web-jspack/org.openbravo.core2/src/components/BaseFormInput/ClearInputButton.jsx
M web-jspack/org.openbravo.core2/src/components/BaseFormTimePicker/BaseFormTimePicker.jsx
M web-jspack/org.openbravo.core2/src/components/Form/BaseForm.jsx
M web-jspack/org.openbravo.core2/src/components/Form/__test__/ConfigurableForm.test.jsx
M web-jspack/org.openbravo.core2/src/components/Form/__test__/TestForm.config.json
---
(0130909)
hgbot   
2021-07-30 18:54   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/606 [^]
(0130950)
jmelin   
2021-08-03 13:43   
After filling the email, you need to click twice on "Demat" checkbox to change it as "selected"

1. Open window to create a new customer
2. Click several times on checkbox “Demat card” and leave unchecked
3. Type an email address in the email field
4. Click on the “Demat card” checkbox

=> KO, something appears/disappears and the checkbox remains unchecked.
You need to click a 2nd time to be selected
(0130956)
dmiguelez   
2021-08-03 14:59   
(edited on: 2021-08-03 15:00)
This is a known side effect created by the resolution of the issue.
However, since the data is consistent (which was not before the fix) and since this is a very corner case from the business flow point of view, this scenario can be reported as a different issue categorized as a trivial design defect