Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047226POS2POSpublic2021-06-23 12:382021-08-16 15:15
Reportermarvintm 
Assigned ToAtulOpenbravo 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047226: Credit notes generated when "Credit note expiration days" is set to 0 cannot be used
DescriptionIf the field "Credit notes expiration days" is set to 0 in the Organization configuration, the generated credit notes have no expiration date. This is correct.

However, when you then try to use those credit notes to pay, the "Apply" button is disabled. The reason is that the system incorrectly considers that the expiration date is "1970". This is wrong.
Steps To Reproduce-Configure "Credit notes expiration days" to 0 in Organization window.
- Log in the WebPOS. Generate a credit note, by either configuring the "Return overpayment as credit note" flag in a payment method, and then generating overpayment, or just generating a credit note from a returned order by using this development: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/73 [^]
- Create a normal sales order. Select to pay it with credit note. Input the document number of the credit note in the selector. Realise that the credit note is correctly opened, but the "Apply" button is disabled. Realise also that the expiration date is set to "01-01-1970"
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0047627TAP closed AtulOpenbravo [TAP only] Credit note with no expiration date can't be consumed 
related to defect 0047677 closed AtulOpenbravo Close button in Gift Card Dialog Form does not close the dialog 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-06-23 12:38marvintmNew Issue
2021-06-23 12:38marvintmAssigned To => Retail
2021-06-23 12:38marvintmTriggers an Emergency Pack => No
2021-07-14 09:40dmiguelezResolution time => 1628028000
2021-07-14 09:40dmiguelezStatusnew => acknowledged
2021-07-29 09:29dmiguelezAssigned ToRetail => prakashmurugesan88
2021-07-29 09:30prakashmurugesan88Statusacknowledged => scheduled
2021-08-06 11:26dmiguelezAssigned Toprakashmurugesan88 => AtulOpenbravo
2021-08-06 11:26dmiguelezStatusscheduled => acknowledged
2021-08-06 11:33dmiguelezResolution time1628028000 => 1629410400
2021-08-11 13:05AtulOpenbravoStatusacknowledged => scheduled
2021-08-12 12:44hgbotNote Added: 0131097
2021-08-12 12:59AtulOpenbravoNote Added: 0131100
2021-08-16 15:15hgbotResolutionopen => fixed
2021-08-16 15:15hgbotStatusscheduled => closed
2021-08-16 15:15hgbotNote Added: 0131145
2021-08-16 15:15hgbotNote Added: 0131146
2021-09-06 11:39AtulOpenbravoRelationship addedrelated to 0047627
2021-09-13 12:33AtulOpenbravoRelationship addedrelated to 0047677

Notes
(0131097)
hgbot   
2021-08-12 12:44   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/81 [^]
(0131100)
AtulOpenbravo   
2021-08-12 12:59   
Test Plan

-Configure "Credit notes expiration days" to 0 in Organization window.
- Log in the WebPOS.
- Generate a credit note, by either configuring the "Return overpayment as credit note" flag in a payment method, and then generating overpayment.
- Create a normal sales order. Select to pay it with credit note. Input the document number of the credit note in the selector.
- Realise that the credit note is correctly opened, the "Apply" button is enabled.
- Realise that the expiration date is set as blank.
(0131145)
hgbot   
2021-08-16 15:15   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: f241a4cc30a569b515e194c21ab68a11cc0806db
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 2021-08-16T13:06:56+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/f241a4cc30a569b515e194c21ab68a11cc0806db [^]

Fixes BUG-0047226: Credit notes generated when "Credit note
expiration days" is set to 0 cannot be used

**onLoad in GiftCardDialogFormHandler, OB.Utilities.Date.JSToOB
considers null as JSDate input paramter when filterResult
obgcneExpirationdate is null

---
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardDialog/GiftCardDialogFormHandler.js
---
(0131146)
hgbot   
2021-08-16 15:15   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/81 [^]