Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047069POS2POSpublic2021-06-11 11:582022-05-23 10:41
Reporterjmelin 
Assigned Tomeriem_azaf 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047069: JIRA 2083 - Safebox - Exception "null value" when "Cash difference" or "G/L Item for Cash Drop/Deposit" not set for payment
DescriptionException "null value" when "Cash difference" or "G/L Item for Cash Drop/Deposit" not set for payment instead of an explicit message
Steps To ReproduceBO:
1. In "Safe box" , select "VBS01"
2. In "Payment method", select "Cash"
3. Remove value from "Cash difference" and save

POS :
1. Connect to POS VBS2
2. Select VBS01 safe box and do initial count
3. Do an order
4. Execute cashup
5. Reconnect to POS
6. Count Safe box VBS01

BO :
=> an error is triggered in "Errors while importing" and exception "null value", we should have an error like :

"Cash difference" or "G/L Item for Cash Drop/Deposit" not set for payment method
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-06-11 11:58jmelinNew Issue
2021-06-11 11:58jmelinAssigned To => Retail
2021-06-11 11:58jmelinOBNetwork customer => Gold
2021-06-11 11:58jmelinTriggers an Emergency Pack => No
2021-06-14 10:23dmiguelezStatusnew => acknowledged
2021-06-14 10:24dmiguelezResolution time => 1626040800
2021-07-12 08:40prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2021-07-12 08:40prakashmurugesan88Statusacknowledged => scheduled
2021-07-13 13:13dmiguelezResolution time1626040800 => 1626818400
2021-07-16 12:39hgbotMerge Request Status => open
2021-07-16 12:39hgbotNote Added: 0130537
2021-07-16 12:41hgbotNote Added: 0130538
2021-07-16 12:45hgbotMerge Request Statusopen => approved
2021-07-16 12:47hgbotResolutionopen => fixed
2021-07-16 12:47hgbotStatusscheduled => closed
2021-07-16 12:47hgbotFixed in Version => RR21Q4
2021-07-16 12:47hgbotNote Added: 0130539
2021-07-16 12:47hgbotNote Added: 0130540
2021-07-16 12:48hgbotNote Added: 0130541
2021-07-16 12:48hgbotNote Added: 0130542
2022-04-01 11:48jmelinAssigned Toprakashmurugesan88 => Retail
2022-04-01 11:48jmelinNote Added: 0136249
2022-04-01 11:48jmelinStatusclosed => new
2022-04-01 11:48jmelinResolutionfixed => open
2022-04-01 11:48jmelinFixed in VersionRR21Q4 =>
2022-05-04 16:48AugustoMauchAssigned ToRetail => meriem_azaf
2022-05-05 14:37hgbotNote Added: 0136980
2022-05-05 15:48AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=24025#r24025
2022-05-05 15:48AugustoMauchStatusnew => scheduled
2022-05-23 10:41hgbotNote Added: 0137601
2022-05-23 10:41hgbotResolutionopen => fixed
2022-05-23 10:41hgbotStatusscheduled => closed
2022-05-23 10:41hgbotFixed in Version => RR22Q3
2022-05-23 10:41hgbotNote Added: 0137602

Notes
(0130537)
hgbot   
2021-07-16 12:39   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/612 [^]
(0130538)
hgbot   
2021-07-16 12:41   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/519 [^]
(0130539)
hgbot   
2021-07-16 12:47   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 5a12d559fe9c00adb2c7d72e368dd96e686c4cc1
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-07-16T15:18:19+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/5a12d559fe9c00adb2c7d72e368dd96e686c4cc1 [^]

Fixed BUG-47069: Fixes null pointer exception on doing count safe box
* Error occurs when Cash difference or G/L Item for Cash Drop/Deposit are not set for payment in SafeBox

---
M src/org/openbravo/retail/posterminal/CountSafeBoxProcessor.java
---
(0130540)
hgbot   
2021-07-16 12:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/519 [^]
(0130541)
hgbot   
2021-07-16 12:48   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 085f93a2ba5a4b474c39d0a41d5f8548f5866a04
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-07-16T10:47:22+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/085f93a2ba5a4b474c39d0a41d5f8548f5866a04 [^]

Related to BUG-47069: Fixed missing id error while making entry obpos_errors on doing count safebox.
* id is missing as posterminal property is missing in payload

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/PreparePayloadForFinishCountSafebox.js
---
(0130542)
hgbot   
2021-07-16 12:48   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/612 [^]
(0136249)
jmelin   
2022-04-01 11:48   
When "Cash difference" or "G/L Item for Cash Drop/Deposit" are not set for a Payment method in BO, then we have a NullException error when importing in ”Error while importing"
(0136980)
hgbot   
2022-05-05 14:37   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/788 [^]
(0137601)
hgbot   
2022-05-23 10:41   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/788 [^]
(0137602)
hgbot   
2022-05-23 10:41   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 3a6b2ef6c440abb03377543020e9278e7b570b6e
Author: Meriem Azaf <meriem.azaf@openbravo.com>
Date: 23-05-2022 10:40:18
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/3a6b2ef6c440abb03377543020e9278e7b570b6e [^]

Fixes ISSUE-47069: Safebox exception null value after the initial count

Exception "null value" when "Cash difference" or "G/L Item for Cash Drop/Deposit" not set for payment instead of an explicit message.

---
M src/org/openbravo/retail/posterminal/CountSafeBoxProcessor.java
---