Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047063POS2POSpublic2021-06-11 11:112021-10-06 11:35
Reporterjmelin 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047063: JIRA 2078 - Safebox/Counting - Intial count in BO
DescriptionThe data entered on POS when performing counting (cashup or safebox) must be available in BO.

Currently, in the cashup history tab, we store the "starting amount" of each payment method, that corresponds to the "amount to keep" of the last cashup.

However, for some payment methods, depending on the configuration, an "initial count" operation may be performed by the cashier. Depending on the result of this operation, the available amount may be lower or greater than the theoretical starting amount.

This is currently properly reflected by a transaction for differences that is created in the corresponding financial account. However, this is not reflected in the Cashup History, and it would be very useful to keep track of this.

So, the proposal is to add a new column, "Initlally counted amount", besides the "Starting amount" on each payment method on the Cashup History tab. This amount will be equal to the "Starting amount" in case the payment method is not counted. If it is counted, then it will be the amount provided by the user when he counts.
Steps To ReproduceThe data entered on POS when performing counting (cashup or safebox) must be available in BO.

Currently, in the cashup history tab, we store the "starting amount" of each payment method, that corresponds to the "amount to keep" of the last cashup.

However, for some payment methods, depending on the configuration, an "initial count" operation may be performed by the cashier. Depending on the result of this operation, the available amount may be lower or greater than the theoretical starting amount.

This is currently properly reflected by a transaction for differences that is created in the corresponding financial account. However, this is not reflected in the Cashup History, and it would be very useful to keep track of this.

So, the proposal is to add a new column, "Initlally counted amount", besides the "Starting amount" on each payment method on the Cashup History tab. This amount will be equal to the "Starting amount" in case the payment method is not counted. If it is counted, then it will be the amount provided by the user when he counts.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-06-11 11:11jmelinNew Issue
2021-06-11 11:11jmelinAssigned To => Retail
2021-06-11 11:11jmelinOBNetwork customer => Gold
2021-06-11 11:11jmelinTriggers an Emergency Pack => No
2021-06-14 10:35marvintmSeveritycritical => minor
2021-06-14 10:46marvintmNote Added: 0129451
2021-06-14 10:46marvintmAssigned ToRetail => jmelin
2021-06-14 10:46marvintmStatusnew => feedback
2021-06-17 12:53marvintmDescription Updatedbug_revision_view_page.php?rev_id=22739#r22739
2021-06-17 12:53marvintmSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=22741#r22741
2021-06-17 12:53marvintmStatusfeedback => scheduled
2021-06-17 12:53marvintmAssigned Tojmelin => Retail
2021-06-17 12:54marvintmStatusscheduled => acknowledged
2021-06-17 17:55dmiguelezResolution time => 1625090400
2021-06-21 16:23dmiguelezSeverityminor => critical
2021-06-22 11:18guilleaerNote Deleted: 0129451
2021-06-22 19:29guilleaerResolution time1625090400 => 1628978400
2021-06-23 12:04dmiguelezStatusacknowledged => scheduled
2021-06-23 12:04dmiguelezStatusscheduled => acknowledged
2021-06-23 12:05dmiguelezStatusacknowledged => scheduled
2021-06-23 12:05dmiguelezSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=22757#r22757
2021-06-23 12:05dmiguelezStatusscheduled => acknowledged
2021-06-23 12:05dmiguelezStatusacknowledged => scheduled
2021-06-23 12:05dmiguelezAssigned ToRetail => pablobessone
2021-06-24 11:36dmiguelezStatusscheduled => acknowledged
2021-06-29 16:52guilleaerAssigned Topablobessone => Retail
2021-08-16 14:38guilleaerResolution time1628978400 => 1631656800
2021-09-30 15:57hgbotMerge Request Status => open
2021-09-30 15:57hgbotNote Added: 0132085
2021-09-30 16:00hgbotNote Added: 0132086
2021-10-01 08:04marvintmSeveritycritical => major
2021-10-06 07:54jorge-garciaStatusacknowledged => scheduled
2021-10-06 07:54jorge-garciaReview Assigned To => marvintm
2021-10-06 11:13hgbotMerge Request Statusopen => approved
2021-10-06 11:13hgbotResolutionopen => fixed
2021-10-06 11:13hgbotStatusscheduled => closed
2021-10-06 11:13hgbotFixed in Version => RR22Q1
2021-10-06 11:13hgbotNote Added: 0132184
2021-10-06 11:13hgbotNote Added: 0132185
2021-10-06 11:13hgbotNote Added: 0132186
2021-10-06 11:13hgbotNote Added: 0132187
2021-10-06 11:14hgbotNote Added: 0132188
2021-10-06 11:14hgbotNote Added: 0132189
2021-10-06 11:35marvintmAssigned ToRetail => jorge-garcia

Notes
(0132085)
hgbot   
2021-09-30 15:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/583 [^]
(0132086)
hgbot   
2021-09-30 16:00   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/689 [^]
(0132184)
hgbot   
2021-10-06 11:13   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: c3927b30061e0eded7dcd11e709444f7ebbdc940
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 2021-10-04T07:58:55+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c3927b30061e0eded7dcd11e709444f7ebbdc940 [^]

Fixed ISSUE-47063: Include a new column to know the initial count
for a payment method in cashup history

If no initial count is done, the value is the same as the starting
cash value.

---
M src-db/database/model/tables/OBPOS_PAYMENTMETHODCASHUP.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/PaymentMethodUtils.js
---
(0132185)
hgbot   
2021-10-06 11:13   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 9da836134cd8bb00297523fa0811d93b147ddf06
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 2021-10-04T09:29:18+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/9da836134cd8bb00297523fa0811d93b147ddf06 [^]

Related to ISSUE-47063: Update test to take into account new variable in cashup

---
M web-test/model/business-object/cashup/Cashup-initCashup-StateAction-fromLocal.test.js
M web-test/model/business-object/cashup/test-data/cashupAfterComplete.js
M web-test/model/business-object/cashup/test-data/cashupAfterLoadCashupFromBackendWithoutPayments.js
M web-test/model/business-object/cashup/test-data/cashupCreatedFromScratch.js
M web-test/model/business-object/cashup/test-data/cashupCreatedFromScratchWithoutLastCashupPayments.js
M web-test/model/business-object/cashup/test-data/cashupMessageSharedPayments.js
M web-test/model/business-object/cashup/test-data/messagesAfterCompleteCashupSharedPayments.js
---
(0132186)
hgbot   
2021-10-06 11:13   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 825eb5138ce0e69c34165ac86312633754dfa3a5
Author: Antonio Moreno <anmorenoperez@gmail.com>
Date: 2021-10-06T11:12:08+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/825eb5138ce0e69c34165ac86312633754dfa3a5 [^]

Related to ISSUE-47063: Adjusted order of fields in form and grid

---
M src-db/database/sourcedata/AD_FIELD.xml
---
(0132187)
hgbot   
2021-10-06 11:13   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/583 [^]
(0132188)
hgbot   
2021-10-06 11:14   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: d9cd932b44fdd285ea54c1d624f6bef66b97fddd
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 2021-10-06T09:12:53+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d9cd932b44fdd285ea54c1d624f6bef66b97fddd [^]

Related to ISSUE-47063: Update cashup initial counting for safe boxes
payment methods

For standard payment method, it is not to decalre any kind of
differences so the starting cash amount will always be the initial
counted amount

---
A web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/UpdateCashUpWithInitialCount.js
M web-jspack/org.openbravo.pos2/src/model/cashup/CashupExtension.js
---
(0132189)
hgbot   
2021-10-06 11:14   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/689 [^]