Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047055POS2Corepublic2021-06-10 14:212021-07-15 14:39
Reportercberner 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047055: Loading screen has some white background and a scroll, which should not be there
DescriptionStyle in loading screen is wrong, some white borders appear and also a scroll-bar. This is due to wrong body margins, not being reset to 0 on this screen.
Steps To Reproduce1. Open new WebPOS or refresh
2. Check that some white borders appear while loading

A screenshot has been attached to show the issue.
Proposed SolutionAdd missing body styling to LoadingScreen.scss or it's parent. (the first one when loading the application)

body {
  margin: 0rem;
  padding: 0rem;
  height: 100%;
}
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Screenshot from 2021-06-10 14-00-29.png (16,960) 2021-06-10 14:21
https://issues.openbravo.com/file_download.php?file_id=15908&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2021-06-10 14:21cbernerNew Issue
2021-06-10 14:21cbernerAssigned To => Retail
2021-06-10 14:21cbernerFile Added: Screenshot from 2021-06-10 14-00-29.png
2021-06-10 14:21cbernerOBNetwork customer => No
2021-06-10 14:21cbernerTriggers an Emergency Pack => No
2021-06-10 14:21cbernerAssigned ToRetail => platform
2021-06-10 14:24cbernerSeverityminor => trivial
2021-06-14 09:44guilleaerResolution time => 1627077600
2021-06-14 09:44guilleaerSeveritytrivial => minor
2021-06-14 09:44guilleaerStatusnew => acknowledged
2021-07-14 08:57alostaleStatusacknowledged => scheduled
2021-07-14 08:57alostaleAssigned Toplatform => alostale
2021-07-14 09:03hgbotMerge Request Status => open
2021-07-14 09:03hgbotNote Added: 0130449
2021-07-14 16:25dmiguelezResolution time1627077600 => 1610233200
2021-07-14 16:26dmiguelezResolution time1610233200 => 1628028000
2021-07-14 16:27dmiguelezResolution time1628028000 => 1627336800
2021-07-15 10:27hgbotMerge Request Statusopen => approved
2021-07-15 14:39hgbotResolutionopen => fixed
2021-07-15 14:39hgbotStatusscheduled => closed
2021-07-15 14:39hgbotNote Added: 0130513
2021-07-15 14:39hgbotNote Added: 0130514

Notes
(0130449)
hgbot   
2021-07-14 09:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/593 [^]
(0130513)
hgbot   
2021-07-15 14:39   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: e75e68b34df611e3ab0fb5905b85c5c34be84111
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-07-15T12:38:56+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/e75e68b34df611e3ab0fb5905b85c5c34be84111 [^]

fixes BUG-47055: loading screen has some white margin

Initial loading screen, rendered in index.jsx, applies styles from
main.scss only. Main page's body's styles (margin, padding and height)
were defined in MainApp.scss which are only applied when the App is
loaded.

This fix moves these basic styles from MainApp.scss to main.scss.

---
M web-jspack/org.openbravo.core2/src/assets/style/main.scss
M web-jspack/org.openbravo.core2/src/components/MainApp/MainApp.scss
---
(0130514)
hgbot   
2021-07-15 14:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/593 [^]