Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047044POS2Corepublic2021-06-09 14:572022-05-13 02:09
Reportertimothee_catteeuw 
Assigned ToAtulOpenbravo 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047044: JIRA 1981 - avoir - popup after cancelling a ticket not needed
DescriptionA pop-up is not needed when paying use case :
- do a ticket and then go to payment screen
- select as payment method credit note
- Close the without tipping anything, a message error id displayed and requires an additional validation
→ this message is useless

→ I think the better approach is to put a message at the bottom left so that the process is not blocked like in my screenshot.
Steps To Reproduce- do a ticket and then go to payment screen
- select as payment method credit note
- Close the without tipping anything, a message error id displayed
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng image-2021-05-28-12-42-28-808.png (53,620) 2021-06-09 14:57
https://issues.openbravo.com/file_download.php?file_id=15906&type=bug
png

png image-2021-05-28-12-42-01-588.png (40,482) 2021-06-09 14:57
https://issues.openbravo.com/file_download.php?file_id=15907&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2021-06-09 14:57timothee_catteeuwNew Issue
2021-06-09 14:57timothee_catteeuwAssigned To => Retail
2021-06-09 14:57timothee_catteeuwFile Added: image-2021-05-28-12-42-28-808.png
2021-06-09 14:57timothee_catteeuwTriggers an Emergency Pack => No
2021-06-09 14:57timothee_catteeuwFile Added: image-2021-05-28-12-42-01-588.png
2021-06-10 11:47dmiguelezStatusnew => acknowledged
2021-06-10 11:47dmiguelezResolution time => 1625695200
2021-06-10 11:47dmiguelezTypedesign defect => defect
2021-06-14 11:34guilleaerTarget VersionTAP =>
2021-07-14 17:17dmiguelezResolution time1625695200 => 1628892000
2021-07-27 15:55dmiguelezAssigned ToRetail => hernan-dp
2021-08-05 15:15hernan-dpNote Added: 0130990
2021-08-06 10:57dmiguelezNote Added: 0131008
2021-08-06 10:57dmiguelezTypedefect => design defect
2021-08-06 10:58dmiguelezAssigned Tohernan-dp => Retail
2022-04-25 22:34mtaalAssigned ToRetail => mtaal
2022-05-12 19:29AtulOpenbravoStatusacknowledged => scheduled
2022-05-12 19:29AtulOpenbravoNote Added: 0137236
2022-05-12 19:29AtulOpenbravoAssigned Tomtaal => AtulOpenbravo
2022-05-12 19:40hgbotNote Added: 0137237
2022-05-13 02:09hgbotResolutionopen => fixed
2022-05-13 02:09hgbotStatusscheduled => closed
2022-05-13 02:09hgbotNote Added: 0137246
2022-05-13 02:09hgbotNote Added: 0137247

Notes
(0130990)
hernan-dp   
2021-08-05 15:15   
Debugged the issue. PaymentProvider dialog is always rendered behind gift card dialog, catches the error in processPayment.js, Couldn't find a way to close the payment provider dialog without it closing for every instance of error there was not only when close button is applied.
(0131008)
dmiguelez   
2021-08-06 10:57   
Seems that it is necessary to change the API behind to add another option to show or not the error message.
This issue has been updated as a Design defect
(0137236)
AtulOpenbravo   
2022-05-12 19:29   
Test Plan

- Create a ticket, add one or more products, then go to payment screen
- select as payment method credit note
- Close the without typing anything
- Realize that Dialog is closed successfully without any other confirmation popup.
(0137237)
hgbot   
2022-05-12 19:40   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/116 [^]
(0137246)
hgbot   
2022-05-13 02:09   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 4b0f55c87a71ebae4cb48a3d1833a20fac513adc
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 13-05-2022 00:08:24
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/4b0f55c87a71ebae4cb48a3d1833a20fac513adc [^]

Fixed BUG-0047044: JIRA 1981 - avoir - popup after cancelling a
ticket not needed

When throwing a eror when gift card is not selected add
property showPopMessage as false to the error object along
with message.

---
M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GiftCardPaymentProvider.jsx
---
(0137247)
hgbot   
2022-05-13 02:09   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/116 [^]