Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047043POS2Restaurantspublic2021-06-09 14:432021-06-22 12:28
ReporterYBataille 
Assigned Toprakashmurugesan88 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047043: JIRA 487 - Delete a Line on a unfinalized ticked
DescriptionThere is a UserAction 'DeleteLine' who can be 'Approval' to suppress a complete line on an order.
 It work perfectly.

But if user open the line , and decrease using '-' touch of the pop up menu, no approval is required. It can be a fail in security.
Steps To ReproduceCreate an order with several items
Select one item
use 'Minus' touch to decrease until Zero
The line disapears
Proposed SolutionApproval if Qty is Zero (Are you sure to delete? Or standard screen)
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0047053TAP closed prakashmurugesan88 JIRA 487 - Delete a Line on a unfinalized ticked 
Attached Filespng Jira 487 2021-06-09 A.png (45,859) 2021-06-09 14:43
https://issues.openbravo.com/file_download.php?file_id=15904&type=bug
png

png Jira 487 2021-06-09 142450.png (81,585) 2021-06-09 14:44
https://issues.openbravo.com/file_download.php?file_id=15905&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2021-06-09 14:43YBatailleNew Issue
2021-06-09 14:43YBatailleAssigned To => Retail
2021-06-09 14:43YBatailleFile Added: Jira 487 2021-06-09 A.png
2021-06-09 14:43YBatailleOBNetwork customer => OBPS
2021-06-09 14:43YBatailleTriggers an Emergency Pack => No
2021-06-09 14:44YBatailleFile Added: Jira 487 2021-06-09 142450.png
2021-06-09 14:45YBatailleNote Added: 0129267
2021-06-10 11:56dmiguelezStatusnew => scheduled
2021-06-10 11:57dmiguelezRegression date => 2021-06-24
2021-06-10 11:57dmiguelezStatusscheduled => acknowledged
2021-06-14 09:12guilleaerResolution time => 1624485600
2021-06-14 09:12guilleaerRegression date2021-06-24 =>
2021-06-17 13:38prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2021-06-17 13:38prakashmurugesan88Statusacknowledged => scheduled
2021-06-21 07:36hgbotMerge Request Status => open
2021-06-21 07:36hgbotNote Added: 0129675
2021-06-22 12:07hgbotMerge Request Statusopen => approved
2021-06-22 12:28hgbotResolutionopen => fixed
2021-06-22 12:28hgbotStatusscheduled => closed
2021-06-22 12:28hgbotNote Added: 0129712
2021-06-22 12:28hgbotNote Added: 0129713

Notes
(0129267)
YBataille   
2021-06-09 14:45   
the green arrow is well performing.
The red arrow (using minus key) is the wrong issue.
(0129675)
hgbot   
2021-06-21 07:36   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/569 [^]
(0129712)
hgbot   
2021-06-22 12:28   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 1e479283d12c7d9a304543f89b2b8897baaa6877
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-06-22T15:06:09+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/1e479283d12c7d9a304543f89b2b8897baaa6877 [^]

Fixed BUG-47043: Invoked DeleteLine action if the qty is changed to zero
* Therefore DeleteLine security validation will be handled before removing line

---
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddProduct.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProduct.js
---
(0129713)
hgbot   
2021-06-22 12:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/569 [^]