Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047006Retail ModulesWeb POSpublic2021-05-31 14:482021-06-08 15:24
Reporteraferraz 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR20Q4.5Fixed in VersionRR20Q4.5 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in releaseRR20Q4
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047006: Discounts and taxes are recalculated for an already completed order when paying it
DescriptionDiscounts and taxes are recalculated for an already completed order when paying it
Steps To ReproduceLogin in OMNI-1 terminal:
- Create a ticket with one unit of "Avalanche transceiver" and complete it without paying. Check total amount is: 150.50.

Login in backoffice:
- Create a discount of 50% for "Avalanche transceiver" product.

Login in OMNI-1 terminal:
- Refresh data and open previously created order and add a payment. Check total amount is now: 75.25.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0046904 closed ranjith_qualiantech_com Discounts and taxes are recalculated for an already completed order when paying it 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-06-07 12:47marvintmTypedefect => backport
2021-06-07 12:47marvintmTarget Version => RR20Q4.5
2021-06-08 14:21hgbotMerge Request Status => open
2021-06-08 14:21hgbotNote Added: 0129185
2021-06-08 14:22hgbotNote Added: 0129186
2021-06-08 15:24hgbotMerge Request Statusopen => approved
2021-06-08 15:24hgbotResolutionopen => fixed
2021-06-08 15:24hgbotStatusscheduled => closed
2021-06-08 15:24hgbotNote Added: 0129192
2021-06-08 15:24hgbotFixed in Version => RR20Q4.5
2021-06-08 15:24hgbotNote Added: 0129193
2021-06-08 15:24hgbotNote Added: 0129194
2021-06-08 15:24hgbotNote Added: 0129195

Notes
(0129185)
hgbot   
2021-06-08 14:21   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/468 [^]
(0129186)
hgbot   
2021-06-08 14:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/27 [^]
(0129192)
hgbot   
2021-06-08 15:24   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/27 [^]
(0129193)
hgbot   
2021-06-08 15:24   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 923ee4aca2baaec7213ffb4a1655aa6a77d70a96
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-06-08T16:23:02+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/923ee4aca2baaec7213ffb4a1655aa6a77d70a96 [^]

Fixed ISSUE-47006: Discount should not be calculated if ticket is not editable

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js
---
(0129194)
hgbot   
2021-06-08 15:24   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: d5f79602e36895f162dd362b67f5d8b31e23c8ac
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-06-08T16:22:57+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d5f79602e36895f162dd362b67f5d8b31e23c8ac [^]

Related to ISSUE-47006: Taxes should not be calculated if ticket is not editable

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js
---
(0129195)
hgbot   
2021-06-08 15:24   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/468 [^]