Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047005Retail ModulesWeb POSpublic2021-05-31 14:482021-06-08 15:23
Reporteraferraz 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR21Q1.3Fixed in VersionRR21Q1.3 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in releaseRR20Q4
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047005: Discounts and taxes are recalculated for an already completed order when paying it
DescriptionDiscounts and taxes are recalculated for an already completed order when paying it
Steps To ReproduceLogin in OMNI-1 terminal:
- Create a ticket with one unit of "Avalanche transceiver" and complete it without paying. Check total amount is: 150.50.

Login in backoffice:
- Create a discount of 50% for "Avalanche transceiver" product.

Login in OMNI-1 terminal:
- Refresh data and open previously created order and add a payment. Check total amount is now: 75.25.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0046904 closed ranjith_qualiantech_com Discounts and taxes are recalculated for an already completed order when paying it 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-06-07 12:47marvintmTypedefect => backport
2021-06-07 12:47marvintmTarget Version => RR21Q1.3
2021-06-08 14:20hgbotNote Added: 0129183
2021-06-08 14:20hgbotNote Added: 0129184
2021-06-08 15:23hgbotNote Added: 0129188
2021-06-08 15:23hgbotNote Added: 0129189
2021-06-08 15:23hgbotResolutionopen => fixed
2021-06-08 15:23hgbotStatusscheduled => closed
2021-06-08 15:23hgbotNote Added: 0129190
2021-06-08 15:23hgbotFixed in Version => RR21Q1.3
2021-06-08 15:23hgbotNote Added: 0129191

Notes
(0129183)
hgbot   
2021-06-08 14:20   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/467 [^]
(0129184)
hgbot   
2021-06-08 14:20   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/26 [^]
(0129188)
hgbot   
2021-06-08 15:23   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: cfb34ce33f185e533f12b89350bc6944caaa1540
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-06-08T16:22:44+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/cfb34ce33f185e533f12b89350bc6944caaa1540 [^]

Related to ISSUE-47005: Taxes should not be calculated if ticket is not editable

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js
---
(0129189)
hgbot   
2021-06-08 15:23   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/467 [^]
(0129190)
hgbot   
2021-06-08 15:23   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/26 [^]
(0129191)
hgbot   
2021-06-08 15:23   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 0d9f14b6606163c954855836ded79c3bea6afcd1
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-06-08T16:22:50+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/0d9f14b6606163c954855836ded79c3bea6afcd1 [^]

Fixed ISSUE-47005: Discount should not be calculated if ticket is not editable

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js
---