Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046981Retail ModulesWeb POSpublic2021-06-03 16:112021-06-10 09:34
Reporterpsanjuan 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2021-04-13
Regression introduced in releaseRR20Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/4ae14c816476826e373a41181ce9748862ba7f24 [^]
Triggers an Emergency PackNo
Summary0046981: It is not possible to return a product/voucher gift card
DescriptionIt is not possible to return a product/voucher gift card
Steps To ReproduceConfigure a "product" gift card as described in the wiki below in Livebuilds (Retail with modules).

http://wiki.openbravo.com/wiki/Retail:Gift_Cards/Product_Gift_Cards_and_Gift_Vouchers#Returning_gift_cards_and_gift_vouchers [^]

Create a Sales order and include the Product Gift Card just created.
In the pop-up fill in the Gift Card owner, id, Initial balance and description. Press Apply.
Complete the sale and pay it in cash.

Go to the Openbravo backoffice, and verify that a new record has been created in the Gift Card Instance window.

Now go back to Openbravo Web POS.
As described in the wiki, use the menu option "Return this Receipt" to create a return. After that select the menu option "Gift/Credit Note" menu option.
Verify that the product gift card just created is shown in there with the initial balance.

Select it, and press on Return. A message is shown saying "Error Gift Card/voucher can be returned only on sales receipt"
See "Error1_46981" image attached.

Cancel that and delete the current receipt.

Create a normal sale, select the menu option "Gift/Credit Note" menu option.
Select the product gift card just created.

Once shown, press on Return button. Verify that nothing happens.
See "Error2_46981" image attached.

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0046997RR21Q2.1 closed ranjith_qualiantech_com It is not possible to return a product/voucher gift card 
depends on backport 0046998RR21Q1.3 closed ranjith_qualiantech_com It is not possible to return a product/voucher gift card 
depends on backport 0046999RR20Q4.5 closed ranjith_qualiantech_com It is not possible to return a product/voucher gift card 
caused by defect 0043445 closed ranjith_qualiantech_com Gift Card is cancelled when it is returned although it is not included in the ticket because negative lines are not allowed 
Attached Filespng Error1_46981.png (673,570) 2021-06-03 16:16
https://issues.openbravo.com/file_download.php?file_id=15881&type=bug
png Error2_46981.png (612,183) 2021-06-03 16:16
https://issues.openbravo.com/file_download.php?file_id=15882&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-06-03 16:11psanjuanNew Issue
2021-06-03 16:11psanjuanAssigned To => Retail
2021-06-03 16:11psanjuanTriggers an Emergency Pack => No
2021-06-03 16:12psanjuanFile Added: Error.png
2021-06-03 16:13psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=22675#r22675
2021-06-03 16:15psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=22676#r22676
2021-06-03 16:15psanjuanFile Deleted: Error.png
2021-06-03 16:16psanjuanFile Added: Error1_46981.png
2021-06-03 16:16psanjuanFile Added: Error2_46981.png
2021-06-03 16:17psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=22677#r22677
2021-06-03 17:19ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-06-07 01:46ranjith_qualiantech_comRelationship addedcaused by 0043445
2021-06-07 10:40marvintmRegression level => Production - Confirmed Stable
2021-06-07 10:40marvintmRegression date => 2021-04-13
2021-06-07 10:40marvintmRegression introduced in release => RR20Q3
2021-06-07 10:40marvintmRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/4ae14c816476826e373a41181ce9748862ba7f24 [^]
2021-06-07 10:40marvintmStatusnew => scheduled
2021-06-07 10:42hgbotNote Added: 0129131
2021-06-10 09:34hgbotResolutionopen => fixed
2021-06-10 09:34hgbotStatusscheduled => closed
2021-06-10 09:34hgbotNote Added: 0129307
2021-06-10 09:34hgbotNote Added: 0129308

Notes
(0129131)
hgbot   
2021-06-07 10:42   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/68 [^]
(0129307)
hgbot   
2021-06-10 09:34   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: c75f959450085f22c01bea832d20588d78c27ded
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-06-10T07:33:31+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/c75f959450085f22c01bea832d20588d78c27ded [^]

Fixed ISSUE-46981: Updated validation of receipt orderType when returning the gift card
* Gift Card should be returned only on sales receipt

---
M web/org.openbravo.retail.giftcards/js/components/GiftCardDetails.js
---
(0129308)
hgbot   
2021-06-10 09:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/68 [^]