Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046904Retail ModulesWeb POSpublic2021-05-31 14:482021-07-02 12:35
Reporteraferraz 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in releaseRR20Q4
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046904: Discounts and taxes are recalculated for an already completed order when paying it
DescriptionDiscounts and taxes are recalculated for an already completed order when paying it
Steps To ReproduceLogin in OMNI-1 terminal:
- Create a ticket with one unit of "Avalanche transceiver" and complete it without paying. Check total amount is: 150.50.

Login in backoffice:
- Create a discount of 50% for "Avalanche transceiver" product.

Login in OMNI-1 terminal:
- Refresh data and open previously created order and add a payment. Check total amount is now: 75.25.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0047321 closed ranjith_qualiantech_com Retail Modules Discounts removed when paying an already completed order 
depends on backport 0047004RR21Q2.1 closed ranjith_qualiantech_com Retail Modules Discounts and taxes are recalculated for an already completed order when paying it 
depends on backport 0047005RR21Q1.3 closed ranjith_qualiantech_com Retail Modules Discounts and taxes are recalculated for an already completed order when paying it 
depends on backport 0047006RR20Q4.5 closed ranjith_qualiantech_com Retail Modules Discounts and taxes are recalculated for an already completed order when paying it 
related to defect 0046787 closed aferraz Modules Magento connector doesn't import product price correctly when a discount is applied 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-05-31 14:48aferrazNew Issue
2021-05-31 14:48aferrazAssigned To => Retail
2021-05-31 14:48aferrazOBNetwork customer => No
2021-05-31 14:48aferrazTriggers an Emergency Pack => No
2021-05-31 14:55aferrazRegression level => Production - Confirmed Stable
2021-05-31 14:55aferrazRegression introduced in release => RR20Q4
2021-05-31 15:03aferrazRelationship addedrelated to 0046787
2021-05-31 17:35ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-06-07 12:47marvintmStatusnew => scheduled
2021-06-07 15:55hgbotMerge Request Status => open
2021-06-07 15:55hgbotNote Added: 0129145
2021-06-08 11:47hgbotNote Added: 0129174
2021-06-08 12:23hgbotMerge Request Statusopen => approved
2021-06-08 12:23hgbotResolutionopen => fixed
2021-06-08 12:23hgbotStatusscheduled => closed
2021-06-08 12:23hgbotFixed in Version => RR21Q3
2021-06-08 12:23hgbotNote Added: 0129176
2021-06-08 12:23hgbotNote Added: 0129177
2021-06-08 12:24hgbotNote Added: 0129178
2021-06-08 12:24hgbotNote Added: 0129179
2021-07-02 12:35aferrazRelationship addedrelated to 0047321

Notes
(0129145)
hgbot   
2021-06-07 15:55   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/24 [^]
(0129174)
hgbot   
2021-06-08 11:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/465 [^]
(0129176)
hgbot   
2021-06-08 12:23   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: f3b05af98ba996c604533d217ab3e8c2637b0261
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-06-07T19:04:08+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/f3b05af98ba996c604533d217ab3e8c2637b0261 [^]

Fixed ISSUE-46904: Discount should not be calculated if ticket is not editable

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js
---
(0129177)
hgbot   
2021-06-08 12:23   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/24 [^]
(0129178)
hgbot   
2021-06-08 12:24   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 550da2176b488d16c894e49d9a01dc1ca6dd4a58
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-06-08T10:23:52+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/550da2176b488d16c894e49d9a01dc1ca6dd4a58 [^]

Related to ISSUE-46904: Taxes should not be calculated if ticket is not editable

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js
---
(0129179)
hgbot   
2021-06-08 12:24   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/465 [^]