Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046875POS2POSpublic2021-05-27 16:562021-06-03 08:31
Reportergorka_gil 
Assigned Togorka_gil 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Versionpi 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046875: Change not printed in the ticket
DescriptionWhen pay more than needed, the change appear in the pos but not in the ticket.

To print the ticket it is called the utility function getChangeLabelFromTicket, that uses the getState().ticket.changePayments.

But looks like in pos2 is missing the changePayments.
Steps To ReproducePay an order with cash, with more amount that needed, for example pay with 100€ a ticket of 50€.
The change appear in the pos, but the printed ticket doesn't appear the change.
Proposed SolutionIn old pos, after addPayment it calls to calculateChange as part of updatePending.

Probably needed to move the calculateChange inside the addpPayment action
Additional Information
TagsNo tags attached.
Relationships
related to defect 0046926 closed justin_patterson Retail Modules JIRA 1123: The feature introduced behind preference "WebPOS Split Change in Different Payment Details" is not managed with state 
depends on backport 0046876TAP closed gorka_gil POS2 Change not printed in the ticket 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-05-27 16:56gorka_gilNew Issue
2021-05-27 16:56gorka_gilAssigned To => Retail
2021-05-27 16:56gorka_gilOBNetwork customer => No
2021-05-27 16:56gorka_gilTriggers an Emergency Pack => No
2021-05-27 16:56gorka_gilStatusnew => acknowledged
2021-05-27 16:57gorka_gilAssigned ToRetail => gorka_gil
2021-05-27 16:59gorka_gilResolution time => 1620684000
2021-05-27 17:00gorka_gilStatusacknowledged => scheduled
2021-05-27 17:01guilleaerResolution time1620684000 => 1623362400
2021-05-27 17:18gorka_gilOBNetwork customerNo => OBPS
2021-05-31 15:17hgbotMerge Request Status => open
2021-05-31 15:17hgbotNote Added: 0128817
2021-06-01 12:37gorka_gilRelationship addedrelated to 0046926
2021-06-03 08:30hgbotMerge Request Statusopen => approved
2021-06-03 08:31hgbotNote Added: 0128983
2021-06-03 08:31hgbotNote Added: 0128984
2021-06-03 08:31marvintmStatusscheduled => resolved
2021-06-03 08:31marvintmFixed in Version => pi
2021-06-03 08:31marvintmResolutionopen => fixed
2021-06-03 08:31marvintmReview Assigned To => marvintm
2021-06-03 08:31marvintmStatusresolved => closed

Notes
(0128817)
hgbot   
2021-05-31 15:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/441 [^]
(0128983)
hgbot   
2021-06-03 08:31   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 374dd0aec45b573bdb4481a60213aba701c64ad7
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2021-06-03T06:30:49+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/374dd0aec45b573bdb4481a60213aba701c64ad7 [^]

Fix ISSUE-46875: Fix change in the printed ticket

This is temporary fix till multicurrency is implemented in pos2,
this commit can be reverted, since should be checked the
ticket.changePayments, instead the ticket.change

---
M web/org.openbravo.retail.posterminal/app/external-device/printing/PrintUtils.js
---
(0128984)
hgbot   
2021-06-03 08:31   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/441 [^]