Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046862Retail ModulesWeb POSpublic2021-05-27 11:532021-06-10 08:11
Reportermaite 
Assigned Torqueralta 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q3 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046862: Payment not correctly removed when it has been considered as "change payment"
DescriptionPayment related to a ticket of a total 0 is considered as "change payment". However, when the cashier removes the payment it is not removed from the "change payments" section
Steps To Reproduce1. Add any product to the ticket
2. Add payment in Cash
3. Delete line, so the ticket's total is 0 but the payment is still there in ChangePayments section (OB.MobileApp.model.receipt.attributes.changePayments)
4. Remove the payment
5. But realize that it has not been removed from changePayments section
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0047280 closed rqueralta Change Payments info wrongly calculated 
Attached Filespatch 0001-Fixed-BUG-46862-If-receipt-gross-amount-is-0-remove-.patch (1,287) 2021-06-08 21:37
https://issues.openbravo.com/file_download.php?file_id=15903&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-05-27 11:53maiteNew Issue
2021-05-27 11:53maiteAssigned To => Retail
2021-05-27 11:53maiteResolution time => 1623276000
2021-05-27 11:53maiteTriggers an Emergency Pack => No
2021-06-01 00:28rqueraltaAssigned ToRetail => rqueralta
2021-06-01 00:28rqueraltaStatusnew => scheduled
2021-06-03 05:33hgbotNote Added: 0128975
2021-06-03 21:26hgbotNote Added: 0129037
2021-06-04 04:51hgbotNote Added: 0129044
2021-06-05 14:26hgbotNote Added: 0129093
2021-06-07 00:02hgbotNote Added: 0129095
2021-06-07 15:38hgbotNote Added: 0129142
2021-06-07 15:49hgbotNote Added: 0129144
2021-06-08 11:19hgbotNote Added: 0129170
2021-06-08 11:19hgbotResolutionopen => fixed
2021-06-08 11:19hgbotStatusscheduled => closed
2021-06-08 11:19hgbotFixed in Version => RR21Q3
2021-06-08 11:19hgbotNote Added: 0129171
2021-06-08 21:37rqueraltaFile Added: 0001-Fixed-BUG-46862-If-receipt-gross-amount-is-0-remove-.patch
2021-06-09 06:52hgbotNote Added: 0129211
2021-06-09 06:52marvintmStatusclosed => new
2021-06-09 06:52marvintmResolutionfixed => open
2021-06-09 06:52marvintmFixed in VersionRR21Q3 =>
2021-06-09 20:22hgbotNote Added: 0129287
2021-06-10 08:11hgbotResolutionopen => fixed
2021-06-10 08:11hgbotStatusnew => closed
2021-06-10 08:11hgbotFixed in Version => RR21Q3
2021-06-10 08:11hgbotNote Added: 0129297
2021-06-10 08:11hgbotNote Added: 0129298
2021-06-29 14:02maiteRelationship addedrelated to 0047280

Notes
(0128975)
hgbot   
2021-06-03 05:33   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/451 [^]
(0129037)
hgbot   
2021-06-03 21:26   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/451 [^]
(0129044)
hgbot   
2021-06-04 04:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/457 [^]
(0129093)
hgbot   
2021-06-05 14:26   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/457 [^]
(0129095)
hgbot   
2021-06-07 00:02   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/459 [^]
(0129142)
hgbot   
2021-06-07 15:38   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/459 [^]
(0129144)
hgbot   
2021-06-07 15:49   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/463 [^]
(0129170)
hgbot   
2021-06-08 11:19   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/463 [^]
(0129171)
hgbot   
2021-06-08 11:19   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 5f4cea2d4031bea62c39750c58c9fc0372258339
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-06-08T09:18:52+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/5f4cea2d4031bea62c39750c58c9fc0372258339 [^]

Fixed BUG-46862: If receipt gross amount is 0 remove changePayments property

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeletePayment.js
---
(0129211)
hgbot   
2021-06-09 06:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a4d9f42d9c2e7d80a8e08d6061e6573fdb43b722
Author: Antonio Moreno <anmorenoperez@gmail.com>
Date: 2021-06-09T06:52:29+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a4d9f42d9c2e7d80a8e08d6061e6573fdb43b722 [^]

Related to ISSUE-46862. Reverted change as it was causing some Jest tests to fail

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeletePayment.js
---
(0129287)
hgbot   
2021-06-09 20:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/472 [^]
(0129297)
hgbot   
2021-06-10 08:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 645b769685a2164d64f30da10b30cfd5efebc24f
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-06-09T11:02:18-04:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/645b769685a2164d64f30da10b30cfd5efebc24f [^]

Fixed BUG-46862: If receipt gross amount is 0 remove changePayments property

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeletePayment.js
---
(0129298)
hgbot   
2021-06-10 08:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/472 [^]