0046854: Wrong starting amount in cashup when there is only one payment method

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0046854

Retail Modules

Cash up

public

2021-05-19 17:10

2021-05-27 16:30

Reporter

malsasua

Assigned To

rqueralta

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR21Q2.1

Fixed in Version

RR21Q2

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0046854: Wrong starting amount in cashup when there is only one payment method

Description

When there is only one payment method defined in the terminal, the starting amount cashup is retrieved from financial account current balance instead of amount to keep of previous cashup

Steps To Reproduce

[BO]
. go to touchpoint - VBS-1 - tab: payment method
- deactivate all payment methods except cash
. go to financial account of payment method cash:
- create a new transaction (for example, amount 5) and process:
financial account current balance: 5

[POS]
. do login
. do cashup:
- amount to keep 0
. do cashup
- starting amount: 5

Proposed Solution

the problem is in this line:
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/app/model/business-object/cashup/PaymentMethodUtils.js#L27 [^]
if lastCashUpPayments.length is 1, then the condition is not satisfied, and the startingCash is not overwritten

Additional Information